[INFO] updating cached repository acmumn/dip [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/acmumn/dip [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/acmumn/dip" "work/ex/clippy-test-run/sources/stable/gh/acmumn/dip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/acmumn/dip'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/acmumn/dip" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/acmumn/dip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/acmumn/dip'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9c48c9ef1bb714b242c821a969280895e0e5e4c2 [INFO] sha for GitHub repo acmumn/dip: 9c48c9ef1bb714b242c821a969280895e0e5e4c2 [INFO] validating manifest of acmumn/dip on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of acmumn/dip on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing acmumn/dip [INFO] finished frobbing acmumn/dip [INFO] frobbed toml for acmumn/dip written to work/ex/clippy-test-run/sources/stable/gh/acmumn/dip/Cargo.toml [INFO] started frobbing acmumn/dip [INFO] finished frobbing acmumn/dip [INFO] frobbed toml for acmumn/dip written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/acmumn/dip/Cargo.toml [INFO] crate acmumn/dip has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting acmumn/dip against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/acmumn/dip:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83550a317c28670a68aaa4d7e00ef4c9376ec81a1530784df4e848c5d7ab1624 [INFO] running `"docker" "start" "-a" "83550a317c28670a68aaa4d7e00ef4c9376ec81a1530784df4e848c5d7ab1624"` [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Checking inotify v0.3.0 [INFO] [stderr] Checking secstr v0.3.0 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking uuid v0.1.18 [INFO] [stderr] Compiling syn v0.14.8 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking crypto-mac v0.6.2 [INFO] [stderr] Checking tokio-signal v0.2.2 [INFO] [stderr] Checking sha-1 v0.7.0 [INFO] [stderr] Checking hmac v0.6.3 [INFO] [stderr] Checking hyper v0.12.8 [INFO] [stderr] Checking mktemp v0.3.1 [INFO] [stderr] Checking tokio-process v0.2.2 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v4.0.4 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Compiling serde_derive v1.0.71 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking dip v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:97:22 [INFO] [stderr] | [INFO] [stderr] 97 | .ok_or(err_msg("???")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("???"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config.rs:97:22 [INFO] [stderr] | [INFO] [stderr] 97 | .ok_or(err_msg("???")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("???"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/github.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | .ok_or(err_msg("Missing auth header")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Missing auth header"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/handler.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | .ok_or(err_msg("'type' is not a string."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("'type' is not a string."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/handler.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | .ok_or(err_msg("No 'type' found."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("No 'type' found."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/handler.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | .ok_or(err_msg("'command' is not a string."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("'command' is not a string."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/handler.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | .ok_or(err_msg("No 'command' found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("No 'command' found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/github.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | .ok_or(err_msg("Missing auth header")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Missing auth header"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/hook.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | .ok_or(err_msg("'handlers' is not an array."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("'handlers' is not an array."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/hook.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | .ok_or(err_msg("No 'handlers' found."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("No 'handlers' found."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/handler.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | .ok_or(err_msg("'type' is not a string."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("'type' is not a string."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/handler.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | .ok_or(err_msg("No 'type' found."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("No 'type' found."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/handler.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | .ok_or(err_msg("'command' is not a string."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("'command' is not a string."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/handler.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | .ok_or(err_msg("No 'command' found"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("No 'command' found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/hook.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | .ok_or(err_msg("???"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("???"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/hook.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .ok_or(err_msg("what the fuck bro"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("what the fuck bro"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/hook.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | .ok_or(err_msg("'handlers' is not an array."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("'handlers' is not an array."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/hook.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | .ok_or(err_msg("No 'handlers' found."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("No 'handlers' found."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/hook.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | .ok_or(err_msg("???"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("???"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/hook.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .ok_or(err_msg("what the fuck bro"))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("what the fuck bro"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 55.59s [INFO] running `"docker" "inspect" "83550a317c28670a68aaa4d7e00ef4c9376ec81a1530784df4e848c5d7ab1624"` [INFO] running `"docker" "rm" "-f" "83550a317c28670a68aaa4d7e00ef4c9376ec81a1530784df4e848c5d7ab1624"` [INFO] [stdout] 83550a317c28670a68aaa4d7e00ef4c9376ec81a1530784df4e848c5d7ab1624