[INFO] updating cached repository aclemmensen/cargo-local-search
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/aclemmensen/cargo-local-search
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/aclemmensen/cargo-local-search" "work/ex/clippy-test-run/sources/stable/gh/aclemmensen/cargo-local-search"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aclemmensen/cargo-local-search'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/aclemmensen/cargo-local-search" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aclemmensen/cargo-local-search"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aclemmensen/cargo-local-search'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] cb8f660daaaec884185e143ab5d90cdc4a5b817b
[INFO] sha for GitHub repo aclemmensen/cargo-local-search: cb8f660daaaec884185e143ab5d90cdc4a5b817b
[INFO] validating manifest of aclemmensen/cargo-local-search on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of aclemmensen/cargo-local-search on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing aclemmensen/cargo-local-search
[INFO] finished frobbing aclemmensen/cargo-local-search
[INFO] frobbed toml for aclemmensen/cargo-local-search written to work/ex/clippy-test-run/sources/stable/gh/aclemmensen/cargo-local-search/Cargo.toml
[INFO] started frobbing aclemmensen/cargo-local-search
[INFO] finished frobbing aclemmensen/cargo-local-search
[INFO] frobbed toml for aclemmensen/cargo-local-search written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aclemmensen/cargo-local-search/Cargo.toml
[INFO] crate aclemmensen/cargo-local-search has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting aclemmensen/cargo-local-search against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aclemmensen/cargo-local-search:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e5b5ae513a57782868d6973a4737aa0d87b9323ebf26cdfe3b60bcaaddad8148
[INFO] running `"docker" "start" "-a" "e5b5ae513a57782868d6973a4737aa0d87b9323ebf26cdfe3b60bcaaddad8148"`
[INFO] [stderr]    Compiling cmake v0.1.31
[INFO] [stderr]    Compiling libz-sys v1.0.18
[INFO] [stderr]     Checking num-bigint v0.1.43
[INFO] [stderr]     Checking which v2.0.0
[INFO] [stderr]    Compiling libgit2-sys v0.7.1
[INFO] [stderr]     Checking num-rational v0.1.42
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking stopwatch v0.0.7
[INFO] [stderr]     Checking git2 v0.7.1
[INFO] [stderr]     Checking cargo-local-search v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 |     return Ok(items);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(items)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 |     return Ok(items);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(items)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ranking.rs:16:21
[INFO] [stderr]    |
[INFO] [stderr] 16 | fn score_name(name: &String, pattern: &Regex) -> Option<i32> {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/ranking.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         score = score + (i2 - (i1 + 1));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `score += (i2 - (i1 + 1))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/ranking.rs:75:28
[INFO] [stderr]    |
[INFO] [stderr] 75 | pub fn search_names(names: &Vec<String>, input: &str) -> Result<Vec<(String, i32)>, regex::Error> {
[INFO] [stderr]    |                            ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/ranking.rs:16:21
[INFO] [stderr]    |
[INFO] [stderr] 16 | fn score_name(name: &String, pattern: &Regex) -> Option<i32> {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/ranking.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         score = score + (i2 - (i1 + 1));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `score += (i2 - (i1 + 1))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/ranking.rs:75:28
[INFO] [stderr]    |
[INFO] [stderr] 75 | pub fn search_names(names: &Vec<String>, input: &str) -> Result<Vec<(String, i32)>, regex::Error> {
[INFO] [stderr]    |                            ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 37.89s
[INFO] running `"docker" "inspect" "e5b5ae513a57782868d6973a4737aa0d87b9323ebf26cdfe3b60bcaaddad8148"`
[INFO] running `"docker" "rm" "-f" "e5b5ae513a57782868d6973a4737aa0d87b9323ebf26cdfe3b60bcaaddad8148"`
[INFO] [stdout] e5b5ae513a57782868d6973a4737aa0d87b9323ebf26cdfe3b60bcaaddad8148