[INFO] updating cached repository achntrl/logmonitoring [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/achntrl/logmonitoring [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/achntrl/logmonitoring" "work/ex/clippy-test-run/sources/stable/gh/achntrl/logmonitoring"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/achntrl/logmonitoring'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/achntrl/logmonitoring" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/achntrl/logmonitoring"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/achntrl/logmonitoring'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c2c23245e86dcd5fd0ba8f20194d465ecdb5cf4 [INFO] sha for GitHub repo achntrl/logmonitoring: 8c2c23245e86dcd5fd0ba8f20194d465ecdb5cf4 [INFO] validating manifest of achntrl/logmonitoring on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of achntrl/logmonitoring on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing achntrl/logmonitoring [INFO] finished frobbing achntrl/logmonitoring [INFO] frobbed toml for achntrl/logmonitoring written to work/ex/clippy-test-run/sources/stable/gh/achntrl/logmonitoring/Cargo.toml [INFO] started frobbing achntrl/logmonitoring [INFO] finished frobbing achntrl/logmonitoring [INFO] frobbed toml for achntrl/logmonitoring written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/achntrl/logmonitoring/Cargo.toml [INFO] crate achntrl/logmonitoring has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting achntrl/logmonitoring against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/achntrl/logmonitoring:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cb8b462b8354ff541e90f55b9b16c7b1ec856f74db7bcf2d2d772d443afba630 [INFO] running `"docker" "start" "-a" "cb8b462b8354ff541e90f55b9b16c7b1ec856f74db7bcf2d2d772d443afba630"` [INFO] [stderr] Checking chrono v0.4.3 [INFO] [stderr] Checking logmonitoring v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused import: `TimeZone` [INFO] [stderr] --> src/consumer/alerter.rs:3:31 [INFO] [stderr] | [INFO] [stderr] 3 | use chrono::{DateTime, Local, TimeZone}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `threshold` [INFO] [stderr] --> src/consumer/alerter.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | fn new(threshold: u32) -> Alerter { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_threshold` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `current_alert` [INFO] [stderr] --> src/consumer/alerter.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | current_alert: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `threshold` [INFO] [stderr] --> src/consumer/alerter.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | threshold: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/consumer/alerter.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | fn new(time: DateTime) -> Alert { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `recover` [INFO] [stderr] --> src/consumer/alerter.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | fn recover(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/consumer/alerter.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | fn new(threshold: u32) -> Alerter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/consumer/alerter.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self.recovered { [INFO] [stderr] 43 | | true => write!( [INFO] [stderr] 44 | | f, [INFO] [stderr] 45 | | " Alert raised at {} and recovered at {}", [INFO] [stderr] ... | [INFO] [stderr] 54 | | ), [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 42 | if self.recovered { write!( [INFO] [stderr] 43 | f, [INFO] [stderr] 44 | " Alert raised at {} and recovered at {}", [INFO] [stderr] 45 | self.time.format("%d %b %Y %H:%M:%S"), [INFO] [stderr] 46 | self.recovered_time.unwrap().format("%d %b %Y %H:%M:%S") [INFO] [stderr] 47 | ) } else { write!( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | if contents.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!contents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:69:15 [INFO] [stderr] | [INFO] [stderr] 69 | while queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused import: `TimeZone` [INFO] [stderr] --> src/consumer/alerter.rs:3:31 [INFO] [stderr] | [INFO] [stderr] 3 | use chrono::{DateTime, Local, TimeZone}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `threshold` [INFO] [stderr] --> src/consumer/alerter.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | fn new(threshold: u32) -> Alerter { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_threshold` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `current_alert` [INFO] [stderr] --> src/consumer/alerter.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | current_alert: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `threshold` [INFO] [stderr] --> src/consumer/alerter.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | threshold: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/consumer/alerter.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | fn new(time: DateTime) -> Alert { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `recover` [INFO] [stderr] --> src/consumer/alerter.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | fn recover(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/consumer/alerter.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self.recovered { [INFO] [stderr] 43 | | true => write!( [INFO] [stderr] 44 | | f, [INFO] [stderr] 45 | | " Alert raised at {} and recovered at {}", [INFO] [stderr] ... | [INFO] [stderr] 54 | | ), [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 42 | if self.recovered { write!( [INFO] [stderr] 43 | f, [INFO] [stderr] 44 | " Alert raised at {} and recovered at {}", [INFO] [stderr] 45 | self.time.format("%d %b %Y %H:%M:%S"), [INFO] [stderr] 46 | self.recovered_time.unwrap().format("%d %b %Y %H:%M:%S") [INFO] [stderr] 47 | ) } else { write!( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | if contents.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!contents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:69:15 [INFO] [stderr] | [INFO] [stderr] 69 | while queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.46s [INFO] running `"docker" "inspect" "cb8b462b8354ff541e90f55b9b16c7b1ec856f74db7bcf2d2d772d443afba630"` [INFO] running `"docker" "rm" "-f" "cb8b462b8354ff541e90f55b9b16c7b1ec856f74db7bcf2d2d772d443afba630"` [INFO] [stdout] cb8b462b8354ff541e90f55b9b16c7b1ec856f74db7bcf2d2d772d443afba630