[INFO] updating cached repository achan1989/rust_gfx_breakout [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/achan1989/rust_gfx_breakout [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/achan1989/rust_gfx_breakout" "work/ex/clippy-test-run/sources/stable/gh/achan1989/rust_gfx_breakout"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/achan1989/rust_gfx_breakout'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/achan1989/rust_gfx_breakout" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/achan1989/rust_gfx_breakout"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/achan1989/rust_gfx_breakout'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 33879bd48f9f894dbc3d775a7803efb745de7584 [INFO] sha for GitHub repo achan1989/rust_gfx_breakout: 33879bd48f9f894dbc3d775a7803efb745de7584 [INFO] validating manifest of achan1989/rust_gfx_breakout on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of achan1989/rust_gfx_breakout on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing achan1989/rust_gfx_breakout [INFO] finished frobbing achan1989/rust_gfx_breakout [INFO] frobbed toml for achan1989/rust_gfx_breakout written to work/ex/clippy-test-run/sources/stable/gh/achan1989/rust_gfx_breakout/Cargo.toml [INFO] started frobbing achan1989/rust_gfx_breakout [INFO] finished frobbing achan1989/rust_gfx_breakout [INFO] frobbed toml for achan1989/rust_gfx_breakout written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/achan1989/rust_gfx_breakout/Cargo.toml [INFO] crate achan1989/rust_gfx_breakout has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting achan1989/rust_gfx_breakout against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/achan1989/rust_gfx_breakout:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 18943d62ab23f17d9ae222675d95ccbb6269f613079ba25ebc0eec77ca46b78e [INFO] running `"docker" "start" "-a" "18943d62ab23f17d9ae222675d95ccbb6269f613079ba25ebc0eec77ca46b78e"` [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Checking cgmath v0.16.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking glfw v0.20.0 [INFO] [stderr] Checking gfx_window_glfw v0.16.0 [INFO] [stderr] Checking rust_gfx_breakout v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: field is never used: `projection` [INFO] [stderr] --> src/game.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | projection: cgmath::Matrix4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/collision.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn nearest_from(target: &cgmath::Vector2) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `cgmath::Vector2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game_level.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | / if let &TileKind::Empty = tile { [INFO] [stderr] 116 | | continue; [INFO] [stderr] 117 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | if let TileKind::Empty = *tile { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/game_level.rs:125:28 [INFO] [stderr] | [INFO] [stderr] 125 | if let None = texture { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 126 | | bail!("no texture resource for {}", texture_name); [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____________________- help: try this: `if texture.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/game_level.rs:180:12 [INFO] [stderr] | [INFO] [stderr] 180 | if tile_data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tile_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/renderer.rs:28:30 [INFO] [stderr] | [INFO] [stderr] 28 | pub type RenderTargetView = [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/renderer.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | .map_err(|e| gfx::PipelineStateError::::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `gfx::PipelineStateError::::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: field is never used: `projection` [INFO] [stderr] --> src/game.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | projection: cgmath::Matrix4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/collision.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn nearest_from(target: &cgmath::Vector2) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `cgmath::Vector2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game_level.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | / if let &TileKind::Empty = tile { [INFO] [stderr] 116 | | continue; [INFO] [stderr] 117 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | if let TileKind::Empty = *tile { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/game_level.rs:125:28 [INFO] [stderr] | [INFO] [stderr] 125 | if let None = texture { [INFO] [stderr] | _____________________- ^^^^ [INFO] [stderr] 126 | | bail!("no texture resource for {}", texture_name); [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____________________- help: try this: `if texture.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/game_level.rs:180:12 [INFO] [stderr] | [INFO] [stderr] 180 | if tile_data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tile_data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/renderer.rs:28:30 [INFO] [stderr] | [INFO] [stderr] 28 | pub type RenderTargetView = [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/renderer.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | .map_err(|e| gfx::PipelineStateError::::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `gfx::PipelineStateError::::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/bin/main.rs:40:26 [INFO] [stderr] | [INFO] [stderr] 40 | type RenderTargetView = [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/bin/main.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | type DepthStencilView = [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/bin/main.rs:129:8 [INFO] [stderr] | [INFO] [stderr] 129 | -> Result<( [INFO] [stderr] | ________^ [INFO] [stderr] 130 | | EventQueue, [INFO] [stderr] 131 | | glfw::Glfw, [INFO] [stderr] 132 | | glfw::Window, [INFO] [stderr] ... | [INFO] [stderr] 135 | | gfx_device_gl::Factory, [INFO] [stderr] 136 | | gfx_device_gl::Resources>)> [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/bin/main.rs:40:26 [INFO] [stderr] | [INFO] [stderr] 40 | type RenderTargetView = [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/bin/main.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | type DepthStencilView = [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/bin/main.rs:129:8 [INFO] [stderr] | [INFO] [stderr] 129 | -> Result<( [INFO] [stderr] | ________^ [INFO] [stderr] 130 | | EventQueue, [INFO] [stderr] 131 | | glfw::Glfw, [INFO] [stderr] 132 | | glfw::Window, [INFO] [stderr] ... | [INFO] [stderr] 135 | | gfx_device_gl::Factory, [INFO] [stderr] 136 | | gfx_device_gl::Resources>)> [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.31s [INFO] running `"docker" "inspect" "18943d62ab23f17d9ae222675d95ccbb6269f613079ba25ebc0eec77ca46b78e"` [INFO] running `"docker" "rm" "-f" "18943d62ab23f17d9ae222675d95ccbb6269f613079ba25ebc0eec77ca46b78e"` [INFO] [stdout] 18943d62ab23f17d9ae222675d95ccbb6269f613079ba25ebc0eec77ca46b78e