[INFO] updating cached repository abusch/xld-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/abusch/xld-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/abusch/xld-rs" "work/ex/clippy-test-run/sources/stable/gh/abusch/xld-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/abusch/xld-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/abusch/xld-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abusch/xld-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abusch/xld-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c7f791d1865f62b51ae140c844ca1e25c7180c9a [INFO] sha for GitHub repo abusch/xld-rs: c7f791d1865f62b51ae140c844ca1e25c7180c9a [INFO] validating manifest of abusch/xld-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of abusch/xld-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing abusch/xld-rs [INFO] finished frobbing abusch/xld-rs [INFO] frobbed toml for abusch/xld-rs written to work/ex/clippy-test-run/sources/stable/gh/abusch/xld-rs/Cargo.toml [INFO] started frobbing abusch/xld-rs [INFO] finished frobbing abusch/xld-rs [INFO] frobbed toml for abusch/xld-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abusch/xld-rs/Cargo.toml [INFO] crate abusch/xld-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting abusch/xld-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/abusch/xld-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ce67079b20e78e646eff709ee3da7a18a7adfc2756f6f321d68f218d10d78619 [INFO] running `"docker" "start" "-a" "ce67079b20e78e646eff709ee3da7a18a7adfc2756f6f321d68f218d10d78619"` [INFO] [stderr] Compiling x11 v2.18.0 [INFO] [stderr] Checking xld-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `dpi` [INFO] [stderr] --> src/xrandrutils.rs:15:68 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn render_xrandr_command(outputs: &[Output], primary: &Output, dpi: u32) -> Command { [INFO] [stderr] | ^^^ help: consider using `_dpi` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/calculations.rs:47:33 [INFO] [stderr] | [INFO] [stderr] 47 | if primary.is_none() || (&output.name == desired_primary) { [INFO] [stderr] | ^------------^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `output.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/xrandrutils.rs:20:16 [INFO] [stderr] | [INFO] [stderr] 20 | if &output.name == &primary.name { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 20 | if output.name == primary.name { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dpi` [INFO] [stderr] --> src/xrandrutils.rs:15:68 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn render_xrandr_command(outputs: &[Output], primary: &Output, dpi: u32) -> Command { [INFO] [stderr] | ^^^ help: consider using `_dpi` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/calculations.rs:47:33 [INFO] [stderr] | [INFO] [stderr] 47 | if primary.is_none() || (&output.name == desired_primary) { [INFO] [stderr] | ^------------^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `output.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/xrandrutils.rs:20:16 [INFO] [stderr] | [INFO] [stderr] 20 | if &output.name == &primary.name { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 20 | if output.name == primary.name { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.81s [INFO] running `"docker" "inspect" "ce67079b20e78e646eff709ee3da7a18a7adfc2756f6f321d68f218d10d78619"` [INFO] running `"docker" "rm" "-f" "ce67079b20e78e646eff709ee3da7a18a7adfc2756f6f321d68f218d10d78619"` [INFO] [stdout] ce67079b20e78e646eff709ee3da7a18a7adfc2756f6f321d68f218d10d78619