[INFO] updating cached repository abusch/rtiow [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/abusch/rtiow [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/abusch/rtiow" "work/ex/clippy-test-run/sources/stable/gh/abusch/rtiow"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/abusch/rtiow'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/abusch/rtiow" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abusch/rtiow"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abusch/rtiow'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7d04d8a49f28cee7952a173da8115a40379326fb [INFO] sha for GitHub repo abusch/rtiow: 7d04d8a49f28cee7952a173da8115a40379326fb [INFO] validating manifest of abusch/rtiow on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of abusch/rtiow on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing abusch/rtiow [INFO] finished frobbing abusch/rtiow [INFO] frobbed toml for abusch/rtiow written to work/ex/clippy-test-run/sources/stable/gh/abusch/rtiow/Cargo.toml [INFO] started frobbing abusch/rtiow [INFO] finished frobbing abusch/rtiow [INFO] frobbed toml for abusch/rtiow written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abusch/rtiow/Cargo.toml [INFO] crate abusch/rtiow has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting abusch/rtiow against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/abusch/rtiow:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e02a4d3f36dfbc654226afa8d93e36a13e1e02cf3bcdbfa34539f920c3fc962 [INFO] running `"docker" "start" "-a" "8e02a4d3f36dfbc654226afa8d93e36a13e1e02cf3bcdbfa34539f920c3fc962"` [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking env_logger v0.5.6 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking rtiow v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable/sphere.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | let (u, v) = get_sphere_uv(&((&rec.p - &self.center) / self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hitable/sphere.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | let (u, v) = get_sphere_uv(&((&rec.p - &self.center) / self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable/sphere.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | let (u, v) = get_sphere_uv(&((&rec.p - &self.center) / self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hitable/sphere.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | let (u, v) = get_sphere_uv(&((&rec.p - &self.center) / self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | let i = f32::floor(p.x()) as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | let j = f32::floor(p.y()) as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | let k = f32::floor(p.z()) as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let mut c = [[[Vec3::default(); 2]; 2]; 2]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/texture.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | let r = self.data[3 * i + 3 * self.nx as usize * j] as f32 / 255.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/texture.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | let g = self.data[3 * i + 3 * self.nx as usize * j + 1] as f32 / 255.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/texture.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | let b = self.data[3 * i + 3 * self.nx as usize * j + 2] as f32 / 255.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable/sphere.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | let (u, v) = get_sphere_uv(&((&rec.p - &self.center) / self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hitable/sphere.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | let (u, v) = get_sphere_uv(&((&rec.p - &self.center) / self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable/sphere.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | let (u, v) = get_sphere_uv(&((&rec.p - &self.center) / self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hitable/sphere.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | let (u, v) = get_sphere_uv(&((&rec.p - &self.center) / self.radius)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | let i = f32::floor(p.x()) as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | let j = f32::floor(p.y()) as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | let k = f32::floor(p.z()) as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/perlin.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let mut c = [[[Vec3::default(); 2]; 2]; 2]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/texture.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | let r = self.data[3 * i + 3 * self.nx as usize * j] as f32 / 255.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/texture.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | let g = self.data[3 * i + 3 * self.nx as usize * j + 1] as f32 / 255.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/texture.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | let b = self.data[3 * i + 3 * self.nx as usize * j + 2] as f32 / 255.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/vec.rs:154:44 [INFO] [stderr] | [INFO] [stderr] 154 | #[cfg_attr(feature = "cargo-clippy", allow(suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/vec.rs:165:44 [INFO] [stderr] | [INFO] [stderr] 165 | #[cfg_attr(feature = "cargo-clippy", allow(suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/vec.rs:154:44 [INFO] [stderr] | [INFO] [stderr] 154 | #[cfg_attr(feature = "cargo-clippy", allow(suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/vec.rs:154:44 [INFO] [stderr] | [INFO] [stderr] 154 | #[cfg_attr(feature = "cargo-clippy", allow(suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/vec.rs:165:44 [INFO] [stderr] | [INFO] [stderr] 165 | #[cfg_attr(feature = "cargo-clippy", allow(suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/vec.rs:154:44 [INFO] [stderr] | [INFO] [stderr] 154 | #[cfg_attr(feature = "cargo-clippy", allow(suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `u` [INFO] [stderr] --> src/material.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | fn emitted(&self, u: f32, v: f32, p: &Vec3) -> Vec3 { [INFO] [stderr] | ^ help: consider using `_u` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/material.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | fn emitted(&self, u: f32, v: f32, p: &Vec3) -> Vec3 { [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/material.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | fn emitted(&self, u: f32, v: f32, p: &Vec3) -> Vec3 { [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t0` [INFO] [stderr] --> src/bvh.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t1` [INFO] [stderr] --> src/bvh.rs:82:37 [INFO] [stderr] | [INFO] [stderr] 82 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t0` [INFO] [stderr] --> src/hitable/boxx.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t1` [INFO] [stderr] --> src/hitable/boxx.rs:82:37 [INFO] [stderr] | [INFO] [stderr] 82 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t0` [INFO] [stderr] --> src/hitable/sphere.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t1` [INFO] [stderr] --> src/hitable/sphere.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t0` [INFO] [stderr] --> src/hitable/sphere.rs:136:28 [INFO] [stderr] | [INFO] [stderr] 136 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t1` [INFO] [stderr] --> src/hitable/sphere.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `u` [INFO] [stderr] --> src/texture.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | fn value(&self, u: f32, v: f32, p: &Vec3) -> Vec3 { [INFO] [stderr] | ^ help: consider using `_u` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/texture.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | fn value(&self, u: f32, v: f32, p: &Vec3) -> Vec3 { [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/texture.rs:27:37 [INFO] [stderr] | [INFO] [stderr] 27 | fn value(&self, u: f32, v: f32, p: &Vec3) -> Vec3 { [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `u` [INFO] [stderr] --> src/material.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | fn emitted(&self, u: f32, v: f32, p: &Vec3) -> Vec3 { [INFO] [stderr] | ^ help: consider using `_u` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/material.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | fn emitted(&self, u: f32, v: f32, p: &Vec3) -> Vec3 { [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/material.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | fn emitted(&self, u: f32, v: f32, p: &Vec3) -> Vec3 { [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t0` [INFO] [stderr] --> src/bvh.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t1` [INFO] [stderr] --> src/bvh.rs:82:37 [INFO] [stderr] | [INFO] [stderr] 82 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t0` [INFO] [stderr] --> src/hitable/boxx.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t1` [INFO] [stderr] --> src/hitable/boxx.rs:82:37 [INFO] [stderr] | [INFO] [stderr] 82 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t0` [INFO] [stderr] --> src/hitable/sphere.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t1` [INFO] [stderr] --> src/hitable/sphere.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t0` [INFO] [stderr] --> src/hitable/sphere.rs:136:28 [INFO] [stderr] | [INFO] [stderr] 136 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t0` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `t1` [INFO] [stderr] --> src/hitable/sphere.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | fn bounding_box(&self, t0: f32, t1: f32, aabb: &mut Aabb) -> bool { [INFO] [stderr] | ^^ help: consider using `_t1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `u` [INFO] [stderr] --> src/texture.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | fn value(&self, u: f32, v: f32, p: &Vec3) -> Vec3 { [INFO] [stderr] | ^ help: consider using `_u` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v` [INFO] [stderr] --> src/texture.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | fn value(&self, u: f32, v: f32, p: &Vec3) -> Vec3 { [INFO] [stderr] | ^ help: consider using `_v` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/texture.rs:27:37 [INFO] [stderr] | [INFO] [stderr] 27 | fn value(&self, u: f32, v: f32, p: &Vec3) -> Vec3 { [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Sphere` [INFO] [stderr] --> src/hitable/sphere.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub struct Sphere { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/hitable/sphere.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new(center: Vec3, radius: f32, material: Arc) -> Sphere { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/hitable/sphere.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn new( [INFO] [stderr] 83 | | center0: Vec3, [INFO] [stderr] 84 | | center1: Vec3, [INFO] [stderr] 85 | | time0: f32, [INFO] [stderr] ... | [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/material.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn new(albedo: Arc) -> Lambertian { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/material.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn new(albedo: Vec3, fuzz: f32) -> Metal { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/material.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn new(ref_idx: f32) -> Dielectric { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/ray.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn new(a: &Vec3, b: &Vec3) -> Ray { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/texture.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn new(t0: Arc, t1: Arc) -> CheckerTexture { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `NoiseTexture` [INFO] [stderr] --> src/texture.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | pub struct NoiseTexture { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/texture.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn new(scale: f32) -> NoiseTexture { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ImageTexture` [INFO] [stderr] --> src/texture.rs:76:1 [INFO] [stderr] | [INFO] [stderr] 76 | pub struct ImageTexture { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/texture.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn new>(filename: P) -> ImageTexture { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `simple_light` [INFO] [stderr] --> src/main.rs:147:1 [INFO] [stderr] | [INFO] [stderr] 147 | fn simple_light() -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `two_perlin_spheres` [INFO] [stderr] --> src/main.rs:182:1 [INFO] [stderr] | [INFO] [stderr] 182 | fn two_perlin_spheres() -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `random_scene` [INFO] [stderr] --> src/main.rs:200:1 [INFO] [stderr] | [INFO] [stderr] 200 | fn random_scene() -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/camera.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new( [INFO] [stderr] 22 | | lookfrom: Vec3, [INFO] [stderr] 23 | | lookat: Vec3, [INFO] [stderr] 24 | | vup: Vec3, [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Sphere` [INFO] [stderr] --> src/hitable/sphere.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub struct Sphere { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/hitable/sphere.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new(center: Vec3, radius: f32, material: Arc) -> Sphere { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/hitable/sphere.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn new( [INFO] [stderr] 83 | | center0: Vec3, [INFO] [stderr] 84 | | center1: Vec3, [INFO] [stderr] 85 | | time0: f32, [INFO] [stderr] ... | [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/material.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn new(albedo: Arc) -> Lambertian { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/material.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn new(albedo: Vec3, fuzz: f32) -> Metal { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/material.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn new(ref_idx: f32) -> Dielectric { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/ray.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn new(a: &Vec3, b: &Vec3) -> Ray { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/texture.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn new(t0: Arc, t1: Arc) -> CheckerTexture { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `NoiseTexture` [INFO] [stderr] --> src/texture.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | pub struct NoiseTexture { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/texture.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn new(scale: f32) -> NoiseTexture { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ImageTexture` [INFO] [stderr] --> src/texture.rs:76:1 [INFO] [stderr] | [INFO] [stderr] 76 | pub struct ImageTexture { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/texture.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn new>(filename: P) -> ImageTexture { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `simple_light` [INFO] [stderr] --> src/main.rs:147:1 [INFO] [stderr] | [INFO] [stderr] 147 | fn simple_light() -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `two_perlin_spheres` [INFO] [stderr] --> src/main.rs:182:1 [INFO] [stderr] | [INFO] [stderr] 182 | fn two_perlin_spheres() -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `random_scene` [INFO] [stderr] --> src/main.rs:200:1 [INFO] [stderr] | [INFO] [stderr] 200 | fn random_scene() -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/camera.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new( [INFO] [stderr] 22 | | lookfrom: Vec3, [INFO] [stderr] 23 | | lookat: Vec3, [INFO] [stderr] 24 | | vup: Vec3, [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/hitable/sphere.rs:41:46 [INFO] [stderr] | [INFO] [stderr] 41 | let (u, v) = get_sphere_uv(&((&rec.p - &self.center) / self.radius)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 41 | let (u, v) = get_sphere_uv(&((rec.p - self.center) / self.radius)); [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/hitable/sphere.rs:52:46 [INFO] [stderr] | [INFO] [stderr] 52 | let (u, v) = get_sphere_uv(&((&rec.p - &self.center) / self.radius)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 52 | let (u, v) = get_sphere_uv(&((rec.p - self.center) / self.radius)); [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/hitable/sphere.rs:41:46 [INFO] [stderr] | [INFO] [stderr] 41 | let (u, v) = get_sphere_uv(&((&rec.p - &self.center) / self.radius)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 41 | let (u, v) = get_sphere_uv(&((rec.p - self.center) / self.radius)); [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/hitable/sphere.rs:52:46 [INFO] [stderr] | [INFO] [stderr] 52 | let (u, v) = get_sphere_uv(&((&rec.p - &self.center) / self.radius)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 52 | let (u, v) = get_sphere_uv(&((rec.p - self.center) / self.radius)); [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/perlin.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | let mut temp_p = p.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `c` [INFO] [stderr] --> src/perlin.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for (i, ) in c.iter().enumerate().take(2) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/perlin.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | let mut temp_p = p.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*p` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `p`. [INFO] [stderr] --> src/perlin.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for in &mut p { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `p` [INFO] [stderr] --> src/perlin.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 89 | for (i, ) in p.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `c` [INFO] [stderr] --> src/perlin.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for (i, ) in c.iter().enumerate().take(2) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `p`. [INFO] [stderr] --> src/perlin.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for in &mut p { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `p` [INFO] [stderr] --> src/perlin.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 89 | for (i, ) in p.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | let r = self.data[3 * i + 3 * self.nx as usize * j] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.data[3 * i + 3 * self.nx as usize * j])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | let g = self.data[3 * i + 3 * self.nx as usize * j + 1] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.data[3 * i + 3 * self.nx as usize * j + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | let b = self.data[3 * i + 3 * self.nx as usize * j + 2] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.data[3 * i + 3 * self.nx as usize * j + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | let r = self.data[3 * i + 3 * self.nx as usize * j] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.data[3 * i + 3 * self.nx as usize * j])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | let g = self.data[3 * i + 3 * self.nx as usize * j + 1] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.data[3 * i + 3 * self.nx as usize * j + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/texture.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | let b = self.data[3 * i + 3 * self.nx as usize * j + 2] as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.data[3 * i + 3 * self.nx as usize * j + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.77s [INFO] running `"docker" "inspect" "8e02a4d3f36dfbc654226afa8d93e36a13e1e02cf3bcdbfa34539f920c3fc962"` [INFO] running `"docker" "rm" "-f" "8e02a4d3f36dfbc654226afa8d93e36a13e1e02cf3bcdbfa34539f920c3fc962"` [INFO] [stdout] 8e02a4d3f36dfbc654226afa8d93e36a13e1e02cf3bcdbfa34539f920c3fc962