[INFO] updating cached repository abtv/sloc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/abtv/sloc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/abtv/sloc" "work/ex/clippy-test-run/sources/stable/gh/abtv/sloc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/abtv/sloc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/abtv/sloc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abtv/sloc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abtv/sloc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ff22dbc88fe3bb9a947671f648e80c2d654c0603 [INFO] sha for GitHub repo abtv/sloc: ff22dbc88fe3bb9a947671f648e80c2d654c0603 [INFO] validating manifest of abtv/sloc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of abtv/sloc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing abtv/sloc [INFO] finished frobbing abtv/sloc [INFO] frobbed toml for abtv/sloc written to work/ex/clippy-test-run/sources/stable/gh/abtv/sloc/Cargo.toml [INFO] started frobbing abtv/sloc [INFO] finished frobbing abtv/sloc [INFO] frobbed toml for abtv/sloc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abtv/sloc/Cargo.toml [INFO] crate abtv/sloc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting abtv/sloc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/abtv/sloc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cd72bc8d71b5012a5a01b993b17dbaed00431cf50fca2b75326aca7ff7fddc1d [INFO] running `"docker" "start" "-a" "cd72bc8d71b5012a5a01b993b17dbaed00431cf50fca2b75326aca7ff7fddc1d"` [INFO] [stderr] Checking sloc v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/counting.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/counting.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | total_loc: total_loc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/counting.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | empty_loc: empty_loc [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `empty_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/counting.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/counting.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | total_loc: total_loc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/counting.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | empty_loc: empty_loc [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `empty_loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/counting.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | .filter(|x| match *x { [INFO] [stderr] | _____________________^ [INFO] [stderr] 74 | | Some(_) => true, [INFO] [stderr] 75 | | None => false [INFO] [stderr] 76 | | }) [INFO] [stderr] | |_________^ help: try this: `*x.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/counting.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn get_stats(counters: &Vec) -> Stats { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Counter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/counting.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | .filter(|x| match *x { [INFO] [stderr] | _____________________^ [INFO] [stderr] 74 | | Some(_) => true, [INFO] [stderr] 75 | | None => false [INFO] [stderr] 76 | | }) [INFO] [stderr] | |_________^ help: try this: `*x.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | fn show_counters(counters: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Counter]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/counting.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn get_stats(counters: &Vec) -> Stats { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Counter]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | fn show_counters(counters: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Counter]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `"docker" "inspect" "cd72bc8d71b5012a5a01b993b17dbaed00431cf50fca2b75326aca7ff7fddc1d"` [INFO] running `"docker" "rm" "-f" "cd72bc8d71b5012a5a01b993b17dbaed00431cf50fca2b75326aca7ff7fddc1d"` [INFO] [stdout] cd72bc8d71b5012a5a01b993b17dbaed00431cf50fca2b75326aca7ff7fddc1d