[INFO] updating cached repository abro9/rust_tracer
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/abro9/rust_tracer
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/abro9/rust_tracer" "work/ex/clippy-test-run/sources/stable/gh/abro9/rust_tracer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/abro9/rust_tracer'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/abro9/rust_tracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abro9/rust_tracer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abro9/rust_tracer'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6fc484cd2dfeced18177bb69c18569b1214e31a4
[INFO] sha for GitHub repo abro9/rust_tracer: 6fc484cd2dfeced18177bb69c18569b1214e31a4
[INFO] validating manifest of abro9/rust_tracer on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of abro9/rust_tracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing abro9/rust_tracer
[INFO] finished frobbing abro9/rust_tracer
[INFO] frobbed toml for abro9/rust_tracer written to work/ex/clippy-test-run/sources/stable/gh/abro9/rust_tracer/Cargo.toml
[INFO] started frobbing abro9/rust_tracer
[INFO] finished frobbing abro9/rust_tracer
[INFO] frobbed toml for abro9/rust_tracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abro9/rust_tracer/Cargo.toml
[INFO] crate abro9/rust_tracer has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting abro9/rust_tracer against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/abro9/rust_tracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 215d090d943789b5bfcd92834920c3cee3a5910be05c5d8c4b3cd32ca0ad701e
[INFO] running `"docker" "start" "-a" "215d090d943789b5bfcd92834920c3cee3a5910be05c5d8c4b3cd32ca0ad701e"`
[INFO] [stderr]     Checking rand v0.3.16
[INFO] [stderr]     Checking png v0.11.0
[INFO] [stderr]     Checking pbr v1.0.0
[INFO] [stderr]     Checking rayon-core v1.2.1
[INFO] [stderr]     Checking rayon v0.8.2
[INFO] [stderr]     Checking jpeg-decoder v0.1.13
[INFO] [stderr]     Checking image v0.17.0
[INFO] [stderr]     Checking rust_tracer v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/sphere.rs:39:21
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 let p = r.pt_at_t(tmp);
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/sphere.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 let p = r.pt_at_t(tmp);
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/plane.rs:16:17
[INFO] [stderr]    |
[INFO] [stderr] 16 |                 d: d,
[INFO] [stderr]    |                 ^^^^ help: replace it with: `d`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/plane.rs:21:17
[INFO] [stderr]    |
[INFO] [stderr] 21 |                 d: d,
[INFO] [stderr]    |                 ^^^^ help: replace it with: `d`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/plane.rs:38:21
[INFO] [stderr]    |
[INFO] [stderr] 38 |                     p : p,
[INFO] [stderr]    |                     ^^^^^ help: replace it with: `p`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:47:19
[INFO] [stderr]    |
[INFO] [stderr] 47 |                   dir : dir,
[INFO] [stderr]    |                   ^^^^^^^^^ help: replace it with: `dir`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:49:19
[INFO] [stderr]    |
[INFO] [stderr] 49 |                   iw : iw,
[INFO] [stderr]    |                   ^^^^^^^ help: replace it with: `iw`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:50:19
[INFO] [stderr]    |
[INFO] [stderr] 50 |                   ih : ih,
[INFO] [stderr]    |                   ^^^^^^^ help: replace it with: `ih`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:51:19
[INFO] [stderr]    |
[INFO] [stderr] 51 |                   pw : pw,
[INFO] [stderr]    |                   ^^^^^^^ help: replace it with: `pw`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:52:19
[INFO] [stderr]    |
[INFO] [stderr] 52 |                   ph : ph,
[INFO] [stderr]    |                   ^^^^^^^ help: replace it with: `ph`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/camera.rs:65:13
[INFO] [stderr]    |
[INFO] [stderr] 65 |         let t = 0.5 * self.ih;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/camera.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |         let b = -0.5 * self.ih;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/camera.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 |         let u = l + (r - l) * (i + t_rng.next_f64()) / self.pw as f64;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/camera.rs:69:13
[INFO] [stderr]    |
[INFO] [stderr] 69 |         let v = b + (t - b) * (j + t_rng.next_f64()) / self.ph as f64;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/sphere.rs:39:21
[INFO] [stderr]    |
[INFO] [stderr] 39 |                 let p = r.pt_at_t(tmp);
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/sphere.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 let p = r.pt_at_t(tmp);
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/plane.rs:16:17
[INFO] [stderr]    |
[INFO] [stderr] 16 |                 d: d,
[INFO] [stderr]    |                 ^^^^ help: replace it with: `d`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/plane.rs:21:17
[INFO] [stderr]    |
[INFO] [stderr] 21 |                 d: d,
[INFO] [stderr]    |                 ^^^^ help: replace it with: `d`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/plane.rs:38:21
[INFO] [stderr]    |
[INFO] [stderr] 38 |                     p : p,
[INFO] [stderr]    |                     ^^^^^ help: replace it with: `p`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:47:19
[INFO] [stderr]    |
[INFO] [stderr] 47 |                   dir : dir,
[INFO] [stderr]    |                   ^^^^^^^^^ help: replace it with: `dir`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:49:19
[INFO] [stderr]    |
[INFO] [stderr] 49 |                   iw : iw,
[INFO] [stderr]    |                   ^^^^^^^ help: replace it with: `iw`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:50:19
[INFO] [stderr]    |
[INFO] [stderr] 50 |                   ih : ih,
[INFO] [stderr]    |                   ^^^^^^^ help: replace it with: `ih`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:51:19
[INFO] [stderr]    |
[INFO] [stderr] 51 |                   pw : pw,
[INFO] [stderr]    |                   ^^^^^^^ help: replace it with: `pw`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:52:19
[INFO] [stderr]    |
[INFO] [stderr] 52 |                   ph : ph,
[INFO] [stderr]    |                   ^^^^^^^ help: replace it with: `ph`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/camera.rs:65:13
[INFO] [stderr]    |
[INFO] [stderr] 65 |         let t = 0.5 * self.ih;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/camera.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |         let b = -0.5 * self.ih;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/camera.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 |         let u = l + (r - l) * (i + t_rng.next_f64()) / self.pw as f64;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]   --> src/camera.rs:69:13
[INFO] [stderr]    |
[INFO] [stderr] 69 |         let v = b + (t - b) * (j + t_rng.next_f64()) / self.ph as f64;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/color.rs:10:52
[INFO] [stderr]    |
[INFO] [stderr] 10 | pub fn new_color(r: &Ray, world: &HitList, lights: &Vec<Light>, depth: u32) -> Vec3 {
[INFO] [stderr]    |                                                    ^^^^^^^^^^^ help: change this to: `&[Light]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/color.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     let t;
[INFO] [stderr] 13 | |     if depth == 0 {
[INFO] [stderr] 14 | |         t = world.hit(r, 0.0, f64::MAX);
[INFO] [stderr] 15 | |     }
[INFO] [stderr] 16 | |     else {
[INFO] [stderr] 17 | |         t = world.hit(r, 0.01, f64::MAX);
[INFO] [stderr] 18 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let t = if depth == 0 { world.hit(r, 0.0, f64::MAX) } else { world.hit(r, 0.01, f64::MAX) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hitlist::HitList`
[INFO] [stderr]   --> src/hitlist.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     pub fn new() -> HitList {
[INFO] [stderr] 12 | |         let v: Vec<Box<Hitable>> = Vec::new();
[INFO] [stderr] 13 | |         HitList { members: v }
[INFO] [stderr] 14 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (11/7)
[INFO] [stderr]   --> src/material.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     pub fn new(t: char,
[INFO] [stderr] 30 | |                d0: f64, d1: f64, d2: f64,
[INFO] [stderr] 31 | |                s0: f64, s1: f64, s2: f64,
[INFO] [stderr] 32 | |                i0: f64, i1: f64, i2: f64,
[INFO] [stderr] ...  |
[INFO] [stderr] 45 | |                        mat_type : MatType::Metal } }
[INFO] [stderr] 46 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/camera.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 | /         let mut _v = Vec3::new(0.0, 0.0, 0.0);
[INFO] [stderr] 35 | |
[INFO] [stderr] 36 | |         if 1.0 - f64::abs(_w[1]) < 0.0001 {
[INFO] [stderr] 37 | |             _u = Vec3::new(1.0, 0.0, 0.0);
[INFO] [stderr] ...  |
[INFO] [stderr] 43 | |             _v = _u.cross(&dir);
[INFO] [stderr] 44 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> _v = if 1.0 - f64::abs(_w[1]) < 0.0001 { ..; _u.cross(&dir) } else { ..; _u.cross(&dir) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/camera.rs:75:57
[INFO] [stderr]    |
[INFO] [stderr] 75 |     pub fn render_scene(&self, world: &HitList, lights: &Vec<Light>, rpp: usize, image_file: &String, out_type: &String){
[INFO] [stderr]    |                                                         ^^^^^^^^^^^ help: change this to: `&[Light]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/camera.rs:75:94
[INFO] [stderr]    |
[INFO] [stderr] 75 |     pub fn render_scene(&self, world: &HitList, lights: &Vec<Light>, rpp: usize, image_file: &String, out_type: &String){
[INFO] [stderr]    |                                                                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/camera.rs:75:113
[INFO] [stderr]    |
[INFO] [stderr] 75 |     pub fn render_scene(&self, world: &HitList, lights: &Vec<Light>, rpp: usize, image_file: &String, out_type: &String){
[INFO] [stderr]    |                                                                                                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/camera.rs:116:41
[INFO] [stderr]     |
[INFO] [stderr] 116 |     pub fn save_file(&self, image_file: &String, data: &Vec<u8>){
[INFO] [stderr]     |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/camera.rs:116:56
[INFO] [stderr]     |
[INFO] [stderr] 116 |     pub fn save_file(&self, image_file: &String, data: &Vec<u8>){
[INFO] [stderr]     |                                                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/camera.rs:134:41
[INFO] [stderr]     |
[INFO] [stderr] 134 |     pub fn img_write(&self, image_file: &String, file_type: &String, data: &Vec<u8>){
[INFO] [stderr]     |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/camera.rs:134:61
[INFO] [stderr]     |
[INFO] [stderr] 134 |     pub fn img_write(&self, image_file: &String, file_type: &String, data: &Vec<u8>){
[INFO] [stderr]     |                                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/camera.rs:134:76
[INFO] [stderr]     |
[INFO] [stderr] 134 |     pub fn img_write(&self, image_file: &String, file_type: &String, data: &Vec<u8>){
[INFO] [stderr]     |                                                                            ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parser.rs:14:27
[INFO] [stderr]    |
[INFO] [stderr] 14 | pub fn parse(source_file: &String) -> (HitList, Vec<Light>, Camera){
[INFO] [stderr]    |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:32:32
[INFO] [stderr]    |
[INFO] [stderr] 32 |         let split = line.split(" ");
[INFO] [stderr]    |                                ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/color.rs:10:52
[INFO] [stderr]    |
[INFO] [stderr] 10 | pub fn new_color(r: &Ray, world: &HitList, lights: &Vec<Light>, depth: u32) -> Vec3 {
[INFO] [stderr]    |                                                    ^^^^^^^^^^^ help: change this to: `&[Light]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/color.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     let t;
[INFO] [stderr] 13 | |     if depth == 0 {
[INFO] [stderr] 14 | |         t = world.hit(r, 0.0, f64::MAX);
[INFO] [stderr] 15 | |     }
[INFO] [stderr] 16 | |     else {
[INFO] [stderr] 17 | |         t = world.hit(r, 0.01, f64::MAX);
[INFO] [stderr] 18 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let t = if depth == 0 { world.hit(r, 0.0, f64::MAX) } else { world.hit(r, 0.01, f64::MAX) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hitlist::HitList`
[INFO] [stderr]   --> src/hitlist.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     pub fn new() -> HitList {
[INFO] [stderr] 12 | |         let v: Vec<Box<Hitable>> = Vec::new();
[INFO] [stderr] 13 | |         HitList { members: v }
[INFO] [stderr] 14 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (11/7)
[INFO] [stderr]   --> src/material.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     pub fn new(t: char,
[INFO] [stderr] 30 | |                d0: f64, d1: f64, d2: f64,
[INFO] [stderr] 31 | |                s0: f64, s1: f64, s2: f64,
[INFO] [stderr] 32 | |                i0: f64, i1: f64, i2: f64,
[INFO] [stderr] ...  |
[INFO] [stderr] 45 | |                        mat_type : MatType::Metal } }
[INFO] [stderr] 46 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/camera.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 | /         let mut _v = Vec3::new(0.0, 0.0, 0.0);
[INFO] [stderr] 35 | |
[INFO] [stderr] 36 | |         if 1.0 - f64::abs(_w[1]) < 0.0001 {
[INFO] [stderr] 37 | |             _u = Vec3::new(1.0, 0.0, 0.0);
[INFO] [stderr] ...  |
[INFO] [stderr] 43 | |             _v = _u.cross(&dir);
[INFO] [stderr] 44 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> _v = if 1.0 - f64::abs(_w[1]) < 0.0001 { ..; _u.cross(&dir) } else { ..; _u.cross(&dir) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/camera.rs:75:57
[INFO] [stderr]    |
[INFO] [stderr] 75 |     pub fn render_scene(&self, world: &HitList, lights: &Vec<Light>, rpp: usize, image_file: &String, out_type: &String){
[INFO] [stderr]    |                                                         ^^^^^^^^^^^ help: change this to: `&[Light]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/camera.rs:75:94
[INFO] [stderr]    |
[INFO] [stderr] 75 |     pub fn render_scene(&self, world: &HitList, lights: &Vec<Light>, rpp: usize, image_file: &String, out_type: &String){
[INFO] [stderr]    |                                                                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/camera.rs:75:113
[INFO] [stderr]    |
[INFO] [stderr] 75 |     pub fn render_scene(&self, world: &HitList, lights: &Vec<Light>, rpp: usize, image_file: &String, out_type: &String){
[INFO] [stderr]    |                                                                                                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/camera.rs:116:41
[INFO] [stderr]     |
[INFO] [stderr] 116 |     pub fn save_file(&self, image_file: &String, data: &Vec<u8>){
[INFO] [stderr]     |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/camera.rs:116:56
[INFO] [stderr]     |
[INFO] [stderr] 116 |     pub fn save_file(&self, image_file: &String, data: &Vec<u8>){
[INFO] [stderr]     |                                                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/camera.rs:134:41
[INFO] [stderr]     |
[INFO] [stderr] 134 |     pub fn img_write(&self, image_file: &String, file_type: &String, data: &Vec<u8>){
[INFO] [stderr]     |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/camera.rs:134:61
[INFO] [stderr]     |
[INFO] [stderr] 134 |     pub fn img_write(&self, image_file: &String, file_type: &String, data: &Vec<u8>){
[INFO] [stderr]     |                                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/camera.rs:134:76
[INFO] [stderr]     |
[INFO] [stderr] 134 |     pub fn img_write(&self, image_file: &String, file_type: &String, data: &Vec<u8>){
[INFO] [stderr]     |                                                                            ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parser.rs:14:27
[INFO] [stderr]    |
[INFO] [stderr] 14 | pub fn parse(source_file: &String) -> (HitList, Vec<Light>, Camera){
[INFO] [stderr]    |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:32:32
[INFO] [stderr]    |
[INFO] [stderr] 32 |         let split = line.split(" ");
[INFO] [stderr]    |                                ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 16.51s
[INFO] running `"docker" "inspect" "215d090d943789b5bfcd92834920c3cee3a5910be05c5d8c4b3cd32ca0ad701e"`
[INFO] running `"docker" "rm" "-f" "215d090d943789b5bfcd92834920c3cee3a5910be05c5d8c4b3cd32ca0ad701e"`
[INFO] [stdout] 215d090d943789b5bfcd92834920c3cee3a5910be05c5d8c4b3cd32ca0ad701e