[INFO] updating cached repository abpostelnicu/RustApp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/abpostelnicu/RustApp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/abpostelnicu/RustApp" "work/ex/clippy-test-run/sources/stable/gh/abpostelnicu/RustApp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/abpostelnicu/RustApp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/abpostelnicu/RustApp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abpostelnicu/RustApp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abpostelnicu/RustApp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 27e09b8eda04bea8b1378102665f6a44e2626ae9 [INFO] sha for GitHub repo abpostelnicu/RustApp: 27e09b8eda04bea8b1378102665f6a44e2626ae9 [INFO] validating manifest of abpostelnicu/RustApp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of abpostelnicu/RustApp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing abpostelnicu/RustApp [INFO] finished frobbing abpostelnicu/RustApp [INFO] frobbed toml for abpostelnicu/RustApp written to work/ex/clippy-test-run/sources/stable/gh/abpostelnicu/RustApp/Cargo.toml [INFO] started frobbing abpostelnicu/RustApp [INFO] finished frobbing abpostelnicu/RustApp [INFO] frobbed toml for abpostelnicu/RustApp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abpostelnicu/RustApp/Cargo.toml [INFO] crate abpostelnicu/RustApp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting abpostelnicu/RustApp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/abpostelnicu/RustApp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f694b158c2689b6b65f1c5f18967f1f7acde081edf62fb54ec4928d3cc7ae07c [INFO] running `"docker" "start" "-a" "f694b158c2689b6b65f1c5f18967f1f7acde081edf62fb54ec4928d3cc7ae07c"` [INFO] [stderr] Checking test_rust_app v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:25:59 [INFO] [stderr] | [INFO] [stderr] 25 | let vec: Vec = data.split(" ").map(|s| s.to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | / match vec.get(0) { [INFO] [stderr] 27 | | Some(action) => { [INFO] [stderr] 28 | | println!("Command received: {}", action); [INFO] [stderr] 29 | | [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(action) = vec.get(0) { [INFO] [stderr] 27 | println!("Command received: {}", action); [INFO] [stderr] 28 | [INFO] [stderr] 29 | if action == "Get" { [INFO] [stderr] 30 | println!("Get Something"); [INFO] [stderr] 31 | match self.messages.get(0) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:50:37 [INFO] [stderr] | [INFO] [stderr] 50 | / match str2put { [INFO] [stderr] 51 | | Some(str2put) => { [INFO] [stderr] 52 | | let put2vec = str2put.to_string(); [INFO] [stderr] 53 | | println!("Put {}", put2vec); [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | if let Some(str2put) = str2put { [INFO] [stderr] 51 | let put2vec = str2put.to_string(); [INFO] [stderr] 52 | println!("Put {}", put2vec); [INFO] [stderr] 53 | self.messages.push_back(put2vec); [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:25:59 [INFO] [stderr] | [INFO] [stderr] 25 | let vec: Vec = data.split(" ").map(|s| s.to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | / match vec.get(0) { [INFO] [stderr] 27 | | Some(action) => { [INFO] [stderr] 28 | | println!("Command received: {}", action); [INFO] [stderr] 29 | | [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(action) = vec.get(0) { [INFO] [stderr] 27 | println!("Command received: {}", action); [INFO] [stderr] 28 | [INFO] [stderr] 29 | if action == "Get" { [INFO] [stderr] 30 | println!("Get Something"); [INFO] [stderr] 31 | match self.messages.get(0) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:50:37 [INFO] [stderr] | [INFO] [stderr] 50 | / match str2put { [INFO] [stderr] 51 | | Some(str2put) => { [INFO] [stderr] 52 | | let put2vec = str2put.to_string(); [INFO] [stderr] 53 | | println!("Put {}", put2vec); [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | if let Some(str2put) = str2put { [INFO] [stderr] 51 | let put2vec = str2put.to_string(); [INFO] [stderr] 52 | println!("Put {}", put2vec); [INFO] [stderr] 53 | self.messages.push_back(put2vec); [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `"docker" "inspect" "f694b158c2689b6b65f1c5f18967f1f7acde081edf62fb54ec4928d3cc7ae07c"` [INFO] running `"docker" "rm" "-f" "f694b158c2689b6b65f1c5f18967f1f7acde081edf62fb54ec4928d3cc7ae07c"` [INFO] [stdout] f694b158c2689b6b65f1c5f18967f1f7acde081edf62fb54ec4928d3cc7ae07c