[INFO] updating cached repository abombard/expert-system
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/abombard/expert-system
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/abombard/expert-system" "work/ex/clippy-test-run/sources/stable/gh/abombard/expert-system"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/abombard/expert-system'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/abombard/expert-system" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abombard/expert-system"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abombard/expert-system'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1039fdad5d78d6fd8c5e6044cee1efc174ea8675
[INFO] sha for GitHub repo abombard/expert-system: 1039fdad5d78d6fd8c5e6044cee1efc174ea8675
[INFO] validating manifest of abombard/expert-system on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of abombard/expert-system on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing abombard/expert-system
[INFO] finished frobbing abombard/expert-system
[INFO] frobbed toml for abombard/expert-system written to work/ex/clippy-test-run/sources/stable/gh/abombard/expert-system/Cargo.toml
[INFO] started frobbing abombard/expert-system
[INFO] finished frobbing abombard/expert-system
[INFO] frobbed toml for abombard/expert-system written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abombard/expert-system/Cargo.toml
[INFO] crate abombard/expert-system has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting abombard/expert-system against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/abombard/expert-system:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9dc7860a60bc981bf9d8e12669b95c98a8074a167ac7bef9e501078236b71e78
[INFO] running `"docker" "start" "-a" "9dc7860a60bc981bf9d8e12669b95c98a8074a167ac7bef9e501078236b71e78"`
[INFO] [stderr]     Checking aho-corasick v0.6.1
[INFO] [stderr]     Checking regex v0.2.1
[INFO] [stderr]     Checking expert_system v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/variables.rs:51:18
[INFO] [stderr]    |
[INFO] [stderr] 51 | pub const VARS: &'static str = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
[INFO] [stderr]    |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/syntax.rs:72:2
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return true;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/syntax.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:110:2
[INFO] [stderr]     |
[INFO] [stderr] 110 |     return true;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/variables.rs:51:18
[INFO] [stderr]    |
[INFO] [stderr] 51 | pub const VARS: &'static str = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
[INFO] [stderr]    |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/syntax.rs:72:2
[INFO] [stderr]    |
[INFO] [stderr] 72 |     return true;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/syntax.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:110:2
[INFO] [stderr]     |
[INFO] [stderr] 110 |     return true;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/variables.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for ref rule in &self.rules {
[INFO] [stderr]    |             ^^^^^^^^    ----------- help: try: `let rule = &&self.rules;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/variables.rs:56:30
[INFO] [stderr]    |
[INFO] [stderr] 56 |         let var_name = &VARS[i..i+1];
[INFO] [stderr]    |                              ^^^^^^ help: use: `i..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/variables.rs:70:29
[INFO] [stderr]    |
[INFO] [stderr] 70 |             let var = &VARS[i..i+1];
[INFO] [stderr]    |                             ^^^^^^ help: use: `i..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/btree.rs:61:41
[INFO] [stderr]    |
[INFO] [stderr] 61 |     pub fn to_string(&self, prev_token: &String, prev_neg: bool) -> String {
[INFO] [stderr]    |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/btree.rs:317:20
[INFO] [stderr]     |
[INFO] [stderr] 317 |                 if self.root_list.len() == 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.root_list.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/syntax.rs:17:38
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 if expect != Expect::Operator || allow_parenthesis == false || p != 0 {
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!allow_parenthesis`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/syntax.rs:30:36
[INFO] [stderr]    |
[INFO] [stderr] 30 |                 if expect != Expect::Letter || allow_parenthesis == false {
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!allow_parenthesis`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/syntax.rs:36:38
[INFO] [stderr]    |
[INFO] [stderr] 36 |                 if expect != Expect::Operator || allow_parenthesis == false || p == 0 {
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!allow_parenthesis`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/syntax.rs:50:8
[INFO] [stderr]    |
[INFO] [stderr] 50 |                 if allow_parenthesis == false && c != '+' {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!allow_parenthesis`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/syntax.rs:68:35
[INFO] [stderr]    |
[INFO] [stderr] 68 |     if expect != Expect::Operator || allow_parenthesis == true {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `allow_parenthesis`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:40:41
[INFO] [stderr]    |
[INFO] [stderr] 40 |             let name = &variables::VARS[i..i+1];
[INFO] [stderr]    |                                         ^^^^^^ help: use: `i..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:50:53
[INFO] [stderr]    |
[INFO] [stderr] 50 |                         let name = &variables::VARS[i..i+1];
[INFO] [stderr]    |                                                     ^^^^^^ help: use: `i..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:51:29
[INFO] [stderr]    |
[INFO] [stderr] 51 |                         let ref mut var = variables.get_mut(name).unwrap();
[INFO] [stderr]    |                         ----^^^^^^^^^^^------------------------------------ help: try: `let var = &mut variables.get_mut(name).unwrap();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:73:30
[INFO] [stderr]    |
[INFO] [stderr] 73 |             let name = &vars[i..i+1];
[INFO] [stderr]    |                              ^^^^^^ help: use: `i..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:92:20
[INFO] [stderr]    |
[INFO] [stderr] 92 |         let name = &vars[i..i+1];
[INFO] [stderr]    |                          ^^^^^^ help: use: `i..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/main.rs:129:42
[INFO] [stderr]     |
[INFO] [stderr] 129 |                     let var_name = &vars[i..i+1];
[INFO] [stderr]     |                                          ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/main.rs:158:45
[INFO] [stderr]     |
[INFO] [stderr] 158 |                     let var_name = &letters[i..i+1];
[INFO] [stderr]     |                                             ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: you should use the `starts_with` method
[INFO] [stderr]    --> src/main.rs:211:16
[INFO] [stderr]     |
[INFO] [stderr] 211 |             if s.chars().next().unwrap() == '#' {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `s.starts_with('#')`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::chars_next_cmp)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:218:16
[INFO] [stderr]     |
[INFO] [stderr] 218 |             if rule.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rule.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:234:12
[INFO] [stderr]     |
[INFO] [stderr] 234 |         if rule.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rule.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/variables.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |         for ref rule in &self.rules {
[INFO] [stderr]    |             ^^^^^^^^    ----------- help: try: `let rule = &&self.rules;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/variables.rs:56:30
[INFO] [stderr]    |
[INFO] [stderr] 56 |         let var_name = &VARS[i..i+1];
[INFO] [stderr]    |                              ^^^^^^ help: use: `i..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/variables.rs:70:29
[INFO] [stderr]    |
[INFO] [stderr] 70 |             let var = &VARS[i..i+1];
[INFO] [stderr]    |                             ^^^^^^ help: use: `i..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/btree.rs:61:41
[INFO] [stderr]    |
[INFO] [stderr] 61 |     pub fn to_string(&self, prev_token: &String, prev_neg: bool) -> String {
[INFO] [stderr]    |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/btree.rs:317:20
[INFO] [stderr]     |
[INFO] [stderr] 317 |                 if self.root_list.len() == 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.root_list.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/syntax.rs:17:38
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 if expect != Expect::Operator || allow_parenthesis == false || p != 0 {
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!allow_parenthesis`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/syntax.rs:30:36
[INFO] [stderr]    |
[INFO] [stderr] 30 |                 if expect != Expect::Letter || allow_parenthesis == false {
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!allow_parenthesis`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/syntax.rs:36:38
[INFO] [stderr]    |
[INFO] [stderr] 36 |                 if expect != Expect::Operator || allow_parenthesis == false || p == 0 {
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!allow_parenthesis`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/syntax.rs:50:8
[INFO] [stderr]    |
[INFO] [stderr] 50 |                 if allow_parenthesis == false && c != '+' {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!allow_parenthesis`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/syntax.rs:68:35
[INFO] [stderr]    |
[INFO] [stderr] 68 |     if expect != Expect::Operator || allow_parenthesis == true {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `allow_parenthesis`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:40:41
[INFO] [stderr]    |
[INFO] [stderr] 40 |             let name = &variables::VARS[i..i+1];
[INFO] [stderr]    |                                         ^^^^^^ help: use: `i..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:50:53
[INFO] [stderr]    |
[INFO] [stderr] 50 |                         let name = &variables::VARS[i..i+1];
[INFO] [stderr]    |                                                     ^^^^^^ help: use: `i..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:51:29
[INFO] [stderr]    |
[INFO] [stderr] 51 |                         let ref mut var = variables.get_mut(name).unwrap();
[INFO] [stderr]    |                         ----^^^^^^^^^^^------------------------------------ help: try: `let var = &mut variables.get_mut(name).unwrap();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:73:30
[INFO] [stderr]    |
[INFO] [stderr] 73 |             let name = &vars[i..i+1];
[INFO] [stderr]    |                              ^^^^^^ help: use: `i..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:92:20
[INFO] [stderr]    |
[INFO] [stderr] 92 |         let name = &vars[i..i+1];
[INFO] [stderr]    |                          ^^^^^^ help: use: `i..=i`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/main.rs:129:42
[INFO] [stderr]     |
[INFO] [stderr] 129 |                     let var_name = &vars[i..i+1];
[INFO] [stderr]     |                                          ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/main.rs:158:45
[INFO] [stderr]     |
[INFO] [stderr] 158 |                     let var_name = &letters[i..i+1];
[INFO] [stderr]     |                                             ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: you should use the `starts_with` method
[INFO] [stderr]    --> src/main.rs:211:16
[INFO] [stderr]     |
[INFO] [stderr] 211 |             if s.chars().next().unwrap() == '#' {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `s.starts_with('#')`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::chars_next_cmp)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:218:16
[INFO] [stderr]     |
[INFO] [stderr] 218 |             if rule.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rule.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:234:12
[INFO] [stderr]     |
[INFO] [stderr] 234 |         if rule.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rule.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.40s
[INFO] running `"docker" "inspect" "9dc7860a60bc981bf9d8e12669b95c98a8074a167ac7bef9e501078236b71e78"`
[INFO] running `"docker" "rm" "-f" "9dc7860a60bc981bf9d8e12669b95c98a8074a167ac7bef9e501078236b71e78"`
[INFO] [stdout] 9dc7860a60bc981bf9d8e12669b95c98a8074a167ac7bef9e501078236b71e78