[INFO] updating cached repository abomb4/rust-five [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/abomb4/rust-five [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/abomb4/rust-five" "work/ex/clippy-test-run/sources/stable/gh/abomb4/rust-five"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/abomb4/rust-five'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/abomb4/rust-five" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abomb4/rust-five"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abomb4/rust-five'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7ea4f23c0bd54807f2c4d80799dec64e397e3388 [INFO] sha for GitHub repo abomb4/rust-five: 7ea4f23c0bd54807f2c4d80799dec64e397e3388 [INFO] validating manifest of abomb4/rust-five on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of abomb4/rust-five on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing abomb4/rust-five [INFO] finished frobbing abomb4/rust-five [INFO] frobbed toml for abomb4/rust-five written to work/ex/clippy-test-run/sources/stable/gh/abomb4/rust-five/Cargo.toml [INFO] started frobbing abomb4/rust-five [INFO] finished frobbing abomb4/rust-five [INFO] frobbed toml for abomb4/rust-five written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abomb4/rust-five/Cargo.toml [INFO] crate abomb4/rust-five has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting abomb4/rust-five against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/abomb4/rust-five:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53058b09219b822930fa93a1b7f48a665f1687122e634b6b4671243da13dfa53 [INFO] running `"docker" "start" "-a" "53058b09219b822930fa93a1b7f48a665f1687122e634b6b4671243da13dfa53"` [INFO] [stderr] Checking rust-five v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/board.rs:14:54 [INFO] [stderr] | [INFO] [stderr] 14 | BoardPieceType::EMPTY => write!(f, "{}", "Empty"), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/board.rs:15:54 [INFO] [stderr] | [INFO] [stderr] 15 | BoardPieceType::BLACK => write!(f, "{}", "Black"), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/board.rs:16:54 [INFO] [stderr] | [INFO] [stderr] 16 | BoardPieceType::WHITE => write!(f, "{}", "White"), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/board.rs:14:54 [INFO] [stderr] | [INFO] [stderr] 14 | BoardPieceType::EMPTY => write!(f, "{}", "Empty"), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/board.rs:15:54 [INFO] [stderr] | [INFO] [stderr] 15 | BoardPieceType::BLACK => write!(f, "{}", "Black"), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/game/board.rs:16:54 [INFO] [stderr] | [INFO] [stderr] 16 | BoardPieceType::WHITE => write!(f, "{}", "White"), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] error: #[test] attribute is only allowed on non associated functions [INFO] [stderr] --> src/game/board.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | / fn test() { [INFO] [stderr] 120 | | let mut b = Board::new(); [INFO] [stderr] 121 | | let coord = CoordinationFlat::new(3, 3); [INFO] [stderr] 122 | | let p = BoardPieceType::WHITE; [INFO] [stderr] ... | [INFO] [stderr] 125 | | assert!(b.get(coord).unwrap() == p) [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-five`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `game::GameBuilderPlayerType::Human` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use game::GameBuilderPlayerType::Human; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/board.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return Board { board, size: SIZE }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Board { board, size: SIZE }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/board.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/players.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | return num; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `context` [INFO] [stderr] --> src/game/players.rs:79:25 [INFO] [stderr] | [INFO] [stderr] 79 | fn point(&mut self, context: &GameContext) -> CoordinationFlat { [INFO] [stderr] | ^^^^^^^ help: consider using `_context` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `context` [INFO] [stderr] --> src/game/players.rs:120:29 [INFO] [stderr] | [INFO] [stderr] 120 | fn point(&mut self, context: &GameContext) -> CoordinationFlat { [INFO] [stderr] | ^^^^^^^ help: consider using `_context` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `board` [INFO] [stderr] --> src/game/players.rs:151:39 [INFO] [stderr] | [INFO] [stderr] 151 | fn find_points_need_calculate(board: &Board) -> Vec { [INFO] [stderr] | ^^^^^ help: consider using `_board` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `board` [INFO] [stderr] --> src/game/players.rs:156:28 [INFO] [stderr] | [INFO] [stderr] 156 | fn calculate_score(board: &Board, coord: CoordinationFlat) -> usize { [INFO] [stderr] | ^^^^^ help: consider using `_board` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `coord` [INFO] [stderr] --> src/game/players.rs:156:43 [INFO] [stderr] | [INFO] [stderr] 156 | fn calculate_score(board: &Board, coord: CoordinationFlat) -> usize { [INFO] [stderr] | ^^^^^ help: consider using `_coord` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `last` [INFO] [stderr] --> src/game/players.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | let last = &context.last_point; [INFO] [stderr] | ^^^^ help: consider using `_last` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `total` [INFO] [stderr] --> src/game/players.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | let total = &context.total_pieces; [INFO] [stderr] | ^^^^^ help: consider using `_total` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `need_calculate` [INFO] [stderr] --> src/game/players.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | let need_calculate = EasyAi::find_points_need_calculate(&board); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_need_calculate` instead [INFO] [stderr] [INFO] [stderr] warning: function cannot return without recursing [INFO] [stderr] --> src/game/players.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | fn piece_type(&self) -> PieceType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stderr] 184 | self.piece_type() [INFO] [stderr] | ----------------- recursive call site [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unconditional_recursion)] on by default [INFO] [stderr] = help: a `loop` may express intention better if this is on purpose [INFO] [stderr] [INFO] [stderr] warning: field is never used: `piece` [INFO] [stderr] --> src/game/players.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | piece: PieceType [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/game/players.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn new(piece: PieceType) -> EasyAi { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `calculate_score` [INFO] [stderr] --> src/game/players.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | fn calculate_score(board: &Board, coord: CoordinationFlat) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_another_player_mut` [INFO] [stderr] --> src/game/mod.rs:323:5 [INFO] [stderr] | [INFO] [stderr] 323 | fn get_another_player_mut(&mut self) -> &mut Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/game/board.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | let base_a = 'A' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/game/board.rs:131:29 [INFO] [stderr] | [INFO] [stderr] 131 | if x > self.size || x <= 0 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using x == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/game/board.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | if y > self.size || y <= 0 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using y == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/game/players.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new(piece: PieceType) -> impl Player { [INFO] [stderr] 28 | | LocalHumanPlayer { piece } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/mod.rs:56:32 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn to_board_piece_type(&self) -> board::BoardPieceType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `game::GameBuilder` [INFO] [stderr] --> src/game/mod.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn new() -> GameBuilder { [INFO] [stderr] 86 | | GameBuilder { [INFO] [stderr] 87 | | first_player: GameBuilderPlayerType::Human, [INFO] [stderr] 88 | | second_player: GameBuilderPlayerType::Human [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | impl Default for game::GameBuilder { [INFO] [stderr] 83 | fn default() -> Self { [INFO] [stderr] 84 | Self::new() [INFO] [stderr] 85 | } [INFO] [stderr] 86 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game/mod.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | / match optional_winner { [INFO] [stderr] 257 | | Some(_) => { [INFO] [stderr] 258 | | // Current player cannot point anything because another player is wined [INFO] [stderr] 259 | | let winner = self.get_another_player(); [INFO] [stderr] ... | [INFO] [stderr] 263 | | None => { } [INFO] [stderr] 264 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 256 | if let Some(_) = optional_winner { [INFO] [stderr] 257 | // Current player cannot point anything because another player is wined [INFO] [stderr] 258 | let winner = self.get_another_player(); [INFO] [stderr] 259 | println!("Winner is {} ({}).", winner.name(), winner.piece_type()); [INFO] [stderr] 260 | break; [INFO] [stderr] 261 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/game/mod.rs:304:47 [INFO] [stderr] | [INFO] [stderr] 304 | fn change_to_another_player(&mut self) -> &Box { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `&Player` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/game/mod.rs:314:37 [INFO] [stderr] | [INFO] [stderr] 314 | fn get_another_player(&self) -> &Box { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `&Player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/game/mod.rs:323:45 [INFO] [stderr] | [INFO] [stderr] 323 | fn get_another_player_mut(&mut self) -> &mut Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&mut Player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/game/mod.rs:332:37 [INFO] [stderr] | [INFO] [stderr] 332 | fn get_current_player(&self) -> &Box { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `&Player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/game/mod.rs:337:45 [INFO] [stderr] | [INFO] [stderr] 337 | fn get_current_player_mut(&mut self) -> &mut Box { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&mut Player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-five`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "53058b09219b822930fa93a1b7f48a665f1687122e634b6b4671243da13dfa53"` [INFO] running `"docker" "rm" "-f" "53058b09219b822930fa93a1b7f48a665f1687122e634b6b4671243da13dfa53"` [INFO] [stdout] 53058b09219b822930fa93a1b7f48a665f1687122e634b6b4671243da13dfa53