[INFO] updating cached repository ablwr/hello264-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ablwr/hello264-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ablwr/hello264-rust" "work/ex/clippy-test-run/sources/stable/gh/ablwr/hello264-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ablwr/hello264-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ablwr/hello264-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ablwr/hello264-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ablwr/hello264-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b28f49d48cf00c03fe0f38e7274b6d09580b57c9 [INFO] sha for GitHub repo ablwr/hello264-rust: b28f49d48cf00c03fe0f38e7274b6d09580b57c9 [INFO] validating manifest of ablwr/hello264-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ablwr/hello264-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ablwr/hello264-rust [INFO] finished frobbing ablwr/hello264-rust [INFO] frobbed toml for ablwr/hello264-rust written to work/ex/clippy-test-run/sources/stable/gh/ablwr/hello264-rust/Cargo.toml [INFO] started frobbing ablwr/hello264-rust [INFO] finished frobbing ablwr/hello264-rust [INFO] frobbed toml for ablwr/hello264-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ablwr/hello264-rust/Cargo.toml [INFO] crate ablwr/hello264-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ablwr/hello264-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ablwr/hello264-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3f3a692150cd60ebda93e8e450c0060080497356e60ac150c89799df82ecad51 [INFO] running `"docker" "start" "-a" "3f3a692150cd60ebda93e8e450c0060080497356e60ac150c89799df82ecad51"` [INFO] [stderr] Checking hello264-rust v0.4.20 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:59:49 [INFO] [stderr] | [INFO] [stderr] 59 | let metadata = fs::metadata(input_filename).expect(&format!("couldn't get metadata for {}", &input_filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't get metadata for {}", &input_filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `y`. [INFO] [stderr] --> src/main.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | for i in 0..96 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 76 | for in &mut y { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `cb`. [INFO] [stderr] --> src/main.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | for i in 0..(CHROMA_HEIGHT) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 86 | for in cb.iter_mut().take((CHROMA_HEIGHT)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `cr`. [INFO] [stderr] --> src/main.rs:95:18 [INFO] [stderr] | [INFO] [stderr] 95 | for i in 0..(CHROMA_HEIGHT) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 95 | for in cr.iter_mut().take((CHROMA_HEIGHT)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:59:49 [INFO] [stderr] | [INFO] [stderr] 59 | let metadata = fs::metadata(input_filename).expect(&format!("couldn't get metadata for {}", &input_filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("couldn't get metadata for {}", &input_filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `y`. [INFO] [stderr] --> src/main.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | for i in 0..96 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 76 | for in &mut y { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `cb`. [INFO] [stderr] --> src/main.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | for i in 0..(CHROMA_HEIGHT) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 86 | for in cb.iter_mut().take((CHROMA_HEIGHT)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `cr`. [INFO] [stderr] --> src/main.rs:95:18 [INFO] [stderr] | [INFO] [stderr] 95 | for i in 0..(CHROMA_HEIGHT) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 95 | for in cr.iter_mut().take((CHROMA_HEIGHT)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "3f3a692150cd60ebda93e8e450c0060080497356e60ac150c89799df82ecad51"` [INFO] running `"docker" "rm" "-f" "3f3a692150cd60ebda93e8e450c0060080497356e60ac150c89799df82ecad51"` [INFO] [stdout] 3f3a692150cd60ebda93e8e450c0060080497356e60ac150c89799df82ecad51