[INFO] updating cached repository abhijeetbhagat/mio-socket [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/abhijeetbhagat/mio-socket [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/abhijeetbhagat/mio-socket" "work/ex/clippy-test-run/sources/stable/gh/abhijeetbhagat/mio-socket"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/abhijeetbhagat/mio-socket'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/abhijeetbhagat/mio-socket" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abhijeetbhagat/mio-socket"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abhijeetbhagat/mio-socket'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0fa4cb582310a34593afabb6bc171ae0648b9fa9 [INFO] sha for GitHub repo abhijeetbhagat/mio-socket: 0fa4cb582310a34593afabb6bc171ae0648b9fa9 [INFO] validating manifest of abhijeetbhagat/mio-socket on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of abhijeetbhagat/mio-socket on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing abhijeetbhagat/mio-socket [INFO] finished frobbing abhijeetbhagat/mio-socket [INFO] frobbed toml for abhijeetbhagat/mio-socket written to work/ex/clippy-test-run/sources/stable/gh/abhijeetbhagat/mio-socket/Cargo.toml [INFO] started frobbing abhijeetbhagat/mio-socket [INFO] finished frobbing abhijeetbhagat/mio-socket [INFO] frobbed toml for abhijeetbhagat/mio-socket written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abhijeetbhagat/mio-socket/Cargo.toml [INFO] crate abhijeetbhagat/mio-socket has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting abhijeetbhagat/mio-socket against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/abhijeetbhagat/mio-socket:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 96794b15caa0257dce4b4d2d7c50c704b9c08591c6b58575f7f61ecb0af13fae [INFO] running `"docker" "start" "-a" "96794b15caa0257dce4b4d2d7c50c704b9c08591c6b58575f7f61ecb0af13fae"` [INFO] [stderr] Checking mio-udp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / if event_set.is_readable(){ [INFO] [stderr] 34 | | if self.token == token{ [INFO] [stderr] 35 | | let mut buf = [0u8; 512]; [INFO] [stderr] 36 | | let (amt, src) = self.socket.recv_from(&mut buf).unwrap().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 33 | if event_set.is_readable() && self.token == token { [INFO] [stderr] 34 | let mut buf = [0u8; 512]; [INFO] [stderr] 35 | let (amt, src) = self.socket.recv_from(&mut buf).unwrap().unwrap(); [INFO] [stderr] 36 | //src.send_to(); [INFO] [stderr] 37 | println!("{}", from_utf8(&buf).unwrap_or("blank read")); [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `amt` [INFO] [stderr] --> src/main.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | let (amt, src) = self.socket.recv_from(&mut buf).unwrap().unwrap(); [INFO] [stderr] | ^^^ help: consider using `_amt` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `src` [INFO] [stderr] --> src/main.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | let (amt, src) = self.socket.recv_from(&mut buf).unwrap().unwrap(); [INFO] [stderr] | ^^^ help: consider using `_src` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_loop` [INFO] [stderr] --> src/main.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | fn ready(&mut self, event_loop : &mut EventLoop, token : Token, event_set : Ready){ [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_event_loop` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `socket` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | socket : UdpSocket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `token` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | token : Token, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `interest` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | interest : Ready [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `client` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | client : Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `UdpEndClient` [INFO] [stderr] --> src/main.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | struct UdpEndClient{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | event_loop.register(&server.socket, server.token, Ready::readable(), PollOpt::edge()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | event_loop.run(&mut server); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | socket.send_to("abhi".as_bytes(), &SocketAddr::new(IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), 8080)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | socket.send_to("abhi".as_bytes(), &SocketAddr::new(IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), 8080)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abhi"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / if event_set.is_readable(){ [INFO] [stderr] 34 | | if self.token == token{ [INFO] [stderr] 35 | | let mut buf = [0u8; 512]; [INFO] [stderr] 36 | | let (amt, src) = self.socket.recv_from(&mut buf).unwrap().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 33 | if event_set.is_readable() && self.token == token { [INFO] [stderr] 34 | let mut buf = [0u8; 512]; [INFO] [stderr] 35 | let (amt, src) = self.socket.recv_from(&mut buf).unwrap().unwrap(); [INFO] [stderr] 36 | //src.send_to(); [INFO] [stderr] 37 | println!("{}", from_utf8(&buf).unwrap_or("blank read")); [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `amt` [INFO] [stderr] --> src/main.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | let (amt, src) = self.socket.recv_from(&mut buf).unwrap().unwrap(); [INFO] [stderr] | ^^^ help: consider using `_amt` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `src` [INFO] [stderr] --> src/main.rs:36:27 [INFO] [stderr] | [INFO] [stderr] 36 | let (amt, src) = self.socket.recv_from(&mut buf).unwrap().unwrap(); [INFO] [stderr] | ^^^ help: consider using `_src` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event_loop` [INFO] [stderr] --> src/main.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | fn ready(&mut self, event_loop : &mut EventLoop, token : Token, event_set : Ready){ [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_event_loop` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `socket` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | socket : UdpSocket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `token` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | token : Token, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `interest` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | interest : Ready [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `client` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | client : Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `UdpEndClient` [INFO] [stderr] --> src/main.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | struct UdpEndClient{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | event_loop.register(&server.socket, server.token, Ready::readable(), PollOpt::edge()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | event_loop.run(&mut server); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | socket.send_to("abhi".as_bytes(), &SocketAddr::new(IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), 8080)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | socket.send_to("abhi".as_bytes(), &SocketAddr::new(IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), 8080)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abhi"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.42s [INFO] running `"docker" "inspect" "96794b15caa0257dce4b4d2d7c50c704b9c08591c6b58575f7f61ecb0af13fae"` [INFO] running `"docker" "rm" "-f" "96794b15caa0257dce4b4d2d7c50c704b9c08591c6b58575f7f61ecb0af13fae"` [INFO] [stdout] 96794b15caa0257dce4b4d2d7c50c704b9c08591c6b58575f7f61ecb0af13fae