[INFO] updating cached repository abhijat/ya2d2 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/abhijat/ya2d2 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/abhijat/ya2d2" "work/ex/clippy-test-run/sources/stable/gh/abhijat/ya2d2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/abhijat/ya2d2'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/abhijat/ya2d2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abhijat/ya2d2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abhijat/ya2d2'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 541f6c51a1c5ef8ba2053cad8c2519ecf847b9be [INFO] sha for GitHub repo abhijat/ya2d2: 541f6c51a1c5ef8ba2053cad8c2519ecf847b9be [INFO] validating manifest of abhijat/ya2d2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of abhijat/ya2d2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing abhijat/ya2d2 [INFO] finished frobbing abhijat/ya2d2 [INFO] frobbed toml for abhijat/ya2d2 written to work/ex/clippy-test-run/sources/stable/gh/abhijat/ya2d2/Cargo.toml [INFO] started frobbing abhijat/ya2d2 [INFO] finished frobbing abhijat/ya2d2 [INFO] frobbed toml for abhijat/ya2d2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/abhijat/ya2d2/Cargo.toml [INFO] crate abhijat/ya2d2 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting abhijat/ya2d2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/abhijat/ya2d2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e190e78cf82f4d31bc01af7590b254be9acf6b3f668de3b6590ec97dcc19accb [INFO] running `"docker" "start" "-a" "e190e78cf82f4d31bc01af7590b254be9acf6b3f668de3b6590ec97dcc19accb"` [INFO] [stderr] Checking crossbeam-utils v0.6.1 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking smallvec v0.6.7 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking memchr v2.1.1 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking nix v0.7.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking smallstr v0.1.0 [INFO] [stderr] Compiling terminfo v0.6.1 [INFO] [stderr] Checking sled_sync v0.1.5 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking pagetable v0.1.1 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking pagecache v0.7.7 [INFO] [stderr] Checking sled v0.16.6 [INFO] [stderr] Checking mortal v0.1.5 [INFO] [stderr] Checking linefeed v0.5.3 [INFO] [stderr] Checking ya2d2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cmd/completer.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 38 | | if start > 4 { [INFO] [stderr] 39 | | None [INFO] [stderr] 40 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | } else if start > 4 { [INFO] [stderr] 38 | None [INFO] [stderr] 39 | } else { [INFO] [stderr] 40 | let partial_id = &line[start..]; [INFO] [stderr] 41 | [INFO] [stderr] 42 | Some(ids.into_iter() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/shell/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod shell; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/shell/shell.rs:41:59 [INFO] [stderr] | [INFO] [stderr] 41 | CommandObject::PushCommand { payload, tags: _ } => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `PushCommand { payload, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/shell/shell.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | CommandObject::ListCommand { tags: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ListCommand { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cmd/completer.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 38 | | if start > 4 { [INFO] [stderr] 39 | | None [INFO] [stderr] 40 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | } else if start > 4 { [INFO] [stderr] 38 | None [INFO] [stderr] 39 | } else { [INFO] [stderr] 40 | let partial_id = &line[start..]; [INFO] [stderr] 41 | [INFO] [stderr] 42 | Some(ids.into_iter() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/shell/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod shell; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/shell/shell.rs:41:59 [INFO] [stderr] | [INFO] [stderr] 41 | CommandObject::PushCommand { payload, tags: _ } => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `PushCommand { payload, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/shell/shell.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | CommandObject::ListCommand { tags: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ListCommand { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/cmd/completer.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | .map(|s| Completion::simple(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Completion::simple` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/cmd/completer.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | .map(|s| Completion::simple(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Completion::simple` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/cmd/parser.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / named!( [INFO] [stderr] 35 | | push_command_parser, [INFO] [stderr] 36 | | do_parse!( [INFO] [stderr] 37 | | push_parser >> [INFO] [stderr] ... | [INFO] [stderr] 43 | | ) [INFO] [stderr] 44 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/cmd/parser.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / named!( [INFO] [stderr] 35 | | push_command_parser, [INFO] [stderr] 36 | | do_parse!( [INFO] [stderr] 37 | | push_parser >> [INFO] [stderr] ... | [INFO] [stderr] 43 | | ) [INFO] [stderr] 44 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/cmd/parser.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | / named!( [INFO] [stderr] 47 | | pop_command_parser, [INFO] [stderr] 48 | | do_parse!( [INFO] [stderr] 49 | | pop_parser >> [INFO] [stderr] ... | [INFO] [stderr] 54 | | ) [INFO] [stderr] 55 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/cmd/parser.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | / named!( [INFO] [stderr] 47 | | pop_command_parser, [INFO] [stderr] 48 | | do_parse!( [INFO] [stderr] 49 | | pop_parser >> [INFO] [stderr] ... | [INFO] [stderr] 54 | | ) [INFO] [stderr] 55 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cmd/parser.rs:131:24 [INFO] [stderr] | [INFO] [stderr] 131 | assert_eq!(tags.get(0).unwrap(), "foobar"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&tags[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cmd/parser.rs:142:24 [INFO] [stderr] | [INFO] [stderr] 142 | assert_eq!(tags.get(0).unwrap(), "foobar"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&tags[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cmd/parser.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | assert_eq!(tags.get(1).unwrap(), "birds"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&tags[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cmd/parser.rs:217:24 [INFO] [stderr] | [INFO] [stderr] 217 | assert_eq!(tags.get(0).unwrap(), "foobar"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&tags[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cmd/parser.rs:218:24 [INFO] [stderr] | [INFO] [stderr] 218 | assert_eq!(tags.get(1).unwrap(), "xxxx"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&tags[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/initialize.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .ok_or("failed to access home".to_string())? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "failed to access home".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/initialize.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | .ok_or("failed to access home".to_string())? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "failed to access home".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/initialize.rs:49:10 [INFO] [stderr] | [INFO] [stderr] 49 | .ok_or("failed to access home dir".to_string())? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "failed to access home dir".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/shell/shell.rs:133:40 [INFO] [stderr] | [INFO] [stderr] 133 | serde_json::from_slice(&value).expect(&format!( [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 134 | | "failed to deserialize payload {}", [INFO] [stderr] 135 | | String::from_utf8_lossy(&value) [INFO] [stderr] 136 | | )) [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("failed to deserialize payload {}", String::from_utf8_lossy(&value)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/initialize.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .ok_or("failed to access home".to_string())? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "failed to access home".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/initialize.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | .ok_or("failed to access home".to_string())? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "failed to access home".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/initialize.rs:49:10 [INFO] [stderr] | [INFO] [stderr] 49 | .ok_or("failed to access home dir".to_string())? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "failed to access home dir".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 29.89s [INFO] running `"docker" "inspect" "e190e78cf82f4d31bc01af7590b254be9acf6b3f668de3b6590ec97dcc19accb"` [INFO] running `"docker" "rm" "-f" "e190e78cf82f4d31bc01af7590b254be9acf6b3f668de3b6590ec97dcc19accb"` [INFO] [stdout] e190e78cf82f4d31bc01af7590b254be9acf6b3f668de3b6590ec97dcc19accb