[INFO] updating cached repository aarroyoc/fractal_tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aarroyoc/fractal_tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aarroyoc/fractal_tree" "work/ex/clippy-test-run/sources/stable/gh/aarroyoc/fractal_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aarroyoc/fractal_tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aarroyoc/fractal_tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aarroyoc/fractal_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aarroyoc/fractal_tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f264ac80c33e8a185a27e82f19aa8fbcbf07636e [INFO] sha for GitHub repo aarroyoc/fractal_tree: f264ac80c33e8a185a27e82f19aa8fbcbf07636e [INFO] validating manifest of aarroyoc/fractal_tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aarroyoc/fractal_tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aarroyoc/fractal_tree [INFO] finished frobbing aarroyoc/fractal_tree [INFO] frobbed toml for aarroyoc/fractal_tree written to work/ex/clippy-test-run/sources/stable/gh/aarroyoc/fractal_tree/Cargo.toml [INFO] started frobbing aarroyoc/fractal_tree [INFO] finished frobbing aarroyoc/fractal_tree [INFO] frobbed toml for aarroyoc/fractal_tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aarroyoc/fractal_tree/Cargo.toml [INFO] crate aarroyoc/fractal_tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aarroyoc/fractal_tree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aarroyoc/fractal_tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 650030502a6a6761e15e118f9109ab8bc876cd8229634f93ab94f9d5e8341347 [INFO] running `"docker" "start" "-a" "650030502a6a6761e15e118f9109ab8bc876cd8229634f93ab94f9d5e8341347"` [INFO] [stderr] Compiling heapsize v0.4.1 [INFO] [stderr] Compiling either v1.3.0 [INFO] [stderr] Checking nodrop v0.1.10 [INFO] [stderr] Checking sid v0.5.0 [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking x11-dl v2.15.0 [INFO] [stderr] Checking svgparser v0.4.3 [INFO] [stderr] Compiling palette v0.2.1 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking arrayvec v0.3.23 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking euclid v0.15.3 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking lyon_bezier v0.8.0 [INFO] [stderr] Checking lyon_core v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking lyon_path_iterator v0.8.0 [INFO] [stderr] Checking lyon_path_builder v0.8.0 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking lyon_path v0.8.0 [INFO] [stderr] Checking lyon_svg v0.8.0 [INFO] [stderr] Checking glutin v0.10.0 [INFO] [stderr] Checking lyon_tessellation v0.8.3 [INFO] [stderr] Checking lyon_extra v0.8.1 [INFO] [stderr] Checking lyon v0.8.3 [INFO] [stderr] Checking gfx_device_gl v0.14.4 [INFO] [stderr] Checking gfx v0.16.1 [INFO] [stderr] Checking gfx_window_glutin v0.18.0 [INFO] [stderr] Checking fractal_tree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | let a = Rgb::from_hsl(color.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | let mut a = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | let mut a = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: The function/method `draw_branch` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:139:49 [INFO] [stderr] | [INFO] [stderr] 139 | draw_branch(&mut mesh,0.0,-1.0,0.3,0.0,30.0,&mut color); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | / match event { [INFO] [stderr] 178 | | winit::Event::WindowEvent{event,..} => match event { [INFO] [stderr] 179 | | winit::WindowEvent::Closed => running = false, [INFO] [stderr] 180 | | _ => () [INFO] [stderr] 181 | | }, [INFO] [stderr] 182 | | _ => () [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 177 | if let winit::Event::WindowEvent{event,..} = event { match event { [INFO] [stderr] 178 | winit::WindowEvent::Closed => running = false, [INFO] [stderr] 179 | _ => () [INFO] [stderr] 180 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:178:56 [INFO] [stderr] | [INFO] [stderr] 178 | winit::Event::WindowEvent{event,..} => match event { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 179 | | winit::WindowEvent::Closed => running = false, [INFO] [stderr] 180 | | _ => () [INFO] [stderr] 181 | | }, [INFO] [stderr] | |_________________^ help: try this: `if let winit::WindowEvent::Closed = event { running = false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | let a = Rgb::from_hsl(color.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | let mut a = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | let mut a = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: The function/method `draw_branch` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:139:49 [INFO] [stderr] | [INFO] [stderr] 139 | draw_branch(&mut mesh,0.0,-1.0,0.3,0.0,30.0,&mut color); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | / match event { [INFO] [stderr] 178 | | winit::Event::WindowEvent{event,..} => match event { [INFO] [stderr] 179 | | winit::WindowEvent::Closed => running = false, [INFO] [stderr] 180 | | _ => () [INFO] [stderr] 181 | | }, [INFO] [stderr] 182 | | _ => () [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 177 | if let winit::Event::WindowEvent{event,..} = event { match event { [INFO] [stderr] 178 | winit::WindowEvent::Closed => running = false, [INFO] [stderr] 179 | _ => () [INFO] [stderr] 180 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:178:56 [INFO] [stderr] | [INFO] [stderr] 178 | winit::Event::WindowEvent{event,..} => match event { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 179 | | winit::WindowEvent::Closed => running = false, [INFO] [stderr] 180 | | _ => () [INFO] [stderr] 181 | | }, [INFO] [stderr] | |_________________^ help: try this: `if let winit::WindowEvent::Closed = event { running = false }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 58.72s [INFO] running `"docker" "inspect" "650030502a6a6761e15e118f9109ab8bc876cd8229634f93ab94f9d5e8341347"` [INFO] running `"docker" "rm" "-f" "650030502a6a6761e15e118f9109ab8bc876cd8229634f93ab94f9d5e8341347"` [INFO] [stdout] 650030502a6a6761e15e118f9109ab8bc876cd8229634f93ab94f9d5e8341347