[INFO] updating cached repository aaronschif/prompt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aaronschif/prompt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aaronschif/prompt" "work/ex/clippy-test-run/sources/stable/gh/aaronschif/prompt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aaronschif/prompt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aaronschif/prompt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronschif/prompt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronschif/prompt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] de1be1c07bb965b7e83af200831b280748dbf5c4 [INFO] sha for GitHub repo aaronschif/prompt: de1be1c07bb965b7e83af200831b280748dbf5c4 [INFO] validating manifest of aaronschif/prompt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aaronschif/prompt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aaronschif/prompt [INFO] finished frobbing aaronschif/prompt [INFO] frobbed toml for aaronschif/prompt written to work/ex/clippy-test-run/sources/stable/gh/aaronschif/prompt/Cargo.toml [INFO] started frobbing aaronschif/prompt [INFO] finished frobbing aaronschif/prompt [INFO] frobbed toml for aaronschif/prompt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronschif/prompt/Cargo.toml [INFO] crate aaronschif/prompt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aaronschif/prompt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aaronschif/prompt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 327e7e5046ca8c2f43065668483737a8b722b1fb519e2b877c5ed56706aae450 [INFO] running `"docker" "start" "-a" "327e7e5046ca8c2f43065668483737a8b722b1fb519e2b877c5ed56706aae450"` [INFO] [stderr] Compiling cmake v0.1.29 [INFO] [stderr] Checking hostname v0.1.4 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.7.1 [INFO] [stderr] Checking git2 v0.7.0 [INFO] [stderr] Checking prompt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/providers.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return Some(parts.join(&self.seperator).to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(parts.join(&self.seperator).to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/main.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / arg_enum!{ [INFO] [stderr] 22 | | #[derive(PartialEq, Debug)] [INFO] [stderr] 23 | | pub enum SupportedShells { [INFO] [stderr] 24 | | Zsh, [INFO] [stderr] 25 | | Fish [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/providers.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return Some(parts.join(&self.seperator).to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(parts.join(&self.seperator).to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/main.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / arg_enum!{ [INFO] [stderr] 22 | | #[derive(PartialEq, Debug)] [INFO] [stderr] 23 | | pub enum SupportedShells { [INFO] [stderr] 24 | | Zsh, [INFO] [stderr] 25 | | Fish [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/git/mod.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | } else if status.tag.len() > 0 { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 98 | | result += status.branch.as_str(); [INFO] [stderr] 99 | | } else if status.hash.len() != 0 { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/git/mod.rs:95:32 [INFO] [stderr] | [INFO] [stderr] 95 | if status.branch.len() > 0 { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 96 | | result += status.branch.as_str(); [INFO] [stderr] 97 | | } else if status.tag.len() > 0 { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/git/mod.rs:95:8 [INFO] [stderr] | [INFO] [stderr] 95 | if status.branch.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!status.branch.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/git/mod.rs:97:15 [INFO] [stderr] | [INFO] [stderr] 97 | } else if status.tag.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!status.tag.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/git/mod.rs:99:15 [INFO] [stderr] | [INFO] [stderr] 99 | } else if status.hash.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!status.hash.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/providers.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | if parts.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | if let Ok(_) = env::var("SSH_CONNECTION") { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 31 | | if let Some(host) = get_hostname() { [INFO] [stderr] 32 | | return Some(host.into()); [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____- help: try this: `if env::var("SSH_CONNECTION").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | return Some(host.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:76:12 [INFO] [stderr] | [INFO] [stderr] 76 | if let Some(_) = virtualenv() { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 77 | | result.push_str(&format!("{}🐍\u{FE0E}{} ", fg, bg)); [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____- help: try this: `if virtualenv().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `prompt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/git/mod.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | } else if status.tag.len() > 0 { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 98 | | result += status.branch.as_str(); [INFO] [stderr] 99 | | } else if status.hash.len() != 0 { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/git/mod.rs:95:32 [INFO] [stderr] | [INFO] [stderr] 95 | if status.branch.len() > 0 { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 96 | | result += status.branch.as_str(); [INFO] [stderr] 97 | | } else if status.tag.len() > 0 { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/git/mod.rs:95:8 [INFO] [stderr] | [INFO] [stderr] 95 | if status.branch.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!status.branch.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/git/mod.rs:97:15 [INFO] [stderr] | [INFO] [stderr] 97 | } else if status.tag.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!status.tag.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/git/mod.rs:99:15 [INFO] [stderr] | [INFO] [stderr] 99 | } else if status.hash.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!status.hash.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/providers.rs:15:12 [INFO] [stderr] | [INFO] [stderr] 15 | if parts.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | if let Ok(_) = env::var("SSH_CONNECTION") { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 31 | | if let Some(host) = get_hostname() { [INFO] [stderr] 32 | | return Some(host.into()); [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____- help: try this: `if env::var("SSH_CONNECTION").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | return Some(host.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:76:12 [INFO] [stderr] | [INFO] [stderr] 76 | if let Some(_) = virtualenv() { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 77 | | result.push_str(&format!("{}🐍\u{FE0E}{} ", fg, bg)); [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____- help: try this: `if virtualenv().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `prompt`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "327e7e5046ca8c2f43065668483737a8b722b1fb519e2b877c5ed56706aae450"` [INFO] running `"docker" "rm" "-f" "327e7e5046ca8c2f43065668483737a8b722b1fb519e2b877c5ed56706aae450"` [INFO] [stdout] 327e7e5046ca8c2f43065668483737a8b722b1fb519e2b877c5ed56706aae450