[INFO] updating cached repository aaronriekenberg/rusty_web [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aaronriekenberg/rusty_web [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aaronriekenberg/rusty_web" "work/ex/clippy-test-run/sources/stable/gh/aaronriekenberg/rusty_web"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aaronriekenberg/rusty_web'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aaronriekenberg/rusty_web" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronriekenberg/rusty_web"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronriekenberg/rusty_web'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1f0f71add5804c9172873a561d367c716328c81e [INFO] sha for GitHub repo aaronriekenberg/rusty_web: 1f0f71add5804c9172873a561d367c716328c81e [INFO] validating manifest of aaronriekenberg/rusty_web on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aaronriekenberg/rusty_web on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aaronriekenberg/rusty_web [INFO] finished frobbing aaronriekenberg/rusty_web [INFO] frobbed toml for aaronriekenberg/rusty_web written to work/ex/clippy-test-run/sources/stable/gh/aaronriekenberg/rusty_web/Cargo.toml [INFO] started frobbing aaronriekenberg/rusty_web [INFO] finished frobbing aaronriekenberg/rusty_web [INFO] frobbed toml for aaronriekenberg/rusty_web written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronriekenberg/rusty_web/Cargo.toml [INFO] crate aaronriekenberg/rusty_web has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aaronriekenberg/rusty_web against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aaronriekenberg/rusty_web:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6ac97f9a8785cc108a61869f97f5262c54842d91182a85b5599991d6b2b70e39 [INFO] running `"docker" "start" "-a" "6ac97f9a8785cc108a61869f97f5262c54842d91182a85b5599991d6b2b70e39"` [INFO] [stderr] Checking horrorshow v0.6.2 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking net2 v0.2.30 [INFO] [stderr] Checking simple_logger v0.4.0 [INFO] [stderr] Checking serde_yaml v0.7.1 [INFO] [stderr] Checking url v1.5.1 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking futures-cpupool v0.1.5 [INFO] [stderr] Checking mio v0.6.9 [INFO] [stderr] Checking hyper v0.10.12 [INFO] [stderr] Checking tokio-core v0.1.8 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking hyper v0.11.1 [INFO] [stderr] Checking mount v0.3.0 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking logger v0.3.0 [INFO] [stderr] Checking staticfile v0.4.0 [INFO] [stderr] Checking rusty_web v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | CommandHandler { command_info: command_info, command_line_string: command_line_string } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_info` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:163:50 [INFO] [stderr] | [INFO] [stderr] 163 | CommandHandler { command_info: command_info, command_line_string: command_line_string } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_line_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | CommandHandler { command_info: command_info, command_line_string: command_line_string } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_info` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:163:50 [INFO] [stderr] | [INFO] [stderr] 163 | CommandHandler { command_info: command_info, command_line_string: command_line_string } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_line_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | command_output [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:173:7 [INFO] [stderr] | [INFO] [stderr] 173 | / match command.output() { [INFO] [stderr] 174 | | Ok(output) => { [INFO] [stderr] 175 | | let mut combined_output = [INFO] [stderr] 176 | | String::with_capacity(output.stderr.len() + output.stdout.len()); [INFO] [stderr] ... | [INFO] [stderr] 181 | | Err(err) => format!("command error: {}", err), [INFO] [stderr] 182 | | }; [INFO] [stderr] | |_______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | html_string [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:203:23 [INFO] [stderr] | [INFO] [stderr] 203 | let html_string = html! { [INFO] [stderr] | _______________________^ [INFO] [stderr] 204 | | : doctype::HTML; [INFO] [stderr] 205 | | html { [INFO] [stderr] 206 | | head { [INFO] [stderr] ... | [INFO] [stderr] 220 | | }.into_string() [INFO] [stderr] 221 | | .unwrap_or_else(|err| format!("error executing template: {}", err)); [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | command_output [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:173:7 [INFO] [stderr] | [INFO] [stderr] 173 | / match command.output() { [INFO] [stderr] 174 | | Ok(output) => { [INFO] [stderr] 175 | | let mut combined_output = [INFO] [stderr] 176 | | String::with_capacity(output.stderr.len() + output.stdout.len()); [INFO] [stderr] ... | [INFO] [stderr] 181 | | Err(err) => format!("command error: {}", err), [INFO] [stderr] 182 | | }; [INFO] [stderr] | |_______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | html_string [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:203:23 [INFO] [stderr] | [INFO] [stderr] 203 | let html_string = html! { [INFO] [stderr] | _______________________^ [INFO] [stderr] 204 | | : doctype::HTML; [INFO] [stderr] 205 | | html { [INFO] [stderr] 206 | | head { [INFO] [stderr] ... | [INFO] [stderr] 220 | | }.into_string() [INFO] [stderr] 221 | | .unwrap_or_else(|err| format!("error executing template: {}", err)); [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | @ if config.commands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!config.commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:111:16 [INFO] [stderr] | [INFO] [stderr] 111 | @ if static_paths_to_include.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!static_paths_to_include.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | @ if config.commands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!config.commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:111:16 [INFO] [stderr] | [INFO] [stderr] 111 | @ if static_paths_to_include.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!static_paths_to_include.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.35s [INFO] running `"docker" "inspect" "6ac97f9a8785cc108a61869f97f5262c54842d91182a85b5599991d6b2b70e39"` [INFO] running `"docker" "rm" "-f" "6ac97f9a8785cc108a61869f97f5262c54842d91182a85b5599991d6b2b70e39"` [INFO] [stdout] 6ac97f9a8785cc108a61869f97f5262c54842d91182a85b5599991d6b2b70e39