[INFO] updating cached repository aaronriekenberg/rust_hyper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aaronriekenberg/rust_hyper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aaronriekenberg/rust_hyper" "work/ex/clippy-test-run/sources/stable/gh/aaronriekenberg/rust_hyper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aaronriekenberg/rust_hyper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aaronriekenberg/rust_hyper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronriekenberg/rust_hyper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronriekenberg/rust_hyper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b71d7610beaf316b91521bc41f38aaab8b83fab7 [INFO] sha for GitHub repo aaronriekenberg/rust_hyper: b71d7610beaf316b91521bc41f38aaab8b83fab7 [INFO] validating manifest of aaronriekenberg/rust_hyper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aaronriekenberg/rust_hyper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aaronriekenberg/rust_hyper [INFO] finished frobbing aaronriekenberg/rust_hyper [INFO] frobbed toml for aaronriekenberg/rust_hyper written to work/ex/clippy-test-run/sources/stable/gh/aaronriekenberg/rust_hyper/Cargo.toml [INFO] started frobbing aaronriekenberg/rust_hyper [INFO] finished frobbing aaronriekenberg/rust_hyper [INFO] frobbed toml for aaronriekenberg/rust_hyper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronriekenberg/rust_hyper/Cargo.toml [INFO] crate aaronriekenberg/rust_hyper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aaronriekenberg/rust_hyper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aaronriekenberg/rust_hyper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5bfe6fda87e20c20a76f137905b27bfea44edf6ed2973141e88e63b852778413 [INFO] running `"docker" "start" "-a" "5bfe6fda87e20c20a76f137905b27bfea44edf6ed2973141e88e63b852778413"` [INFO] [stderr] Checking horrorshow v0.6.4 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking fern v0.5.7 [INFO] [stderr] Checking signal-hook v0.1.6 [INFO] [stderr] Compiling syn v0.15.23 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking crossbeam-deque v0.6.2 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio-process v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.82 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.18 [INFO] [stderr] Checking rust_hyper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/handlers/index.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | @ if config.commands().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!config.commands().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/handlers/index.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | @ if config.proxies().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!config.proxies().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/handlers/index.rs:74:20 [INFO] [stderr] | [INFO] [stderr] 74 | @ if static_paths_to_include.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!static_paths_to_include.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/logging.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | / stdout [INFO] [stderr] 13 | | .write(first_msg.as_bytes()) [INFO] [stderr] 14 | | .expect("run_logging_output_thread error writing first_msg to stdout"); [INFO] [stderr] | |__________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/logging.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | / stdout.write(next_msg.as_bytes()).expect( [INFO] [stderr] 19 | | "run_logging_output_thread error writing next_msg to stdout", [INFO] [stderr] 20 | | ); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/logging.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | / stdout [INFO] [stderr] 25 | | .write( [INFO] [stderr] 26 | | "run_logging_output_thread try_recv disconnected error" [INFO] [stderr] 27 | | .as_bytes(), [INFO] [stderr] 28 | | ) [INFO] [stderr] 29 | | .expect("run_logging_output_thread error writing to stdout"); [INFO] [stderr] | |____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/logging.rs:26:37 [INFO] [stderr] | [INFO] [stderr] 26 | / "run_logging_output_thread try_recv disconnected error" [INFO] [stderr] 27 | | .as_bytes(), [INFO] [stderr] | |___________________________________________________^ help: consider using a byte string literal instead: `b"run_logging_output_thread try_recv disconnected error"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/logging.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | / stdout [INFO] [stderr] 36 | | .write(format!("run_logging_output_thread recv error {}\n", e).as_bytes()) [INFO] [stderr] 37 | | .expect("run_logging_output_thread error writing to stdout"); [INFO] [stderr] | |________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:231:14 [INFO] [stderr] | [INFO] [stderr] 231 | .unwrap_or(route_configuration.not_found_handler()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| route_configuration.not_found_handler())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | (duration.as_secs() as f64) + ((duration.subsec_nanos() as f64) / 1e9) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_hyper`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/handlers/index.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | @ if config.commands().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!config.commands().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/handlers/index.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | @ if config.proxies().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!config.proxies().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/handlers/index.rs:74:20 [INFO] [stderr] | [INFO] [stderr] 74 | @ if static_paths_to_include.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!static_paths_to_include.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/logging.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | / stdout [INFO] [stderr] 13 | | .write(first_msg.as_bytes()) [INFO] [stderr] 14 | | .expect("run_logging_output_thread error writing first_msg to stdout"); [INFO] [stderr] | |__________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/logging.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | / stdout.write(next_msg.as_bytes()).expect( [INFO] [stderr] 19 | | "run_logging_output_thread error writing next_msg to stdout", [INFO] [stderr] 20 | | ); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/logging.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | / stdout [INFO] [stderr] 25 | | .write( [INFO] [stderr] 26 | | "run_logging_output_thread try_recv disconnected error" [INFO] [stderr] 27 | | .as_bytes(), [INFO] [stderr] 28 | | ) [INFO] [stderr] 29 | | .expect("run_logging_output_thread error writing to stdout"); [INFO] [stderr] | |____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/logging.rs:26:37 [INFO] [stderr] | [INFO] [stderr] 26 | / "run_logging_output_thread try_recv disconnected error" [INFO] [stderr] 27 | | .as_bytes(), [INFO] [stderr] | |___________________________________________________^ help: consider using a byte string literal instead: `b"run_logging_output_thread try_recv disconnected error"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/logging.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | / stdout [INFO] [stderr] 36 | | .write(format!("run_logging_output_thread recv error {}\n", e).as_bytes()) [INFO] [stderr] 37 | | .expect("run_logging_output_thread error writing to stdout"); [INFO] [stderr] | |________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:231:14 [INFO] [stderr] | [INFO] [stderr] 231 | .unwrap_or(route_configuration.not_found_handler()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| route_configuration.not_found_handler())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | (duration.as_secs() as f64) + ((duration.subsec_nanos() as f64) / 1e9) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_hyper`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5bfe6fda87e20c20a76f137905b27bfea44edf6ed2973141e88e63b852778413"` [INFO] running `"docker" "rm" "-f" "5bfe6fda87e20c20a76f137905b27bfea44edf6ed2973141e88e63b852778413"` [INFO] [stdout] 5bfe6fda87e20c20a76f137905b27bfea44edf6ed2973141e88e63b852778413