[INFO] updating cached repository aaronriekenberg/rust-dhcp-leases [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aaronriekenberg/rust-dhcp-leases [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aaronriekenberg/rust-dhcp-leases" "work/ex/clippy-test-run/sources/stable/gh/aaronriekenberg/rust-dhcp-leases"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aaronriekenberg/rust-dhcp-leases'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aaronriekenberg/rust-dhcp-leases" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronriekenberg/rust-dhcp-leases"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronriekenberg/rust-dhcp-leases'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 80ce3cae3c4299f47cd19e8587d6e633f1b0a256 [INFO] sha for GitHub repo aaronriekenberg/rust-dhcp-leases: 80ce3cae3c4299f47cd19e8587d6e633f1b0a256 [INFO] validating manifest of aaronriekenberg/rust-dhcp-leases on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aaronriekenberg/rust-dhcp-leases on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aaronriekenberg/rust-dhcp-leases [INFO] finished frobbing aaronriekenberg/rust-dhcp-leases [INFO] frobbed toml for aaronriekenberg/rust-dhcp-leases written to work/ex/clippy-test-run/sources/stable/gh/aaronriekenberg/rust-dhcp-leases/Cargo.toml [INFO] started frobbing aaronriekenberg/rust-dhcp-leases [INFO] finished frobbing aaronriekenberg/rust-dhcp-leases [INFO] frobbed toml for aaronriekenberg/rust-dhcp-leases written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronriekenberg/rust-dhcp-leases/Cargo.toml [INFO] crate aaronriekenberg/rust-dhcp-leases has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aaronriekenberg/rust-dhcp-leases against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aaronriekenberg/rust-dhcp-leases:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 46cfc31b2824472fd824bb79c331e3bc4247bff36f8196dac397246cbe66d8ce [INFO] running `"docker" "start" "-a" "46cfc31b2824472fd824bb79c331e3bc4247bff36f8196dac397246cbe66d8ce"` [INFO] [stderr] Checking eui48 v0.3.2 [INFO] [stderr] Compiling enum-map-derive v0.2.10 [INFO] [stderr] Checking enum-map v0.2.36 [INFO] [stderr] Checking rust-dhcp-leases v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:271:55 [INFO] [stderr] | [INFO] [stderr] 271 | "IP", "State", "End Time", "MAC", "Hostname", "Organization" [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:271:55 [INFO] [stderr] | [INFO] [stderr] 271 | "IP", "State", "End Time", "MAC", "Hostname", "Organization" [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 103 | | if (split.len() >= 1) && (split[0] == "}") { [INFO] [stderr] 104 | | if let Some(current_lease) = current_lease_option { [INFO] [stderr] 105 | | if current_lease.is_after(ip_to_dhcpd_lease.get(¤t_lease.ip)) { [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | } else if (split.len() >= 1) && (split[0] == "}") { [INFO] [stderr] 103 | if let Some(current_lease) = current_lease_option { [INFO] [stderr] 104 | if current_lease.is_after(ip_to_dhcpd_lease.get(¤t_lease.ip)) { [INFO] [stderr] 105 | ip_to_dhcpd_lease.insert(current_lease.ip.clone(), current_lease); [INFO] [stderr] 106 | } [INFO] [stderr] 107 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 103 | | if (split.len() >= 1) && (split[0] == "}") { [INFO] [stderr] 104 | | if let Some(current_lease) = current_lease_option { [INFO] [stderr] 105 | | if current_lease.is_after(ip_to_dhcpd_lease.get(¤t_lease.ip)) { [INFO] [stderr] ... | [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | } else if (split.len() >= 1) && (split[0] == "}") { [INFO] [stderr] 103 | if let Some(current_lease) = current_lease_option { [INFO] [stderr] 104 | if current_lease.is_after(ip_to_dhcpd_lease.get(¤t_lease.ip)) { [INFO] [stderr] 105 | ip_to_dhcpd_lease.insert(current_lease.ip.clone(), current_lease); [INFO] [stderr] 106 | } [INFO] [stderr] 107 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | fn mac_to_oui(mac: &eui48::MacAddress) -> Oui { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `eui48::MacAddress` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | if (split.len() >= 1) && (split[0] == "}") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!split.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:106:50 [INFO] [stderr] | [INFO] [stderr] 106 | ip_to_dhcpd_lease.insert(current_lease.ip.clone(), current_lease); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_lease.ip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | / match str_to_oui(&line_string[0..6]) { [INFO] [stderr] 203 | | Ok(oui) => { [INFO] [stderr] 204 | | if oui_set.remove(&oui) { [INFO] [stderr] 205 | | let organization = &line_string[22..]; [INFO] [stderr] ... | [INFO] [stderr] 209 | | Err(_) => {} [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 202 | if let Ok(oui) = str_to_oui(&line_string[0..6]) { [INFO] [stderr] 203 | if oui_set.remove(&oui) { [INFO] [stderr] 204 | let organization = &line_string[22..]; [INFO] [stderr] 205 | oui_to_organization.insert(oui, organization.to_string()); [INFO] [stderr] 206 | } [INFO] [stderr] 207 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:237:16 [INFO] [stderr] | [INFO] [stderr] 237 | VALUES.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:286:21 [INFO] [stderr] | [INFO] [stderr] 286 | let lease = ip_to_dhcpd_lease.get(ip).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ip_to_dhcpd_lease[ip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-dhcp-leases`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | fn mac_to_oui(mac: &eui48::MacAddress) -> Oui { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `eui48::MacAddress` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | if (split.len() >= 1) && (split[0] == "}") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!split.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:106:50 [INFO] [stderr] | [INFO] [stderr] 106 | ip_to_dhcpd_lease.insert(current_lease.ip.clone(), current_lease); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_lease.ip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | / match str_to_oui(&line_string[0..6]) { [INFO] [stderr] 203 | | Ok(oui) => { [INFO] [stderr] 204 | | if oui_set.remove(&oui) { [INFO] [stderr] 205 | | let organization = &line_string[22..]; [INFO] [stderr] ... | [INFO] [stderr] 209 | | Err(_) => {} [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 202 | if let Ok(oui) = str_to_oui(&line_string[0..6]) { [INFO] [stderr] 203 | if oui_set.remove(&oui) { [INFO] [stderr] 204 | let organization = &line_string[22..]; [INFO] [stderr] 205 | oui_to_organization.insert(oui, organization.to_string()); [INFO] [stderr] 206 | } [INFO] [stderr] 207 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:237:16 [INFO] [stderr] | [INFO] [stderr] 237 | VALUES.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:286:21 [INFO] [stderr] | [INFO] [stderr] 286 | let lease = ip_to_dhcpd_lease.get(ip).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ip_to_dhcpd_lease[ip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-dhcp-leases`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "46cfc31b2824472fd824bb79c331e3bc4247bff36f8196dac397246cbe66d8ce"` [INFO] running `"docker" "rm" "-f" "46cfc31b2824472fd824bb79c331e3bc4247bff36f8196dac397246cbe66d8ce"` [INFO] [stdout] 46cfc31b2824472fd824bb79c331e3bc4247bff36f8196dac397246cbe66d8ce