[INFO] updating cached repository aaronang/rustylox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aaronang/rustylox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aaronang/rustylox" "work/ex/clippy-test-run/sources/stable/gh/aaronang/rustylox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aaronang/rustylox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aaronang/rustylox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronang/rustylox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronang/rustylox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e95c60f06ed936a95ba03fafbee7255579407a3 [INFO] sha for GitHub repo aaronang/rustylox: 8e95c60f06ed936a95ba03fafbee7255579407a3 [INFO] validating manifest of aaronang/rustylox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aaronang/rustylox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aaronang/rustylox [INFO] finished frobbing aaronang/rustylox [INFO] frobbed toml for aaronang/rustylox written to work/ex/clippy-test-run/sources/stable/gh/aaronang/rustylox/Cargo.toml [INFO] started frobbing aaronang/rustylox [INFO] finished frobbing aaronang/rustylox [INFO] frobbed toml for aaronang/rustylox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaronang/rustylox/Cargo.toml [INFO] crate aaronang/rustylox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aaronang/rustylox against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aaronang/rustylox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93f06a3a06f5521bc28aa7ad81f540ddef0b86e001bb5b9afe70438e741bbdfc [INFO] running `"docker" "start" "-a" "93f06a3a06f5521bc28aa7ad81f540ddef0b86e001bb5b9afe70438e741bbdfc"` [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking rustylox v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | fn run_file(path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | fn run(source: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | fn run_file(path: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | fn run(source: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.78s [INFO] running `"docker" "inspect" "93f06a3a06f5521bc28aa7ad81f540ddef0b86e001bb5b9afe70438e741bbdfc"` [INFO] running `"docker" "rm" "-f" "93f06a3a06f5521bc28aa7ad81f540ddef0b86e001bb5b9afe70438e741bbdfc"` [INFO] [stdout] 93f06a3a06f5521bc28aa7ad81f540ddef0b86e001bb5b9afe70438e741bbdfc