[INFO] updating cached repository aaron-lebo/comanche-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aaron-lebo/comanche-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aaron-lebo/comanche-rust" "work/ex/clippy-test-run/sources/stable/gh/aaron-lebo/comanche-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aaron-lebo/comanche-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aaron-lebo/comanche-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaron-lebo/comanche-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaron-lebo/comanche-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ddaa80e27bcb58b089b287173cba49ec6537966 [INFO] sha for GitHub repo aaron-lebo/comanche-rust: 4ddaa80e27bcb58b089b287173cba49ec6537966 [INFO] validating manifest of aaron-lebo/comanche-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aaron-lebo/comanche-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aaron-lebo/comanche-rust [INFO] finished frobbing aaron-lebo/comanche-rust [INFO] frobbed toml for aaron-lebo/comanche-rust written to work/ex/clippy-test-run/sources/stable/gh/aaron-lebo/comanche-rust/Cargo.toml [INFO] started frobbing aaron-lebo/comanche-rust [INFO] finished frobbing aaron-lebo/comanche-rust [INFO] frobbed toml for aaron-lebo/comanche-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aaron-lebo/comanche-rust/Cargo.toml [INFO] crate aaron-lebo/comanche-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aaron-lebo/comanche-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aaron-lebo/comanche-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3725083398a371126a1deb5546e70f9ec09cdc809442eeb819e0cbb8ccb6dfd9 [INFO] running `"docker" "start" "-a" "3725083398a371126a1deb5546e70f9ec09cdc809442eeb819e0cbb8ccb6dfd9"` [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Checking glfw v0.15.0 [INFO] [stderr] Checking comanche v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Quaternion` [INFO] [stderr] --> src/main.rs:5:42 [INFO] [stderr] | [INFO] [stderr] 5 | use cgmath::{vec3, Deg, Matrix4, Point3, Quaternion, Vector3}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Quaternion` [INFO] [stderr] --> src/main.rs:5:42 [INFO] [stderr] | [INFO] [stderr] 5 | use cgmath::{vec3, Deg, Matrix4, Point3, Quaternion, Vector3}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | let mut ok = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:68:14 [INFO] [stderr] | [INFO] [stderr] 68 | if ok != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:127:48 [INFO] [stderr] | [INFO] [stderr] 127 | mvp: gl::GetUniformLocation(p, CString::new("mvp").unwrap().as_ptr()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:127:48 [INFO] [stderr] | [INFO] [stderr] 127 | mvp: gl::GetUniformLocation(p, CString::new("mvp").unwrap().as_ptr()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:152:68 [INFO] [stderr] | [INFO] [stderr] 152 | (mut key, Action::Release) => { camera.keys.remove(&mut key); }, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:168:12 [INFO] [stderr] | [INFO] [stderr] 168 | if let Some(_) = camera.keys.get(&Key::W) { camera.position += pos } [INFO] [stderr] | -------^^^^^^^------------------------------------------------------ help: try this: `if camera.keys.get(&Key::W).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:169:12 [INFO] [stderr] | [INFO] [stderr] 169 | if let Some(_) = camera.keys.get(&Key::A) { camera.position -= pos.cross(camera.up).normalize() } [INFO] [stderr] | -------^^^^^^^----------------------------------------------------------------------------------- help: try this: `if camera.keys.get(&Key::A).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:170:12 [INFO] [stderr] | [INFO] [stderr] 170 | if let Some(_) = camera.keys.get(&Key::S) { camera.position -= pos } [INFO] [stderr] | -------^^^^^^^------------------------------------------------------ help: try this: `if camera.keys.get(&Key::S).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:171:12 [INFO] [stderr] | [INFO] [stderr] 171 | if let Some(_) = camera.keys.get(&Key::D) { camera.position += pos.cross(camera.up).normalize() } [INFO] [stderr] | -------^^^^^^^----------------------------------------------------------------------------------- help: try this: `if camera.keys.get(&Key::D).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `comanche`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | let mut ok = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:68:14 [INFO] [stderr] | [INFO] [stderr] 68 | if ok != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:127:48 [INFO] [stderr] | [INFO] [stderr] 127 | mvp: gl::GetUniformLocation(p, CString::new("mvp").unwrap().as_ptr()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:127:48 [INFO] [stderr] | [INFO] [stderr] 127 | mvp: gl::GetUniformLocation(p, CString::new("mvp").unwrap().as_ptr()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:152:68 [INFO] [stderr] | [INFO] [stderr] 152 | (mut key, Action::Release) => { camera.keys.remove(&mut key); }, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:168:12 [INFO] [stderr] | [INFO] [stderr] 168 | if let Some(_) = camera.keys.get(&Key::W) { camera.position += pos } [INFO] [stderr] | -------^^^^^^^------------------------------------------------------ help: try this: `if camera.keys.get(&Key::W).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:169:12 [INFO] [stderr] | [INFO] [stderr] 169 | if let Some(_) = camera.keys.get(&Key::A) { camera.position -= pos.cross(camera.up).normalize() } [INFO] [stderr] | -------^^^^^^^----------------------------------------------------------------------------------- help: try this: `if camera.keys.get(&Key::A).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:170:12 [INFO] [stderr] | [INFO] [stderr] 170 | if let Some(_) = camera.keys.get(&Key::S) { camera.position -= pos } [INFO] [stderr] | -------^^^^^^^------------------------------------------------------ help: try this: `if camera.keys.get(&Key::S).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:171:12 [INFO] [stderr] | [INFO] [stderr] 171 | if let Some(_) = camera.keys.get(&Key::D) { camera.position += pos.cross(camera.up).normalize() } [INFO] [stderr] | -------^^^^^^^----------------------------------------------------------------------------------- help: try this: `if camera.keys.get(&Key::D).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `comanche`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3725083398a371126a1deb5546e70f9ec09cdc809442eeb819e0cbb8ccb6dfd9"` [INFO] running `"docker" "rm" "-f" "3725083398a371126a1deb5546e70f9ec09cdc809442eeb819e0cbb8ccb6dfd9"` [INFO] [stdout] 3725083398a371126a1deb5546e70f9ec09cdc809442eeb819e0cbb8ccb6dfd9