[INFO] updating cached repository aapr0x/ship8 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aapr0x/ship8 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aapr0x/ship8" "work/ex/clippy-test-run/sources/stable/gh/aapr0x/ship8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aapr0x/ship8'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aapr0x/ship8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aapr0x/ship8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aapr0x/ship8'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 76c9a6270e2ed88f65cd32a8d5a394905703a0cd [INFO] sha for GitHub repo aapr0x/ship8: 76c9a6270e2ed88f65cd32a8d5a394905703a0cd [INFO] validating manifest of aapr0x/ship8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aapr0x/ship8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aapr0x/ship8 [INFO] finished frobbing aapr0x/ship8 [INFO] frobbed toml for aapr0x/ship8 written to work/ex/clippy-test-run/sources/stable/gh/aapr0x/ship8/Cargo.toml [INFO] started frobbing aapr0x/ship8 [INFO] finished frobbing aapr0x/ship8 [INFO] frobbed toml for aapr0x/ship8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aapr0x/ship8/Cargo.toml [INFO] crate aapr0x/ship8 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aapr0x/ship8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aapr0x/ship8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c9511c5cd8708c17f70d8fcf544eb8946a9d31d1a982c11cacaee335f0294aa9 [INFO] running `"docker" "start" "-a" "c9511c5cd8708c17f70d8fcf544eb8946a9d31d1a982c11cacaee335f0294aa9"` [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking ship8 v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:615:27 [INFO] [stderr] | [INFO] [stderr] 615 | const PONG_CODE: &'static [u8; 264] = include_bytes!("./pong.ch8"); [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[u8; 264]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:257:30 [INFO] [stderr] | [INFO] [stderr] 257 | for i in 0..(x + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:268:30 [INFO] [stderr] | [INFO] [stderr] 268 | for i in 0..(x + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:257:30 [INFO] [stderr] | [INFO] [stderr] 257 | for i in 0..(x + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:268:30 [INFO] [stderr] | [INFO] [stderr] 268 | for i in 0..(x + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.75s [INFO] running `"docker" "inspect" "c9511c5cd8708c17f70d8fcf544eb8946a9d31d1a982c11cacaee335f0294aa9"` [INFO] running `"docker" "rm" "-f" "c9511c5cd8708c17f70d8fcf544eb8946a9d31d1a982c11cacaee335f0294aa9"` [INFO] [stdout] c9511c5cd8708c17f70d8fcf544eb8946a9d31d1a982c11cacaee335f0294aa9