[INFO] updating cached repository aag/eagle-eye [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/aag/eagle-eye [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/aag/eagle-eye" "work/ex/clippy-test-run/sources/stable/gh/aag/eagle-eye"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/aag/eagle-eye'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/aag/eagle-eye" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aag/eagle-eye"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aag/eagle-eye'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 41fe555eb9b2a55e4ff647b35e602f4f4811ffa0 [INFO] sha for GitHub repo aag/eagle-eye: 41fe555eb9b2a55e4ff647b35e602f4f4811ffa0 [INFO] validating manifest of aag/eagle-eye on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aag/eagle-eye on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aag/eagle-eye [INFO] finished frobbing aag/eagle-eye [INFO] frobbed toml for aag/eagle-eye written to work/ex/clippy-test-run/sources/stable/gh/aag/eagle-eye/Cargo.toml [INFO] started frobbing aag/eagle-eye [INFO] finished frobbing aag/eagle-eye [INFO] frobbed toml for aag/eagle-eye written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/aag/eagle-eye/Cargo.toml [INFO] crate aag/eagle-eye has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aag/eagle-eye against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/aag/eagle-eye:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6789b4893739cad13513b31ea1cc3461d395356a5c5a6c06a8e24de2ad83ec9a [INFO] running `"docker" "start" "-a" "6789b4893739cad13513b31ea1cc3461d395356a5c5a6c06a8e24de2ad83ec9a"` [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Checking inotify v0.2.3 [INFO] [stderr] Checking docopt v0.6.86 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v2.6.3 [INFO] [stderr] Checking eagle v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files_watcher.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions/command.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | command_line: command_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions/command.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | quiet: quiet, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `quiet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/main.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files_watcher.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions/command.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | command_line: command_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/actions/command.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | quiet: quiet, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `quiet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/main.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `files_watcher::FilesWatcher` [INFO] [stderr] --> src/files_watcher.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> FilesWatcher { [INFO] [stderr] 21 | | let (tx, rx) = channel(); [INFO] [stderr] 22 | | let watcher: Result = Watcher::new(tx); [INFO] [stderr] 23 | | [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | impl Default for files_watcher::FilesWatcher { [INFO] [stderr] 20 | fn default() -> Self { [INFO] [stderr] 21 | Self::new() [INFO] [stderr] 22 | } [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/files_watcher.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | / match action.handle_change(&event) { [INFO] [stderr] 61 | | Ok(_) => num_actions += 1, [INFO] [stderr] 62 | | Err(_) => {} [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________________________________^ help: try this: `if let Ok(_) = action.handle_change(&event) { num_actions += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `actions::print::PrintAction` [INFO] [stderr] --> src/actions/print.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> PrintAction { [INFO] [stderr] 10 | | PrintAction [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/actions/print.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn flag_to_str(&self, flag: &Op) -> &'static str { [INFO] [stderr] | ^^^ help: consider passing by value instead: `Op` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/actions/print.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match flag { [INFO] [stderr] 15 | | &op::CHMOD => "Permissions or timestamps changed", [INFO] [stderr] 16 | | &op::CREATE => "File or directory created", [INFO] [stderr] 17 | | &op::REMOVE => "File or directory removed", [INFO] [stderr] ... | [INFO] [stderr] 20 | | _ => "Unknown change", [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *flag { [INFO] [stderr] 15 | op::CHMOD => "Permissions or timestamps changed", [INFO] [stderr] 16 | op::CREATE => "File or directory created", [INFO] [stderr] 17 | op::REMOVE => "File or directory removed", [INFO] [stderr] 18 | op::RENAME => "File or directory renamed", [INFO] [stderr] 19 | op::WRITE => "File or diretory written to", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/actions/command.rs:30:49 [INFO] [stderr] | [INFO] [stderr] 30 | let mut cmd_pieces = command_line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/actions/command.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | / match write_result { [INFO] [stderr] 66 | | Err(x) => println!("Error: Unable to write to stderr: {}", x), [INFO] [stderr] 67 | | Ok(_) => {} [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let Err(x) = write_result { println!("Error: Unable to write to stderr: {}", x) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if watchers.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!watchers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | let ref watcher = watchers[0]; [INFO] [stderr] | ----^^^^^^^^^^^--------------- help: try: `let watcher = &watchers[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | / match watcher.action_type.as_ref() { [INFO] [stderr] 102 | | "command" => { [INFO] [stderr] 103 | | let execute_string = watcher.execute.to_owned(); [INFO] [stderr] 104 | | let command = CommandAction::new(execute_string, quiet_flag); [INFO] [stderr] ... | [INFO] [stderr] 107 | | _ => (), [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let "command" = watcher.action_type.as_ref() { [INFO] [stderr] 102 | let execute_string = watcher.execute.to_owned(); [INFO] [stderr] 103 | let command = CommandAction::new(execute_string, quiet_flag); [INFO] [stderr] 104 | actions.push(Box::new(command)); [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `files_watcher::FilesWatcher` [INFO] [stderr] --> src/files_watcher.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> FilesWatcher { [INFO] [stderr] 21 | | let (tx, rx) = channel(); [INFO] [stderr] 22 | | let watcher: Result = Watcher::new(tx); [INFO] [stderr] 23 | | [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | impl Default for files_watcher::FilesWatcher { [INFO] [stderr] 20 | fn default() -> Self { [INFO] [stderr] 21 | Self::new() [INFO] [stderr] 22 | } [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/files_watcher.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | / match action.handle_change(&event) { [INFO] [stderr] 61 | | Ok(_) => num_actions += 1, [INFO] [stderr] 62 | | Err(_) => {} [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________________________________^ help: try this: `if let Ok(_) = action.handle_change(&event) { num_actions += 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/files_watcher.rs:239:24 [INFO] [stderr] | [INFO] [stderr] 239 | let path_buf = PathBuf::from(path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `actions::print::PrintAction` [INFO] [stderr] --> src/actions/print.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> PrintAction { [INFO] [stderr] 10 | | PrintAction [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/actions/print.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn flag_to_str(&self, flag: &Op) -> &'static str { [INFO] [stderr] | ^^^ help: consider passing by value instead: `Op` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/actions/print.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match flag { [INFO] [stderr] 15 | | &op::CHMOD => "Permissions or timestamps changed", [INFO] [stderr] 16 | | &op::CREATE => "File or directory created", [INFO] [stderr] 17 | | &op::REMOVE => "File or directory removed", [INFO] [stderr] ... | [INFO] [stderr] 20 | | _ => "Unknown change", [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *flag { [INFO] [stderr] 15 | op::CHMOD => "Permissions or timestamps changed", [INFO] [stderr] 16 | op::CREATE => "File or directory created", [INFO] [stderr] 17 | op::REMOVE => "File or directory removed", [INFO] [stderr] 18 | op::RENAME => "File or directory renamed", [INFO] [stderr] 19 | op::WRITE => "File or diretory written to", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/actions/command.rs:30:49 [INFO] [stderr] | [INFO] [stderr] 30 | let mut cmd_pieces = command_line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/actions/command.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | / match write_result { [INFO] [stderr] 66 | | Err(x) => println!("Error: Unable to write to stderr: {}", x), [INFO] [stderr] 67 | | Ok(_) => {} [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let Err(x) = write_result { println!("Error: Unable to write to stderr: {}", x) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if watchers.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!watchers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | let ref watcher = watchers[0]; [INFO] [stderr] | ----^^^^^^^^^^^--------------- help: try: `let watcher = &watchers[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | / match watcher.action_type.as_ref() { [INFO] [stderr] 102 | | "command" => { [INFO] [stderr] 103 | | let execute_string = watcher.execute.to_owned(); [INFO] [stderr] 104 | | let command = CommandAction::new(execute_string, quiet_flag); [INFO] [stderr] ... | [INFO] [stderr] 107 | | _ => (), [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let "command" = watcher.action_type.as_ref() { [INFO] [stderr] 102 | let execute_string = watcher.execute.to_owned(); [INFO] [stderr] 103 | let command = CommandAction::new(execute_string, quiet_flag); [INFO] [stderr] 104 | actions.push(Box::new(command)); [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.53s [INFO] running `"docker" "inspect" "6789b4893739cad13513b31ea1cc3461d395356a5c5a6c06a8e24de2ad83ec9a"` [INFO] running `"docker" "rm" "-f" "6789b4893739cad13513b31ea1cc3461d395356a5c5a6c06a8e24de2ad83ec9a"` [INFO] [stdout] 6789b4893739cad13513b31ea1cc3461d395356a5c5a6c06a8e24de2ad83ec9a