[INFO] updating cached repository a544jh/my-rusty-sensors
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/a544jh/my-rusty-sensors
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/a544jh/my-rusty-sensors" "work/ex/clippy-test-run/sources/stable/gh/a544jh/my-rusty-sensors"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/a544jh/my-rusty-sensors'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/a544jh/my-rusty-sensors" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/a544jh/my-rusty-sensors"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/a544jh/my-rusty-sensors'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] bd00df0e8badb64b7ff80b91a4ac402954a21456
[INFO] sha for GitHub repo a544jh/my-rusty-sensors: bd00df0e8badb64b7ff80b91a4ac402954a21456
[INFO] validating manifest of a544jh/my-rusty-sensors on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of a544jh/my-rusty-sensors on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing a544jh/my-rusty-sensors
[INFO] finished frobbing a544jh/my-rusty-sensors
[INFO] frobbed toml for a544jh/my-rusty-sensors written to work/ex/clippy-test-run/sources/stable/gh/a544jh/my-rusty-sensors/Cargo.toml
[INFO] started frobbing a544jh/my-rusty-sensors
[INFO] finished frobbing a544jh/my-rusty-sensors
[INFO] frobbed toml for a544jh/my-rusty-sensors written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/a544jh/my-rusty-sensors/Cargo.toml
[INFO] crate a544jh/my-rusty-sensors has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting a544jh/my-rusty-sensors against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/a544jh/my-rusty-sensors:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1399dbe55874e3e42587bb9c8c6cf7386035dc6adba87558b8d45f8d53043433
[INFO] running `"docker" "start" "-a" "1399dbe55874e3e42587bb9c8c6cf7386035dc6adba87558b8d45f8d53043433"`
[INFO] [stderr]     Checking libudev-sys v0.1.4
[INFO] [stderr]     Checking nix v0.10.0
[INFO] [stderr]     Checking chrono v0.4.3
[INFO] [stderr]    Compiling num-derive v0.2.2
[INFO] [stderr]     Checking libudev v0.2.0
[INFO] [stderr]     Checking serialport v2.3.0
[INFO] [stderr]     Checking my-rusty-sensors v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/controller/mod.rs:99:24
[INFO] [stderr]     |
[INFO] [stderr] 99  |                   if let None = sensor.sensor_type {
[INFO] [stderr]     |  _________________-      ^^^^
[INFO] [stderr] 100 | |                     let msg = Message {
[INFO] [stderr] 101 | |                         node_id: node.id,
[INFO] [stderr] 102 | |                         child_sensor_id: sensor.id,
[INFO] [stderr] ...   |
[INFO] [stderr] 114 | |                     self.gateway.send(&msg);
[INFO] [stderr] 115 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if sensor.sensor_type.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/controller/mod.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 | /         match self.find_node(node_id) {
[INFO] [stderr] 142 | |             Some(n) => {
[INFO] [stderr] 143 | |                 func(n);
[INFO] [stderr] 144 | |                 return;
[INFO] [stderr] 145 | |             }
[INFO] [stderr] 146 | |             None => (),
[INFO] [stderr] 147 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 141 |         if let Some(n) = self.find_node(node_id) {
[INFO] [stderr] 142 |     func(n);
[INFO] [stderr] 143 |     return;
[INFO] [stderr] 144 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/controller/mod.rs:161:9
[INFO] [stderr]     |
[INFO] [stderr] 161 | /         match self.find_sensor(node_id, child_id) {
[INFO] [stderr] 162 | |             Some(s) => {
[INFO] [stderr] 163 | |                 func(s);
[INFO] [stderr] 164 | |                 return;
[INFO] [stderr] 165 | |             }
[INFO] [stderr] 166 | |             None => (),
[INFO] [stderr] 167 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 161 |         if let Some(s) = self.find_sensor(node_id, child_id) {
[INFO] [stderr] 162 |     func(s);
[INFO] [stderr] 163 |     return;
[INFO] [stderr] 164 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/controller/mod.rs:175:9
[INFO] [stderr]     |
[INFO] [stderr] 175 | /         match self.find_node(node_id) {
[INFO] [stderr] 176 | |             Some(n) => {
[INFO] [stderr] 177 | |                 n.sensors.push(new_sensor);
[INFO] [stderr] 178 | |                 return;
[INFO] [stderr] 179 | |             }
[INFO] [stderr] 180 | |             None => (),
[INFO] [stderr] 181 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 175 |         if let Some(n) = self.find_node(node_id) {
[INFO] [stderr] 176 |     n.sensors.push(new_sensor);
[INFO] [stderr] 177 |     return;
[INFO] [stderr] 178 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/gateway/message.rs:67:51
[INFO] [stderr]    |
[INFO] [stderr] 67 |             0 => FromPrimitive::from_u32(typ).map(|t| Command::Presentation(t)),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Command::Presentation`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/gateway/message.rs:68:51
[INFO] [stderr]    |
[INFO] [stderr] 68 |             1 => FromPrimitive::from_u32(typ).map(|t| Command::Set(t)),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Command::Set`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/gateway/message.rs:69:51
[INFO] [stderr]    |
[INFO] [stderr] 69 |             2 => FromPrimitive::from_u32(typ).map(|t| Command::Req(t)),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Command::Req`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/gateway/message.rs:70:51
[INFO] [stderr]    |
[INFO] [stderr] 70 |             3 => FromPrimitive::from_u32(typ).map(|t| Command::Internal(t)),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Command::Internal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/gateway/serial.rs:39:15
[INFO] [stderr]    |
[INFO] [stderr] 39 |       let ack = match msg.ack {
[INFO] [stderr]    |  _______________^
[INFO] [stderr] 40 | |         true => "1",
[INFO] [stderr] 41 | |         false => "0",
[INFO] [stderr] 42 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if msg.ack { "1" } else { "0" }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/gateway/serial.rs:75:32
[INFO] [stderr]    |
[INFO] [stderr] 75 |     let mut it = msg_str.split(";");
[INFO] [stderr]    |                                ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/gateway/serial.rs:102:14
[INFO] [stderr]     |
[INFO] [stderr] 102 |         ack: if ack != 0 { true } else { false },
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `ack != 0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/controller/mod.rs:99:24
[INFO] [stderr]     |
[INFO] [stderr] 99  |                   if let None = sensor.sensor_type {
[INFO] [stderr]     |  _________________-      ^^^^
[INFO] [stderr] 100 | |                     let msg = Message {
[INFO] [stderr] 101 | |                         node_id: node.id,
[INFO] [stderr] 102 | |                         child_sensor_id: sensor.id,
[INFO] [stderr] ...   |
[INFO] [stderr] 114 | |                     self.gateway.send(&msg);
[INFO] [stderr] 115 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if sensor.sensor_type.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/controller/mod.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 | /         match self.find_node(node_id) {
[INFO] [stderr] 142 | |             Some(n) => {
[INFO] [stderr] 143 | |                 func(n);
[INFO] [stderr] 144 | |                 return;
[INFO] [stderr] 145 | |             }
[INFO] [stderr] 146 | |             None => (),
[INFO] [stderr] 147 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 141 |         if let Some(n) = self.find_node(node_id) {
[INFO] [stderr] 142 |     func(n);
[INFO] [stderr] 143 |     return;
[INFO] [stderr] 144 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/controller/mod.rs:161:9
[INFO] [stderr]     |
[INFO] [stderr] 161 | /         match self.find_sensor(node_id, child_id) {
[INFO] [stderr] 162 | |             Some(s) => {
[INFO] [stderr] 163 | |                 func(s);
[INFO] [stderr] 164 | |                 return;
[INFO] [stderr] 165 | |             }
[INFO] [stderr] 166 | |             None => (),
[INFO] [stderr] 167 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 161 |         if let Some(s) = self.find_sensor(node_id, child_id) {
[INFO] [stderr] 162 |     func(s);
[INFO] [stderr] 163 |     return;
[INFO] [stderr] 164 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/controller/mod.rs:175:9
[INFO] [stderr]     |
[INFO] [stderr] 175 | /         match self.find_node(node_id) {
[INFO] [stderr] 176 | |             Some(n) => {
[INFO] [stderr] 177 | |                 n.sensors.push(new_sensor);
[INFO] [stderr] 178 | |                 return;
[INFO] [stderr] 179 | |             }
[INFO] [stderr] 180 | |             None => (),
[INFO] [stderr] 181 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 175 |         if let Some(n) = self.find_node(node_id) {
[INFO] [stderr] 176 |     n.sensors.push(new_sensor);
[INFO] [stderr] 177 |     return;
[INFO] [stderr] 178 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/gateway/message.rs:67:51
[INFO] [stderr]    |
[INFO] [stderr] 67 |             0 => FromPrimitive::from_u32(typ).map(|t| Command::Presentation(t)),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Command::Presentation`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/gateway/message.rs:68:51
[INFO] [stderr]    |
[INFO] [stderr] 68 |             1 => FromPrimitive::from_u32(typ).map(|t| Command::Set(t)),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Command::Set`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/gateway/message.rs:69:51
[INFO] [stderr]    |
[INFO] [stderr] 69 |             2 => FromPrimitive::from_u32(typ).map(|t| Command::Req(t)),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Command::Req`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/gateway/message.rs:70:51
[INFO] [stderr]    |
[INFO] [stderr] 70 |             3 => FromPrimitive::from_u32(typ).map(|t| Command::Internal(t)),
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Command::Internal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/gateway/serial.rs:39:15
[INFO] [stderr]    |
[INFO] [stderr] 39 |       let ack = match msg.ack {
[INFO] [stderr]    |  _______________^
[INFO] [stderr] 40 | |         true => "1",
[INFO] [stderr] 41 | |         false => "0",
[INFO] [stderr] 42 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if msg.ack { "1" } else { "0" }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/gateway/serial.rs:75:32
[INFO] [stderr]    |
[INFO] [stderr] 75 |     let mut it = msg_str.split(";");
[INFO] [stderr]    |                                ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/gateway/serial.rs:102:14
[INFO] [stderr]     |
[INFO] [stderr] 102 |         ack: if ack != 0 { true } else { false },
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `ack != 0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 14.28s
[INFO] running `"docker" "inspect" "1399dbe55874e3e42587bb9c8c6cf7386035dc6adba87558b8d45f8d53043433"`
[INFO] running `"docker" "rm" "-f" "1399dbe55874e3e42587bb9c8c6cf7386035dc6adba87558b8d45f8d53043433"`
[INFO] [stdout] 1399dbe55874e3e42587bb9c8c6cf7386035dc6adba87558b8d45f8d53043433