[INFO] updating cached repository ZhouHansen/async_rust_playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ZhouHansen/async_rust_playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ZhouHansen/async_rust_playground" "work/ex/clippy-test-run/sources/stable/gh/ZhouHansen/async_rust_playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ZhouHansen/async_rust_playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ZhouHansen/async_rust_playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ZhouHansen/async_rust_playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ZhouHansen/async_rust_playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 35a57a71145390d68ca6d19ee16905543662d726 [INFO] sha for GitHub repo ZhouHansen/async_rust_playground: 35a57a71145390d68ca6d19ee16905543662d726 [INFO] validating manifest of ZhouHansen/async_rust_playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ZhouHansen/async_rust_playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ZhouHansen/async_rust_playground [INFO] finished frobbing ZhouHansen/async_rust_playground [INFO] frobbed toml for ZhouHansen/async_rust_playground written to work/ex/clippy-test-run/sources/stable/gh/ZhouHansen/async_rust_playground/Cargo.toml [INFO] started frobbing ZhouHansen/async_rust_playground [INFO] finished frobbing ZhouHansen/async_rust_playground [INFO] frobbed toml for ZhouHansen/async_rust_playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ZhouHansen/async_rust_playground/Cargo.toml [INFO] crate ZhouHansen/async_rust_playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ZhouHansen/async_rust_playground against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ZhouHansen/async_rust_playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b895209a881de2b55303f4fe4d59fc22fe2494f6032656e937af3fd417a8cc2 [INFO] running `"docker" "start" "-a" "1b895209a881de2b55303f4fe4d59fc22fe2494f6032656e937af3fd417a8cc2"` [INFO] [stderr] Checking async_rust_playground v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_loop.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | self.tx.send(Registration { at, wake: wake }).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `wake` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_loop.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | self.tx.send(Registration { at, wake: wake }).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `wake` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/task_exc.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | id: wake.id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `wake.id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `task_exc::ToyExec` [INFO] [stderr] --> src/task_exc.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new() -> Self { [INFO] [stderr] 79 | | ToyExec { [INFO] [stderr] 80 | | state: Arc::new(Mutex::new(ExecState { [INFO] [stderr] 81 | | next_id: 0, [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | impl Default for task_exc::ToyExec { [INFO] [stderr] 78 | fn default() -> Self { [INFO] [stderr] 79 | Self::new() [INFO] [stderr] 80 | } [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/task_exc.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | if self.state_mut().tasks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.state_mut().tasks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `event_loop::ToyTimer` [INFO] [stderr] --> src/event_loop.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new() -> ToyTimer { [INFO] [stderr] 27 | | let (tx, rx) = mpsc::channel(); [INFO] [stderr] 28 | | let worker = Worker { rx, active: BTreeMap::new() }; [INFO] [stderr] 29 | | thread::spawn(|| worker.work()); [INFO] [stderr] 30 | | ToyTimer { tx } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | impl Default for event_loop::ToyTimer { [INFO] [stderr] 26 | fn default() -> Self { [INFO] [stderr] 27 | Self::new() [INFO] [stderr] 28 | } [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/event_loop.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / if active.contains_key(&property) { [INFO] [stderr] 78 | | if let Some(x) = active.get_mut(&property) { [INFO] [stderr] 79 | | (*x).push(new_value); [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } else { [INFO] [stderr] 82 | | active.insert(property, vec![new_value]); [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ help: consider using: `active.entry(property)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/task_exc.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | id: wake.id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `wake.id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `task_exc::ToyExec` [INFO] [stderr] --> src/task_exc.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new() -> Self { [INFO] [stderr] 79 | | ToyExec { [INFO] [stderr] 80 | | state: Arc::new(Mutex::new(ExecState { [INFO] [stderr] 81 | | next_id: 0, [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | impl Default for task_exc::ToyExec { [INFO] [stderr] 78 | fn default() -> Self { [INFO] [stderr] 79 | Self::new() [INFO] [stderr] 80 | } [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/task_exc.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | if self.state_mut().tasks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.state_mut().tasks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `event_loop::ToyTimer` [INFO] [stderr] --> src/event_loop.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new() -> ToyTimer { [INFO] [stderr] 27 | | let (tx, rx) = mpsc::channel(); [INFO] [stderr] 28 | | let worker = Worker { rx, active: BTreeMap::new() }; [INFO] [stderr] 29 | | thread::spawn(|| worker.work()); [INFO] [stderr] 30 | | ToyTimer { tx } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | impl Default for event_loop::ToyTimer { [INFO] [stderr] 26 | fn default() -> Self { [INFO] [stderr] 27 | Self::new() [INFO] [stderr] 28 | } [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/event_loop.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / if active.contains_key(&property) { [INFO] [stderr] 78 | | if let Some(x) = active.get_mut(&property) { [INFO] [stderr] 79 | | (*x).push(new_value); [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } else { [INFO] [stderr] 82 | | active.insert(property, vec![new_value]); [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ help: consider using: `active.entry(property)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `"docker" "inspect" "1b895209a881de2b55303f4fe4d59fc22fe2494f6032656e937af3fd417a8cc2"` [INFO] running `"docker" "rm" "-f" "1b895209a881de2b55303f4fe4d59fc22fe2494f6032656e937af3fd417a8cc2"` [INFO] [stdout] 1b895209a881de2b55303f4fe4d59fc22fe2494f6032656e937af3fd417a8cc2