[INFO] updating cached repository ZelphirKaltstahl/RustGtkApp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ZelphirKaltstahl/RustGtkApp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ZelphirKaltstahl/RustGtkApp" "work/ex/clippy-test-run/sources/stable/gh/ZelphirKaltstahl/RustGtkApp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ZelphirKaltstahl/RustGtkApp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ZelphirKaltstahl/RustGtkApp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ZelphirKaltstahl/RustGtkApp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ZelphirKaltstahl/RustGtkApp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bc87ea67911589eac771e91abb2990f396f02a8a [INFO] sha for GitHub repo ZelphirKaltstahl/RustGtkApp: bc87ea67911589eac771e91abb2990f396f02a8a [INFO] validating manifest of ZelphirKaltstahl/RustGtkApp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ZelphirKaltstahl/RustGtkApp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ZelphirKaltstahl/RustGtkApp [INFO] finished frobbing ZelphirKaltstahl/RustGtkApp [INFO] frobbed toml for ZelphirKaltstahl/RustGtkApp written to work/ex/clippy-test-run/sources/stable/gh/ZelphirKaltstahl/RustGtkApp/Cargo.toml [INFO] started frobbing ZelphirKaltstahl/RustGtkApp [INFO] finished frobbing ZelphirKaltstahl/RustGtkApp [INFO] frobbed toml for ZelphirKaltstahl/RustGtkApp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ZelphirKaltstahl/RustGtkApp/Cargo.toml [INFO] crate ZelphirKaltstahl/RustGtkApp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ZelphirKaltstahl/RustGtkApp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ZelphirKaltstahl/RustGtkApp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 404ed2b29b290b9538a30459a2466a5483895e60c5accd1f3214cf6eff5bad39 [INFO] running `"docker" "start" "-a" "404ed2b29b290b9538a30459a2466a5483895e60c5accd1f3214cf6eff5bad39"` [INFO] [stderr] Compiling cairo-rs v0.2.0 [INFO] [stderr] Compiling gio v0.2.0 [INFO] [stderr] Compiling gdk-pixbuf v0.2.0 [INFO] [stderr] Compiling gdk v0.6.0 [INFO] [stderr] Compiling gtk v0.2.0 [INFO] [stderr] Compiling glib-sys v0.4.0 [INFO] [stderr] Compiling gobject-sys v0.4.0 [INFO] [stderr] Compiling gio-sys v0.4.0 [INFO] [stderr] Compiling pango-sys v0.4.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.4.0 [INFO] [stderr] Compiling cairo-sys-rs v0.4.0 [INFO] [stderr] Compiling atk-sys v0.4.0 [INFO] [stderr] Compiling gdk-sys v0.4.0 [INFO] [stderr] Compiling gtk-sys v0.4.0 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking glib v0.3.1 [INFO] [stderr] Checking pango v0.2.0 [INFO] [stderr] Checking vocabulary_trainer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_status_message.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_status_message.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | context: context [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_textview.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_textview.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | model: model [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_textview.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_textview.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | model: model [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_treeview.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | tree_view: tree_view, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tree_view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_treeview.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | model: model [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_treeview.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | tree_view: tree_view, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tree_view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_treeview.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | model: model [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_status_message.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_status_message.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | context: context [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_textview.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_textview.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | model: model [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_textview.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | view: view, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_textview.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | model: model [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_treeview.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | tree_view: tree_view, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tree_view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_treeview.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | model: model [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_treeview.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | tree_view: tree_view, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tree_view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/include/voc_treeview.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | model: model [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Container` [INFO] [stderr] --> src/include/voc_notebook.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | Box, Button, Container, IconSize, Image, Label, Notebook, Orientation, ReliefStyle, Widget}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `TextTagTable` [INFO] [stderr] --> src/include/voc_textview.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | TextTagTable [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ListStore`, `TreeModel` [INFO] [stderr] --> src/include/voc_treeview.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | ListStore, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] 9 | TreeModel, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/include/voc_treeview.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | number_of_columns [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/include/voc_treeview.rs:104:33 [INFO] [stderr] | [INFO] [stderr] 104 | let number_of_columns = lang_ids.iter().len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/include/voc_treeview.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/include/voc_treeview.rs:138:19 [INFO] [stderr] | [INFO] [stderr] 138 | let res = values_vector.into_iter().map( [INFO] [stderr] | ___________________^ [INFO] [stderr] 139 | | |item| item as >k::ToValue [INFO] [stderr] 140 | | ).collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Container` [INFO] [stderr] --> src/include/voc_notebook.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | Box, Button, Container, IconSize, Image, Label, Notebook, Orientation, ReliefStyle, Widget}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `TextTagTable` [INFO] [stderr] --> src/include/voc_textview.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | TextTagTable [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ListStore`, `TreeModel` [INFO] [stderr] --> src/include/voc_treeview.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | ListStore, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] 9 | TreeModel, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/include/voc_treeview.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | number_of_columns [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/include/voc_treeview.rs:104:33 [INFO] [stderr] | [INFO] [stderr] 104 | let number_of_columns = lang_ids.iter().len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/include/voc_treeview.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/include/voc_treeview.rs:138:19 [INFO] [stderr] | [INFO] [stderr] 138 | let res = values_vector.into_iter().map( [INFO] [stderr] | ___________________^ [INFO] [stderr] 139 | | |item| item as >k::ToValue [INFO] [stderr] 140 | | ).collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/main.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / macro_rules! hashmap { [INFO] [stderr] 28 | | ($( $key: expr => $val: expr ),*) => {{ [INFO] [stderr] 29 | | let mut map = ::std::collections::HashMap::new(); [INFO] [stderr] 30 | | $( map.insert($key, $val); )* [INFO] [stderr] 31 | | map [INFO] [stderr] 32 | | }} [INFO] [stderr] 33 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/main.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / macro_rules! hashmap { [INFO] [stderr] 28 | | ($( $key: expr => $val: expr ),*) => {{ [INFO] [stderr] 29 | | let mut map = ::std::collections::HashMap::new(); [INFO] [stderr] 30 | | $( map.insert($key, $val); )* [INFO] [stderr] 31 | | map [INFO] [stderr] 32 | | }} [INFO] [stderr] 33 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `library_tab_index` [INFO] [stderr] --> src/main.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | let library_tab_index : u32 = notebook.create_tab( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_library_tab_index` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `training_tab_index` [INFO] [stderr] --> src/main.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | let training_tab_index : u32 = notebook.create_tab( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using `_training_tab_index` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `statistics_tab_index` [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | let statistics_tab_index : u32 = notebook.create_tab( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `_statistics_tab_index` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `message_id` [INFO] [stderr] --> src/include/voc_statusbar.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let message_id: u32 = self.status_bar.push(context_id, &status_message.message); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_message_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `characters` [INFO] [stderr] --> src/include/voc_textview.rs:27:32 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new_with_characters(characters: String) -> VocTextView { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_characters` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `library_tab_index` [INFO] [stderr] --> src/main.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | let library_tab_index : u32 = notebook.create_tab( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_library_tab_index` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `training_tab_index` [INFO] [stderr] --> src/main.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | let training_tab_index : u32 = notebook.create_tab( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using `_training_tab_index` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `statistics_tab_index` [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | let statistics_tab_index : u32 = notebook.create_tab( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `_statistics_tab_index` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `message_id` [INFO] [stderr] --> src/include/voc_statusbar.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | let message_id: u32 = self.status_bar.push(context_id, &status_message.message); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_message_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `characters` [INFO] [stderr] --> src/include/voc_textview.rs:27:32 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new_with_characters(characters: String) -> VocTextView { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_characters` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/include/voc_status_message.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn new(message: String, context: String) -> VocStatusMessage { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `VocTextView` [INFO] [stderr] --> src/include/voc_textview.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct VocTextView { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/include/voc_textview.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new() -> VocTextView { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_with_characters` [INFO] [stderr] --> src/include/voc_textview.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new_with_characters(characters: String) -> VocTextView { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_data` [INFO] [stderr] --> src/csv_reading_and_writing.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn write_data(file_path: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_data` [INFO] [stderr] --> src/csv_reading_and_writing.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn read_data(file_path: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `include::voc_notebook::VocNotebook` [INFO] [stderr] --> src/include/voc_notebook.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> VocNotebook { [INFO] [stderr] 25 | | VocNotebook { [INFO] [stderr] 26 | | notebook: Notebook::new(), [INFO] [stderr] 27 | | tabs: Vec::new() [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/include/voc_statusbar.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let bar: Statusbar = Statusbar::new(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `include::voc_treeview::VocTreeView` [INFO] [stderr] --> src/include/voc_treeview.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> VocTreeView { [INFO] [stderr] 24 | | let column_types = [String::static_type()]; [INFO] [stderr] 25 | | let model = TreeStore::new(&column_types); [INFO] [stderr] 26 | | let tree_view = TreeView::new_with_model(&model); [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | impl Default for include::voc_treeview::VocTreeView { [INFO] [stderr] 23 | fn default() -> Self { [INFO] [stderr] 24 | Self::new() [INFO] [stderr] 25 | } [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is used to index `lang_ids` [INFO] [stderr] --> src/include/voc_treeview.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | for index in 0..number_of_columns { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for (index, ) in lang_ids.iter().enumerate().take(number_of_columns) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/include/voc_treeview.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | vocabulary.metadata.language_id_to_name.get(&lang_ids[index]).unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&vocabulary.metadata.language_id_to_name[&lang_ids[index]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `lang_ids`. [INFO] [stderr] --> src/include/voc_treeview.rs:77:30 [INFO] [stderr] | [INFO] [stderr] 77 | for index in 0..number_of_columns { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for in lang_ids.iter().take(number_of_columns) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/include/voc_treeview.rs:78:81 [INFO] [stderr] | [INFO] [stderr] 78 | let item_to_add = meaning.translation.get(&lang_ids[index]).expect( [INFO] [stderr] | _________________________________________________________________________________^ [INFO] [stderr] 79 | | &format!("{} {}", [INFO] [stderr] 80 | | "Not as many translation attributes as lang_ids in the metadata of the JSON.", [INFO] [stderr] 81 | | "Are you sure the JSON is valid?")) [INFO] [stderr] | |____________________________________________________________________^ help: try this: `unwrap_or_else(|| panic!("{} {}", "Not as many translation attributes as lang_ids in the metadata of the JSON."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: method `string_to_ToValue` should have a snake case name such as `string_to_to_value` [INFO] [stderr] --> src/include/voc_treeview.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | / pub fn string_to_ToValue(values_vector: &[String]) -> Vec<>k::ToValue> { [INFO] [stderr] 138 | | let res = values_vector.into_iter().map( [INFO] [stderr] 139 | | |item| item as >k::ToValue [INFO] [stderr] 140 | | ).collect(); [INFO] [stderr] 141 | | // println!("{:?}", DebugPrintableToValue(res)); // this print seems impossible [INFO] [stderr] 142 | | res [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/include/voc_treeview.rs:138:33 [INFO] [stderr] | [INFO] [stderr] 138 | let res = values_vector.into_iter().map( [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/include/voc_status_message.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn new(message: String, context: String) -> VocStatusMessage { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `VocTextView` [INFO] [stderr] --> src/include/voc_textview.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct VocTextView { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/include/voc_textview.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new() -> VocTextView { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_with_characters` [INFO] [stderr] --> src/include/voc_textview.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new_with_characters(characters: String) -> VocTextView { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_data` [INFO] [stderr] --> src/csv_reading_and_writing.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn write_data(file_path: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_data` [INFO] [stderr] --> src/csv_reading_and_writing.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn read_data(file_path: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `include::voc_notebook::VocNotebook` [INFO] [stderr] --> src/include/voc_notebook.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> VocNotebook { [INFO] [stderr] 25 | | VocNotebook { [INFO] [stderr] 26 | | notebook: Notebook::new(), [INFO] [stderr] 27 | | tabs: Vec::new() [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/include/voc_statusbar.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let bar: Statusbar = Statusbar::new(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `include::voc_treeview::VocTreeView` [INFO] [stderr] --> src/include/voc_treeview.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> VocTreeView { [INFO] [stderr] 24 | | let column_types = [String::static_type()]; [INFO] [stderr] 25 | | let model = TreeStore::new(&column_types); [INFO] [stderr] 26 | | let tree_view = TreeView::new_with_model(&model); [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | impl Default for include::voc_treeview::VocTreeView { [INFO] [stderr] 23 | fn default() -> Self { [INFO] [stderr] 24 | Self::new() [INFO] [stderr] 25 | } [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is used to index `lang_ids` [INFO] [stderr] --> src/include/voc_treeview.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | for index in 0..number_of_columns { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for (index, ) in lang_ids.iter().enumerate().take(number_of_columns) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/include/voc_treeview.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | vocabulary.metadata.language_id_to_name.get(&lang_ids[index]).unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&vocabulary.metadata.language_id_to_name[&lang_ids[index]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `lang_ids`. [INFO] [stderr] --> src/include/voc_treeview.rs:77:30 [INFO] [stderr] | [INFO] [stderr] 77 | for index in 0..number_of_columns { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for in lang_ids.iter().take(number_of_columns) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/include/voc_treeview.rs:78:81 [INFO] [stderr] | [INFO] [stderr] 78 | let item_to_add = meaning.translation.get(&lang_ids[index]).expect( [INFO] [stderr] | _________________________________________________________________________________^ [INFO] [stderr] 79 | | &format!("{} {}", [INFO] [stderr] 80 | | "Not as many translation attributes as lang_ids in the metadata of the JSON.", [INFO] [stderr] 81 | | "Are you sure the JSON is valid?")) [INFO] [stderr] | |____________________________________________________________________^ help: try this: `unwrap_or_else(|| panic!("{} {}", "Not as many translation attributes as lang_ids in the metadata of the JSON."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: method `string_to_ToValue` should have a snake case name such as `string_to_to_value` [INFO] [stderr] --> src/include/voc_treeview.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | / pub fn string_to_ToValue(values_vector: &[String]) -> Vec<>k::ToValue> { [INFO] [stderr] 138 | | let res = values_vector.into_iter().map( [INFO] [stderr] 139 | | |item| item as >k::ToValue [INFO] [stderr] 140 | | ).collect(); [INFO] [stderr] 141 | | // println!("{:?}", DebugPrintableToValue(res)); // this print seems impossible [INFO] [stderr] 142 | | res [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/include/voc_treeview.rs:138:33 [INFO] [stderr] | [INFO] [stderr] 138 | let res = values_vector.into_iter().map( [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/csv_reading_and_writing.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | writer.encode(row).ok().expect("CSV writer error"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/csv_reading_and_writing.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | writer.encode(row).ok().expect("CSV writer error"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 18s [INFO] running `"docker" "inspect" "404ed2b29b290b9538a30459a2466a5483895e60c5accd1f3214cf6eff5bad39"` [INFO] running `"docker" "rm" "-f" "404ed2b29b290b9538a30459a2466a5483895e60c5accd1f3214cf6eff5bad39"` [INFO] [stdout] 404ed2b29b290b9538a30459a2466a5483895e60c5accd1f3214cf6eff5bad39