[INFO] updating cached repository Zebradil/rustotpony [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Zebradil/rustotpony [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Zebradil/rustotpony" "work/ex/clippy-test-run/sources/stable/gh/Zebradil/rustotpony"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Zebradil/rustotpony'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Zebradil/rustotpony" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Zebradil/rustotpony"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Zebradil/rustotpony'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 64ab6f441bc53a7a67f3a5ee4d3c4049b46f867b [INFO] sha for GitHub repo Zebradil/rustotpony: 64ab6f441bc53a7a67f3a5ee4d3c4049b46f867b [INFO] validating manifest of Zebradil/rustotpony on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Zebradil/rustotpony on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Zebradil/rustotpony [INFO] finished frobbing Zebradil/rustotpony [INFO] frobbed toml for Zebradil/rustotpony written to work/ex/clippy-test-run/sources/stable/gh/Zebradil/rustotpony/Cargo.toml [INFO] started frobbing Zebradil/rustotpony [INFO] finished frobbing Zebradil/rustotpony [INFO] frobbed toml for Zebradil/rustotpony written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Zebradil/rustotpony/Cargo.toml [INFO] crate Zebradil/rustotpony has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Zebradil/rustotpony against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Zebradil/rustotpony:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93f387cf2db02a7f997b21830a546c9c4d7ee5d4db220c001fd9f5acb15f81d2 [INFO] running `"docker" "start" "-a" "93f387cf2db02a7f997b21830a546c9c4d7ee5d4db220c001fd9f5acb15f81d2"` [INFO] [stderr] Checking dbus v0.2.3 [INFO] [stderr] Checking rust-gmp v0.3.2 [INFO] [stderr] Checking rpassword v2.0.0 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Checking ctrlc v3.1.1 [INFO] [stderr] Checking digest-buffer v0.3.1 [INFO] [stderr] Checking hmac v0.1.1 [INFO] [stderr] Checking sha-1 v0.3.4 [INFO] [stderr] Checking sha2 v0.5.3 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking oath v0.10.2 [INFO] [stderr] Checking secret-service v0.4.0 [INFO] [stderr] Checking keyring v0.6.0 [INFO] [stderr] Compiling serde_derive v1.0.66 [INFO] [stderr] Checking rustotpony v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | secret_fn: secret_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secret_fn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | secret_bytes: secret_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secret_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | secret_fn: secret_fn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secret_fn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | secret_bytes: secret_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secret_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | &self.applications.insert(String::from(name), new_app); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.applications.insert(String::from(name), new_app);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | if let Some(_) = self.applications.remove(name) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 60 | | Ok(()) [INFO] [stderr] 61 | | } else { [INFO] [stderr] 62 | | Err(format!( [INFO] [stderr] ... | [INFO] [stderr] 65 | | )) [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________- help: try this: `if self.applications.remove(name).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:79:12 [INFO] [stderr] | [INFO] [stderr] 79 | if self.applications.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.applications.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | &self.database.save_applications(&self.applications); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.database.save_applications(&self.applications);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | / write_buffer [INFO] [stderr] 253 | | .take_read_buffer() [INFO] [stderr] 254 | | .take_remaining() [INFO] [stderr] 255 | | .iter() [INFO] [stderr] 256 | | .map(|&i| i), [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 252 | write_buffer [INFO] [stderr] 253 | .take_read_buffer() [INFO] [stderr] 254 | .take_remaining() [INFO] [stderr] 255 | .iter().cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:286:17 [INFO] [stderr] | [INFO] [stderr] 286 | / write_buffer [INFO] [stderr] 287 | | .take_read_buffer() [INFO] [stderr] 288 | | .take_remaining() [INFO] [stderr] 289 | | .iter() [INFO] [stderr] 290 | | .map(|&i| i), [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 286 | write_buffer [INFO] [stderr] 287 | .take_read_buffer() [INFO] [stderr] 288 | .take_remaining() [INFO] [stderr] 289 | .iter().cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:302:36 [INFO] [stderr] | [INFO] [stderr] 302 | let dir = dirs::home_dir().unwrap_or(PathBuf::from(".")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | &self.applications.insert(String::from(name), new_app); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.applications.insert(String::from(name), new_app);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | if let Some(_) = self.applications.remove(name) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 60 | | Ok(()) [INFO] [stderr] 61 | | } else { [INFO] [stderr] 62 | | Err(format!( [INFO] [stderr] ... | [INFO] [stderr] 65 | | )) [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________- help: try this: `if self.applications.remove(name).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:79:12 [INFO] [stderr] | [INFO] [stderr] 79 | if self.applications.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.applications.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | &self.database.save_applications(&self.applications); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.database.save_applications(&self.applications);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | / write_buffer [INFO] [stderr] 253 | | .take_read_buffer() [INFO] [stderr] 254 | | .take_remaining() [INFO] [stderr] 255 | | .iter() [INFO] [stderr] 256 | | .map(|&i| i), [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 252 | write_buffer [INFO] [stderr] 253 | .take_read_buffer() [INFO] [stderr] 254 | .take_remaining() [INFO] [stderr] 255 | .iter().cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:286:17 [INFO] [stderr] | [INFO] [stderr] 286 | / write_buffer [INFO] [stderr] 287 | | .take_read_buffer() [INFO] [stderr] 288 | | .take_remaining() [INFO] [stderr] 289 | | .iter() [INFO] [stderr] 290 | | .map(|&i| i), [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 286 | write_buffer [INFO] [stderr] 287 | .take_read_buffer() [INFO] [stderr] 288 | .take_remaining() [INFO] [stderr] 289 | .iter().cloned(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:302:36 [INFO] [stderr] | [INFO] [stderr] 302 | let dir = dirs::home_dir().unwrap_or(PathBuf::from(".")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/totp.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | return rpassword::prompt_password_stdout("Enter your database pass: ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rpassword::prompt_password_stdout("Enter your database pass: ").unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/totp.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | return rpassword::prompt_password_stdout("Enter your database pass: ").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rpassword::prompt_password_stdout("Enter your database pass: ").unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `show_application` [INFO] [stderr] --> src/bin/totp.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | fn show_application(name: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/totp.rs:123:37 [INFO] [stderr] | [INFO] [stderr] 123 | let home = dirs::home_dir().unwrap_or(PathBuf::from(".")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/bin/totp.rs:139:45 [INFO] [stderr] | [INFO] [stderr] 139 | let mut keys: Vec = apps.keys().map(|key| key.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `apps.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bin/totp.rs:164:48 [INFO] [stderr] | [INFO] [stderr] 164 | since_the_epoch.as_secs() * 1000 + since_the_epoch.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_the_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/bin/totp.rs:182:33 [INFO] [stderr] | [INFO] [stderr] 182 | for (_, application) in apps { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 182 | for application in apps.values() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/totp.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/totp.rs:190:18 [INFO] [stderr] | [INFO] [stderr] 190 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/totp.rs:194:18 [INFO] [stderr] | [INFO] [stderr] 194 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: method is never used: `show_application` [INFO] [stderr] --> src/bin/totp.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | fn show_application(name: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/totp.rs:123:37 [INFO] [stderr] | [INFO] [stderr] 123 | let home = dirs::home_dir().unwrap_or(PathBuf::from(".")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/bin/totp.rs:139:45 [INFO] [stderr] | [INFO] [stderr] 139 | let mut keys: Vec = apps.keys().map(|key| key.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `apps.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bin/totp.rs:164:48 [INFO] [stderr] | [INFO] [stderr] 164 | since_the_epoch.as_secs() * 1000 + since_the_epoch.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_the_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/bin/totp.rs:182:33 [INFO] [stderr] | [INFO] [stderr] 182 | for (_, application) in apps { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 182 | for application in apps.values() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/totp.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/totp.rs:190:18 [INFO] [stderr] | [INFO] [stderr] 190 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/bin/totp.rs:194:18 [INFO] [stderr] | [INFO] [stderr] 194 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.79s [INFO] running `"docker" "inspect" "93f387cf2db02a7f997b21830a546c9c4d7ee5d4db220c001fd9f5acb15f81d2"` [INFO] running `"docker" "rm" "-f" "93f387cf2db02a7f997b21830a546c9c4d7ee5d4db220c001fd9f5acb15f81d2"` [INFO] [stdout] 93f387cf2db02a7f997b21830a546c9c4d7ee5d4db220c001fd9f5acb15f81d2