[INFO] updating cached repository YushiOMOTE/rrpc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/YushiOMOTE/rrpc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/YushiOMOTE/rrpc" "work/ex/clippy-test-run/sources/stable/gh/YushiOMOTE/rrpc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/YushiOMOTE/rrpc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/YushiOMOTE/rrpc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/YushiOMOTE/rrpc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/YushiOMOTE/rrpc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c056b2ff607f9dca8224ed99f869b94c28d9c439 [INFO] sha for GitHub repo YushiOMOTE/rrpc: c056b2ff607f9dca8224ed99f869b94c28d9c439 [INFO] validating manifest of YushiOMOTE/rrpc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of YushiOMOTE/rrpc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing YushiOMOTE/rrpc [INFO] finished frobbing YushiOMOTE/rrpc [INFO] frobbed toml for YushiOMOTE/rrpc written to work/ex/clippy-test-run/sources/stable/gh/YushiOMOTE/rrpc/Cargo.toml [INFO] started frobbing YushiOMOTE/rrpc [INFO] finished frobbing YushiOMOTE/rrpc [INFO] frobbed toml for YushiOMOTE/rrpc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/YushiOMOTE/rrpc/Cargo.toml [INFO] crate YushiOMOTE/rrpc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting YushiOMOTE/rrpc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/YushiOMOTE/rrpc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 570f1aa830d2282e5b1bb258dbd85a8beff3ba59fa513b804d08a385c7b47315 [INFO] running `"docker" "start" "-a" "570f1aa830d2282e5b1bb258dbd85a8beff3ba59fa513b804d08a385c7b47315"` [INFO] [stderr] Compiling pest v2.0.1 [INFO] [stderr] Compiling pest_meta v2.0.3 [INFO] [stderr] Compiling pest_generator v2.0.0 [INFO] [stderr] Compiling pest_derive v2.0.1 [INFO] [stderr] Checking tera v0.11.18 [INFO] [stderr] Checking rrpc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/loader.rs:26:49 [INFO] [stderr] | [INFO] [stderr] 26 | let mut file = File::open(path).map_err(|e| error::file_error(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::file_error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/loader.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | .map_err(|e| error::file_error(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::file_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/loader.rs:37:48 [INFO] [stderr] | [INFO] [stderr] 37 | let path = path.canonicalize().map_err(|e| error::file_error(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::file_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/loader.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | .unwrap_or("".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/resolver.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | .ok_or(error::type_not_found(path)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::type_not_found(path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/resolver.rs:74:47 [INFO] [stderr] | [INFO] [stderr] 74 | debug!("Exited to namespace: {}", _ns.unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:44:45 [INFO] [stderr] | [INFO] [stderr] 44 | RpcParser::parse(Rule::File, s).map_err(|e| error::parse_error(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::parse_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generator.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | ident.into(), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/loader.rs:26:49 [INFO] [stderr] | [INFO] [stderr] 26 | let mut file = File::open(path).map_err(|e| error::file_error(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::file_error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/loader.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | .map_err(|e| error::file_error(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::file_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/loader.rs:37:48 [INFO] [stderr] | [INFO] [stderr] 37 | let path = path.canonicalize().map_err(|e| error::file_error(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::file_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/loader.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | .unwrap_or("".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/generator.rs:318:13 [INFO] [stderr] | [INFO] [stderr] 318 | r.unwrap_or(Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `r.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lang/mod.rs:80:10 [INFO] [stderr] | [INFO] [stderr] 80 | .ok_or(error::generator_not_found(key)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::generator_not_found(key))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lang/mod.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / LANG_GENERATORS [INFO] [stderr] 76 | | .lock() [INFO] [stderr] 77 | | .unwrap() [INFO] [stderr] 78 | | .get(key) [INFO] [stderr] 79 | | .map(|v| v.clone()) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 75 | LANG_GENERATORS [INFO] [stderr] 76 | .lock() [INFO] [stderr] 77 | .unwrap() [INFO] [stderr] 78 | .get(key).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/render.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | .map_err(|e| error::render_error(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::render_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:6:47 [INFO] [stderr] | [INFO] [stderr] 6 | let cwd = std::env::current_dir().map_err(|e| error::file_error(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::file_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/utils.rs:14:10 [INFO] [stderr] | [INFO] [stderr] 14 | .ok_or(error::file_error("Couldn't determine namespace")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::file_error("Couldn't determine namespace"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:44:53 [INFO] [stderr] | [INFO] [stderr] 44 | let model = serde_json::to_value(model).map_err(|e| error::pack_error(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::pack_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:48:34 [INFO] [stderr] | [INFO] [stderr] 48 | to_string_pretty(&model).unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/resolver.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | .ok_or(error::type_not_found(path)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::type_not_found(path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/resolver.rs:74:47 [INFO] [stderr] | [INFO] [stderr] 74 | debug!("Exited to namespace: {}", _ns.unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:44:45 [INFO] [stderr] | [INFO] [stderr] 44 | RpcParser::parse(Rule::File, s).map_err(|e| error::parse_error(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::parse_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generator.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | ident.into(), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/generator.rs:318:13 [INFO] [stderr] | [INFO] [stderr] 318 | r.unwrap_or(Vec::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `r.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lang/mod.rs:80:10 [INFO] [stderr] | [INFO] [stderr] 80 | .ok_or(error::generator_not_found(key)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::generator_not_found(key))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lang/mod.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / LANG_GENERATORS [INFO] [stderr] 76 | | .lock() [INFO] [stderr] 77 | | .unwrap() [INFO] [stderr] 78 | | .get(key) [INFO] [stderr] 79 | | .map(|v| v.clone()) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 75 | LANG_GENERATORS [INFO] [stderr] 76 | .lock() [INFO] [stderr] 77 | .unwrap() [INFO] [stderr] 78 | .get(key).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/render.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | .map_err(|e| error::render_error(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::render_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:6:47 [INFO] [stderr] | [INFO] [stderr] 6 | let cwd = std::env::current_dir().map_err(|e| error::file_error(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::file_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/utils.rs:14:10 [INFO] [stderr] | [INFO] [stderr] 14 | .ok_or(error::file_error("Couldn't determine namespace")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error::file_error("Couldn't determine namespace"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:44:53 [INFO] [stderr] | [INFO] [stderr] 44 | let model = serde_json::to_value(model).map_err(|e| error::pack_error(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `error::pack_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:48:34 [INFO] [stderr] | [INFO] [stderr] 48 | to_string_pretty(&model).unwrap_or("".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.38s [INFO] running `"docker" "inspect" "570f1aa830d2282e5b1bb258dbd85a8beff3ba59fa513b804d08a385c7b47315"` [INFO] running `"docker" "rm" "-f" "570f1aa830d2282e5b1bb258dbd85a8beff3ba59fa513b804d08a385c7b47315"` [INFO] [stdout] 570f1aa830d2282e5b1bb258dbd85a8beff3ba59fa513b804d08a385c7b47315