[INFO] updating cached repository YushiOMOTE/gbscraper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/YushiOMOTE/gbscraper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/YushiOMOTE/gbscraper" "work/ex/clippy-test-run/sources/stable/gh/YushiOMOTE/gbscraper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/YushiOMOTE/gbscraper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/YushiOMOTE/gbscraper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/YushiOMOTE/gbscraper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/YushiOMOTE/gbscraper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 522b1f5d808a851c10b472930e1ce2899641a18b [INFO] sha for GitHub repo YushiOMOTE/gbscraper: 522b1f5d808a851c10b472930e1ce2899641a18b [INFO] validating manifest of YushiOMOTE/gbscraper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of YushiOMOTE/gbscraper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing YushiOMOTE/gbscraper [INFO] finished frobbing YushiOMOTE/gbscraper [INFO] frobbed toml for YushiOMOTE/gbscraper written to work/ex/clippy-test-run/sources/stable/gh/YushiOMOTE/gbscraper/Cargo.toml [INFO] started frobbing YushiOMOTE/gbscraper [INFO] finished frobbing YushiOMOTE/gbscraper [INFO] frobbed toml for YushiOMOTE/gbscraper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/YushiOMOTE/gbscraper/Cargo.toml [INFO] crate YushiOMOTE/gbscraper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting YushiOMOTE/gbscraper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/YushiOMOTE/gbscraper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3db2e06f96f425bbb4f79b9115afea99c35178734b94c4fac7a6a416f3b2be6 [INFO] running `"docker" "start" "-a" "f3db2e06f96f425bbb4f79b9115afea99c35178734b94c4fac7a6a416f3b2be6"` [INFO] [stderr] Compiling curl-sys v0.4.14 [INFO] [stderr] Checking utf-8 v0.6.0 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking cssparser v0.5.8 [INFO] [stderr] Checking quickersort v2.2.0 [INFO] [stderr] Compiling structopt-derive v0.2.13 [INFO] [stderr] Compiling pest_generator v2.0.0 [INFO] [stderr] Checking tendril v0.2.4 [INFO] [stderr] Compiling string_cache v0.2.29 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Compiling html5ever v0.5.4 [INFO] [stderr] Compiling pest_derive v2.0.1 [INFO] [stderr] Checking structopt v0.2.13 [INFO] [stderr] Checking selectors v0.5.9 [INFO] [stderr] Checking scraper v0.4.0 [INFO] [stderr] Checking curl v0.4.18 [INFO] [stderr] Checking gbscraper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | let z = flag.next().expect("No z flag").as_str().into(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | let n = flag.next().expect("No n flag").as_str().into(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | let h = flag.next().expect("No h flag").as_str().into(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | let c = flag.next().expect("No c flag").as_str().into(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | let z = flag.next().expect("No z flag").as_str().into(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | let n = flag.next().expect("No n flag").as_str().into(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | let h = flag.next().expect("No h flag").as_str().into(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | let c = flag.next().expect("No c flag").as_str().into(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | if s.contains("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:134:32 [INFO] [stderr] | [INFO] [stderr] 134 | let mut nums = s.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:233:14 [INFO] [stderr] | [INFO] [stderr] 233 | .unwrap_or("http://www.pastraiser.com/cpu/gameboy/gameboy_opcodes.html".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "http://www.pastraiser.com/cpu/gameboy/gameboy_opcodes.html".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | if s.contains("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:134:32 [INFO] [stderr] | [INFO] [stderr] 134 | let mut nums = s.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:233:14 [INFO] [stderr] | [INFO] [stderr] 233 | .unwrap_or("http://www.pastraiser.com/cpu/gameboy/gameboy_opcodes.html".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "http://www.pastraiser.com/cpu/gameboy/gameboy_opcodes.html".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.72s [INFO] running `"docker" "inspect" "f3db2e06f96f425bbb4f79b9115afea99c35178734b94c4fac7a6a416f3b2be6"` [INFO] running `"docker" "rm" "-f" "f3db2e06f96f425bbb4f79b9115afea99c35178734b94c4fac7a6a416f3b2be6"` [INFO] [stdout] f3db2e06f96f425bbb4f79b9115afea99c35178734b94c4fac7a6a416f3b2be6