[INFO] updating cached repository Yarikx/rust-renderer
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Yarikx/rust-renderer
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Yarikx/rust-renderer" "work/ex/clippy-test-run/sources/stable/gh/Yarikx/rust-renderer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Yarikx/rust-renderer'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Yarikx/rust-renderer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Yarikx/rust-renderer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Yarikx/rust-renderer'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 58b848a92995024d67d26ff91c5259dfd46e12ee
[INFO] sha for GitHub repo Yarikx/rust-renderer: 58b848a92995024d67d26ff91c5259dfd46e12ee
[INFO] validating manifest of Yarikx/rust-renderer on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Yarikx/rust-renderer on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Yarikx/rust-renderer
[INFO] finished frobbing Yarikx/rust-renderer
[INFO] frobbed toml for Yarikx/rust-renderer written to work/ex/clippy-test-run/sources/stable/gh/Yarikx/rust-renderer/Cargo.toml
[INFO] started frobbing Yarikx/rust-renderer
[INFO] finished frobbing Yarikx/rust-renderer
[INFO] frobbed toml for Yarikx/rust-renderer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Yarikx/rust-renderer/Cargo.toml
[INFO] crate Yarikx/rust-renderer has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Yarikx/rust-renderer against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Yarikx/rust-renderer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 891800fa4c6734da822c1c3e6945b935f02e4f0c20b5dd102e140536bd9c79ff
[INFO] running `"docker" "start" "-a" "891800fa4c6734da822c1c3e6945b935f02e4f0c20b5dd102e140536bd9c79ff"`
[INFO] [stderr]     Checking adler32 v1.0.1
[INFO] [stderr]     Checking num-bigint v0.1.40
[INFO] [stderr]     Checking alga v0.5.2
[INFO] [stderr]     Checking jpeg-decoder v0.1.13
[INFO] [stderr]     Checking deflate v0.7.15
[INFO] [stderr]     Checking num-rational v0.1.39
[INFO] [stderr]     Checking png v0.9.0
[INFO] [stderr]     Checking num v0.1.40
[INFO] [stderr]     Checking image v0.15.0
[INFO] [stderr]     Checking nalgebra v0.12.3
[INFO] [stderr]     Checking renderer v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:79:21
[INFO] [stderr]    |
[INFO] [stderr] 79 |                     ps: ps,
[INFO] [stderr]    |                     ^^^^^^ help: replace it with: `ps`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:80:21
[INFO] [stderr]    |
[INFO] [stderr] 80 |                     vt: vt
[INFO] [stderr]    |                     ^^^^^^ help: replace it with: `vt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:91:16
[INFO] [stderr]    |
[INFO] [stderr] 91 |     Ok(Model { vertices: vertices, faces: faces, vt: vt })
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:91:36
[INFO] [stderr]    |
[INFO] [stderr] 91 |     Ok(Model { vertices: vertices, faces: faces, vt: vt })
[INFO] [stderr]    |                                    ^^^^^^^^^^^^ help: replace it with: `faces`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:91:50
[INFO] [stderr]    |
[INFO] [stderr] 91 |     Ok(Model { vertices: vertices, faces: faces, vt: vt })
[INFO] [stderr]    |                                                  ^^^^^^ help: replace it with: `vt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/render.rs:46:36
[INFO] [stderr]    |
[INFO] [stderr] 46 |         Img { width: w, height: h, imgbuf: imgbuf, zbuf: zbuf }
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: replace it with: `imgbuf`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/render.rs:46:52
[INFO] [stderr]    |
[INFO] [stderr] 46 |         Img { width: w, height: h, imgbuf: imgbuf, zbuf: zbuf }
[INFO] [stderr]    |                                                    ^^^^^^^^^^ help: replace it with: `zbuf`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/main.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |         let y = (vertex.y + 1.0) * h / 2.0;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/main.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let z = (vertex.z + 1.0) * d / 2.0;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:79:21
[INFO] [stderr]    |
[INFO] [stderr] 79 |                     ps: ps,
[INFO] [stderr]    |                     ^^^^^^ help: replace it with: `ps`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:80:21
[INFO] [stderr]    |
[INFO] [stderr] 80 |                     vt: vt
[INFO] [stderr]    |                     ^^^^^^ help: replace it with: `vt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:91:16
[INFO] [stderr]    |
[INFO] [stderr] 91 |     Ok(Model { vertices: vertices, faces: faces, vt: vt })
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:91:36
[INFO] [stderr]    |
[INFO] [stderr] 91 |     Ok(Model { vertices: vertices, faces: faces, vt: vt })
[INFO] [stderr]    |                                    ^^^^^^^^^^^^ help: replace it with: `faces`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:91:50
[INFO] [stderr]    |
[INFO] [stderr] 91 |     Ok(Model { vertices: vertices, faces: faces, vt: vt })
[INFO] [stderr]    |                                                  ^^^^^^ help: replace it with: `vt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/render.rs:46:36
[INFO] [stderr]    |
[INFO] [stderr] 46 |         Img { width: w, height: h, imgbuf: imgbuf, zbuf: zbuf }
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: replace it with: `imgbuf`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/render.rs:46:52
[INFO] [stderr]    |
[INFO] [stderr] 46 |         Img { width: w, height: h, imgbuf: imgbuf, zbuf: zbuf }
[INFO] [stderr]    |                                                    ^^^^^^^^^^ help: replace it with: `zbuf`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/main.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |         let y = (vertex.y + 1.0) * h / 2.0;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/main.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let z = (vertex.z + 1.0) * d / 2.0;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:66:35
[INFO] [stderr]    |
[INFO] [stderr] 66 |                         str.split("/")
[INFO] [stderr]    |                                   ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/parser.rs:103:10
[INFO] [stderr]     |
[INFO] [stderr] 103 |         .ok_or(image::ImageError::from(io::Error::new(io::ErrorKind::NotFound, "no frames found for texture")))?;
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| image::ImageError::from(io::Error::new(io::ErrorKind::NotFound, "no frames found for texture")))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/render.rs:52:22
[INFO] [stderr]    |
[INFO] [stderr] 52 |             .map_err(|e| image::ImageError::from(e))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `image::ImageError::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/render.rs:59:22
[INFO] [stderr]    |
[INFO] [stderr] 59 |             .map_err(|e| image::ImageError::from(e))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `image::ImageError::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]    --> src/render.rs:88:5
[INFO] [stderr]     |
[INFO] [stderr] 88  | /     pub fn triangle(&mut self, t0: Vec3i, t1: Vec3i, t2: Vec3i,
[INFO] [stderr] 89  | |                     uv0: Vec2u, uv1: Vec2u, uv2: Vec2u,
[INFO] [stderr] 90  | |                     texture: &Texture, intensity: f32) {
[INFO] [stderr] 91  | |         if t0.y == t1.y && t1.y == t2.y { return; }
[INFO] [stderr] ...   |
[INFO] [stderr] 160 | |         }
[INFO] [stderr] 161 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/render.rs:141:22
[INFO] [stderr]     |
[INFO] [stderr] 141 |             for x in a.x as i32..b.x as i32 + 1 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `a.x as i32..=b.x as i32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/render.rs:142:30
[INFO] [stderr]     |
[INFO] [stderr] 142 |                 let phi = if b.x == a.x {
[INFO] [stderr]     |                              ^^^^^^^^^^ help: consider comparing them within some error: `(b.x - a.x).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/render.rs:142:30
[INFO] [stderr]     |
[INFO] [stderr] 142 |                 let phi = if b.x == a.x {
[INFO] [stderr]     |                              ^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/render.rs:156:35
[INFO] [stderr]     |
[INFO] [stderr] 156 |                         .map(|c| (c as f32 * intensity) as u8);
[INFO] [stderr]     |                                   ^^^^^^^^ help: try: `f32::from(c)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:27:18
[INFO] [stderr]    |
[INFO] [stderr] 27 |         .map_err(|e| image::ImageError::from(e))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `image::ImageError::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let ref vs = model.vertices;
[INFO] [stderr]    |     ----^^^^^^------------------ help: try: `let vs = &model.vertices;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let ref vt = model.vt;
[INFO] [stderr]    |     ----^^^^^^------------ help: try: `let vt = &model.vt;`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:67:17
[INFO] [stderr]    |
[INFO] [stderr] 67 |             let ref vertex = vs[face.ps[i]];
[INFO] [stderr]    |             ----^^^^^^^^^^------------------ help: try: `let vertex = &vs[face.ps[i]];`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:79:13
[INFO] [stderr]    |
[INFO] [stderr] 79 |         let ref x1: Vector3<f32> = world_coords[2] - world_coords[0];
[INFO] [stderr]    |         ----^^^^^^--------------------------------------------------- help: try: `let x1: &Vector3<f32> = &(world_coords[2] - world_coords[0]);`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:80:13
[INFO] [stderr]    |
[INFO] [stderr] 80 |         let ref x2: Vector3<f32> = world_coords[1] - world_coords[0];
[INFO] [stderr]    |         ----^^^^^^--------------------------------------------------- help: try: `let x2: &Vector3<f32> = &(world_coords[1] - world_coords[0]);`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |         let ref light_dir = Vector3::new(-0., 0., -1.).normalize();
[INFO] [stderr]    |         ----^^^^^^^^^^^^^------------------------------------------ help: try: `let light_dir = &Vector3::new(-0., 0., -1.).normalize();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `renderer`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:66:35
[INFO] [stderr]    |
[INFO] [stderr] 66 |                         str.split("/")
[INFO] [stderr]    |                                   ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/parser.rs:103:10
[INFO] [stderr]     |
[INFO] [stderr] 103 |         .ok_or(image::ImageError::from(io::Error::new(io::ErrorKind::NotFound, "no frames found for texture")))?;
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| image::ImageError::from(io::Error::new(io::ErrorKind::NotFound, "no frames found for texture")))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/render.rs:52:22
[INFO] [stderr]    |
[INFO] [stderr] 52 |             .map_err(|e| image::ImageError::from(e))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `image::ImageError::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/render.rs:59:22
[INFO] [stderr]    |
[INFO] [stderr] 59 |             .map_err(|e| image::ImageError::from(e))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `image::ImageError::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]    --> src/render.rs:88:5
[INFO] [stderr]     |
[INFO] [stderr] 88  | /     pub fn triangle(&mut self, t0: Vec3i, t1: Vec3i, t2: Vec3i,
[INFO] [stderr] 89  | |                     uv0: Vec2u, uv1: Vec2u, uv2: Vec2u,
[INFO] [stderr] 90  | |                     texture: &Texture, intensity: f32) {
[INFO] [stderr] 91  | |         if t0.y == t1.y && t1.y == t2.y { return; }
[INFO] [stderr] ...   |
[INFO] [stderr] 160 | |         }
[INFO] [stderr] 161 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/render.rs:141:22
[INFO] [stderr]     |
[INFO] [stderr] 141 |             for x in a.x as i32..b.x as i32 + 1 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `a.x as i32..=b.x as i32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/render.rs:142:30
[INFO] [stderr]     |
[INFO] [stderr] 142 |                 let phi = if b.x == a.x {
[INFO] [stderr]     |                              ^^^^^^^^^^ help: consider comparing them within some error: `(b.x - a.x).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/render.rs:142:30
[INFO] [stderr]     |
[INFO] [stderr] 142 |                 let phi = if b.x == a.x {
[INFO] [stderr]     |                              ^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]    --> src/render.rs:156:35
[INFO] [stderr]     |
[INFO] [stderr] 156 |                         .map(|c| (c as f32 * intensity) as u8);
[INFO] [stderr]     |                                   ^^^^^^^^ help: try: `f32::from(c)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:27:18
[INFO] [stderr]    |
[INFO] [stderr] 27 |         .map_err(|e| image::ImageError::from(e))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `image::ImageError::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let ref vs = model.vertices;
[INFO] [stderr]    |     ----^^^^^^------------------ help: try: `let vs = &model.vertices;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let ref vt = model.vt;
[INFO] [stderr]    |     ----^^^^^^------------ help: try: `let vt = &model.vt;`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:67:17
[INFO] [stderr]    |
[INFO] [stderr] 67 |             let ref vertex = vs[face.ps[i]];
[INFO] [stderr]    |             ----^^^^^^^^^^------------------ help: try: `let vertex = &vs[face.ps[i]];`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:79:13
[INFO] [stderr]    |
[INFO] [stderr] 79 |         let ref x1: Vector3<f32> = world_coords[2] - world_coords[0];
[INFO] [stderr]    |         ----^^^^^^--------------------------------------------------- help: try: `let x1: &Vector3<f32> = &(world_coords[2] - world_coords[0]);`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:80:13
[INFO] [stderr]    |
[INFO] [stderr] 80 |         let ref x2: Vector3<f32> = world_coords[1] - world_coords[0];
[INFO] [stderr]    |         ----^^^^^^--------------------------------------------------- help: try: `let x2: &Vector3<f32> = &(world_coords[1] - world_coords[0]);`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |         let ref light_dir = Vector3::new(-0., 0., -1.).normalize();
[INFO] [stderr]    |         ----^^^^^^^^^^^^^------------------------------------------ help: try: `let light_dir = &Vector3::new(-0., 0., -1.).normalize();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `renderer`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "891800fa4c6734da822c1c3e6945b935f02e4f0c20b5dd102e140536bd9c79ff"`
[INFO] running `"docker" "rm" "-f" "891800fa4c6734da822c1c3e6945b935f02e4f0c20b5dd102e140536bd9c79ff"`
[INFO] [stdout] 891800fa4c6734da822c1c3e6945b935f02e4f0c20b5dd102e140536bd9c79ff