[INFO] updating cached repository XuShaohua/apt-file [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/XuShaohua/apt-file [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/XuShaohua/apt-file" "work/ex/clippy-test-run/sources/stable/gh/XuShaohua/apt-file"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/XuShaohua/apt-file'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/XuShaohua/apt-file" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/XuShaohua/apt-file"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/XuShaohua/apt-file'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 49bdff7181ebfea41b4f99fb7080f66e8dfa2bee [INFO] sha for GitHub repo XuShaohua/apt-file: 49bdff7181ebfea41b4f99fb7080f66e8dfa2bee [INFO] validating manifest of XuShaohua/apt-file on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of XuShaohua/apt-file on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing XuShaohua/apt-file [INFO] finished frobbing XuShaohua/apt-file [INFO] frobbed toml for XuShaohua/apt-file written to work/ex/clippy-test-run/sources/stable/gh/XuShaohua/apt-file/Cargo.toml [INFO] started frobbing XuShaohua/apt-file [INFO] finished frobbing XuShaohua/apt-file [INFO] frobbed toml for XuShaohua/apt-file written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/XuShaohua/apt-file/Cargo.toml [INFO] crate XuShaohua/apt-file has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting XuShaohua/apt-file against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/XuShaohua/apt-file:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1587870de849cb460bf5b026f87025babadb7b6c1ab587a4387fa0bde477c21c [INFO] running `"docker" "start" "-a" "1587870de849cb460bf5b026f87025babadb7b6c1ab587a4387fa0bde477c21c"` [INFO] [stderr] Compiling curl-sys v0.4.5 [INFO] [stderr] Checking socket2 v0.3.5 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking curl v0.4.12 [INFO] [stderr] Checking apt-file-rs v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | const SOURCE_PKG: &'static str = "https://mirrors.ustc.edu.cn/debian/dists/unstable/main/Contents-source.gz"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | const BINARY_PKG: &'static str = "http://mirrors.ustc.edu.cn/debian/dists/unstable/main/Contents-amd64.gz"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(DB { conn }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DB { conn })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | return Err(Error::ExecuteReturnedResults); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::ExecuteReturnedResults)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | return Ok(fd.write(data).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(fd.write(data).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | return self.conn.transaction(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.conn.transaction()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:42:40 [INFO] [stderr] | [INFO] [stderr] 42 | let mut path = if let Some(home) = std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:221:29 [INFO] [stderr] | [INFO] [stderr] 221 | for char in file.chars().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `file.chars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:234:29 [INFO] [stderr] | [INFO] [stderr] 234 | for char in cap.chars().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `cap.chars()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:280:29 [INFO] [stderr] | [INFO] [stderr] 280 | for char in cap.chars().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `cap.chars()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:283:21 [INFO] [stderr] | [INFO] [stderr] 283 | / match char { [INFO] [stderr] 284 | | ',' => { [INFO] [stderr] 285 | | // Separator between two apps. [INFO] [stderr] 286 | | app_end = pos - 1; [INFO] [stderr] ... | [INFO] [stderr] 292 | | _ => {} [INFO] [stderr] 293 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 283 | if let ',' = char { [INFO] [stderr] 284 | // Separator between two apps. [INFO] [stderr] 285 | app_end = pos - 1; [INFO] [stderr] 286 | // Now insert last app record. [INFO] [stderr] 287 | let app = &cap[app_start..app_end]; [INFO] [stderr] 288 | DB::insert_src_record(&db_tx, &file, app); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | const SOURCE_PKG: &'static str = "https://mirrors.ustc.edu.cn/debian/dists/unstable/main/Contents-source.gz"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | const BINARY_PKG: &'static str = "http://mirrors.ustc.edu.cn/debian/dists/unstable/main/Contents-amd64.gz"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(DB { conn }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(DB { conn })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | return Err(Error::ExecuteReturnedResults); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::ExecuteReturnedResults)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | return Ok(fd.write(data).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(fd.write(data).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | return self.conn.transaction(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.conn.transaction()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:42:40 [INFO] [stderr] | [INFO] [stderr] 42 | let mut path = if let Some(home) = std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:221:29 [INFO] [stderr] | [INFO] [stderr] 221 | for char in file.chars().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `file.chars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:234:29 [INFO] [stderr] | [INFO] [stderr] 234 | for char in cap.chars().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `cap.chars()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:280:29 [INFO] [stderr] | [INFO] [stderr] 280 | for char in cap.chars().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `cap.chars()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:283:21 [INFO] [stderr] | [INFO] [stderr] 283 | / match char { [INFO] [stderr] 284 | | ',' => { [INFO] [stderr] 285 | | // Separator between two apps. [INFO] [stderr] 286 | | app_end = pos - 1; [INFO] [stderr] ... | [INFO] [stderr] 292 | | _ => {} [INFO] [stderr] 293 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 283 | if let ',' = char { [INFO] [stderr] 284 | // Separator between two apps. [INFO] [stderr] 285 | app_end = pos - 1; [INFO] [stderr] 286 | // Now insert last app record. [INFO] [stderr] 287 | let app = &cap[app_start..app_end]; [INFO] [stderr] 288 | DB::insert_src_record(&db_tx, &file, app); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 35s [INFO] running `"docker" "inspect" "1587870de849cb460bf5b026f87025babadb7b6c1ab587a4387fa0bde477c21c"` [INFO] running `"docker" "rm" "-f" "1587870de849cb460bf5b026f87025babadb7b6c1ab587a4387fa0bde477c21c"` [INFO] [stdout] 1587870de849cb460bf5b026f87025babadb7b6c1ab587a4387fa0bde477c21c