[INFO] updating cached repository Xinnx/webserv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Xinnx/webserv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Xinnx/webserv" "work/ex/clippy-test-run/sources/stable/gh/Xinnx/webserv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Xinnx/webserv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Xinnx/webserv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Xinnx/webserv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Xinnx/webserv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3680a67cab00f15fc9e20c4a41f2f5bf5cd5cd05 [INFO] sha for GitHub repo Xinnx/webserv: 3680a67cab00f15fc9e20c4a41f2f5bf5cd5cd05 [INFO] validating manifest of Xinnx/webserv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Xinnx/webserv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Xinnx/webserv [INFO] finished frobbing Xinnx/webserv [INFO] frobbed toml for Xinnx/webserv written to work/ex/clippy-test-run/sources/stable/gh/Xinnx/webserv/Cargo.toml [INFO] started frobbing Xinnx/webserv [INFO] finished frobbing Xinnx/webserv [INFO] frobbed toml for Xinnx/webserv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Xinnx/webserv/Cargo.toml [INFO] crate Xinnx/webserv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Xinnx/webserv against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Xinnx/webserv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2c4d89c06333bf0862b01308d8b7b9039fb40a0a7890c204f51fce41a20018dd [INFO] running `"docker" "start" "-a" "2c4d89c06333bf0862b01308d8b7b9039fb40a0a7890c204f51fce41a20018dd"` [INFO] [stderr] Checking webserv v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | / return Ok(Box::new(HttpRequest::new( [INFO] [stderr] 94 | | HttpMethod::GET, [INFO] [stderr] 95 | | uri_path, [INFO] [stderr] 96 | | ::HTTP_PROTO_VERSION, [INFO] [stderr] 97 | | None, [INFO] [stderr] 98 | | ))); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 93 | Ok(Box::new(HttpRequest::new( [INFO] [stderr] 94 | HttpMethod::GET, [INFO] [stderr] 95 | uri_path, [INFO] [stderr] 96 | ::HTTP_PROTO_VERSION, [INFO] [stderr] 97 | None, [INFO] [stderr] 98 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | return Err(HttpStatusCode::BadRequest); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::BadRequest)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::PathBuf` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::path::PathBuf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/http/mod.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | fn try_file(path: PathBuf) { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `try_file` [INFO] [stderr] --> src/http/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | fn try_file(path: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/http/mod.rs:101:49 [INFO] [stderr] | [INFO] [stderr] 101 | } else if request.starts_with("UPDATE") { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 102 | | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] 103 | | } else if request.starts_with("DELETE") { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/http/mod.rs:99:47 [INFO] [stderr] | [INFO] [stderr] 99 | } else if request.starts_with("POST") { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 100 | | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] 101 | | } else if request.starts_with("UPDATE") { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | stream.write(response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | stream.write(response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `webserv`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | / return Ok(Box::new(HttpRequest::new( [INFO] [stderr] 94 | | HttpMethod::GET, [INFO] [stderr] 95 | | uri_path, [INFO] [stderr] 96 | | ::HTTP_PROTO_VERSION, [INFO] [stderr] 97 | | None, [INFO] [stderr] 98 | | ))); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 93 | Ok(Box::new(HttpRequest::new( [INFO] [stderr] 94 | HttpMethod::GET, [INFO] [stderr] 95 | uri_path, [INFO] [stderr] 96 | ::HTTP_PROTO_VERSION, [INFO] [stderr] 97 | None, [INFO] [stderr] 98 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::NotImplemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http/mod.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | return Err(HttpStatusCode::BadRequest); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(HttpStatusCode::BadRequest)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::PathBuf` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::path::PathBuf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/http/mod.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | fn try_file(path: PathBuf) { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `try_file` [INFO] [stderr] --> src/http/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | fn try_file(path: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/http/mod.rs:101:49 [INFO] [stderr] | [INFO] [stderr] 101 | } else if request.starts_with("UPDATE") { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 102 | | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] 103 | | } else if request.starts_with("DELETE") { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/http/mod.rs:99:47 [INFO] [stderr] | [INFO] [stderr] 99 | } else if request.starts_with("POST") { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 100 | | return Err(HttpStatusCode::NotImplemented); [INFO] [stderr] 101 | | } else if request.starts_with("UPDATE") { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | stream.write(response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | stream.write(response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `webserv`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2c4d89c06333bf0862b01308d8b7b9039fb40a0a7890c204f51fce41a20018dd"` [INFO] running `"docker" "rm" "-f" "2c4d89c06333bf0862b01308d8b7b9039fb40a0a7890c204f51fce41a20018dd"` [INFO] [stdout] 2c4d89c06333bf0862b01308d8b7b9039fb40a0a7890c204f51fce41a20018dd