[INFO] updating cached repository XavierT/cubicle [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/XavierT/cubicle [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/XavierT/cubicle" "work/ex/clippy-test-run/sources/stable/gh/XavierT/cubicle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/XavierT/cubicle'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/XavierT/cubicle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/XavierT/cubicle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/XavierT/cubicle'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f046a145fb5c239578cde11b5efab4eb2e027742 [INFO] sha for GitHub repo XavierT/cubicle: f046a145fb5c239578cde11b5efab4eb2e027742 [INFO] validating manifest of XavierT/cubicle on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of XavierT/cubicle on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing XavierT/cubicle [INFO] finished frobbing XavierT/cubicle [INFO] frobbed toml for XavierT/cubicle written to work/ex/clippy-test-run/sources/stable/gh/XavierT/cubicle/Cargo.toml [INFO] started frobbing XavierT/cubicle [INFO] finished frobbing XavierT/cubicle [INFO] frobbed toml for XavierT/cubicle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/XavierT/cubicle/Cargo.toml [INFO] crate XavierT/cubicle has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting XavierT/cubicle against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/XavierT/cubicle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8f7136adb37a29874046820b279545237551609a6bfa22e9a6ed84ac52182936 [INFO] running `"docker" "start" "-a" "8f7136adb37a29874046820b279545237551609a6bfa22e9a6ed84ac52182936"` [INFO] [stderr] Checking cubicle v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | number [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:116:22 [INFO] [stderr] | [INFO] [stderr] 116 | let number = match self.people { [INFO] [stderr] | ______________________^ [INFO] [stderr] 117 | | Some(ref x) => x.len() as u64, [INFO] [stderr] 118 | | None => 0, [INFO] [stderr] 119 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | number [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | let number = match self.office { [INFO] [stderr] | ______________________^ [INFO] [stderr] 126 | | Some(x) => x, [INFO] [stderr] 127 | | None => 0, [INFO] [stderr] 128 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(unused_imports)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused_imports)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / match file.read_to_string(&mut s) { [INFO] [stderr] 56 | | Err(why) => panic!("couldn't read {}: {}", display, why.description()), [INFO] [stderr] 57 | | Ok(_) => {} [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cubicle`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | number [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:116:22 [INFO] [stderr] | [INFO] [stderr] 116 | let number = match self.people { [INFO] [stderr] | ______________________^ [INFO] [stderr] 117 | | Some(ref x) => x.len() as u64, [INFO] [stderr] 118 | | None => 0, [INFO] [stderr] 119 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | number [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | let number = match self.office { [INFO] [stderr] | ______________________^ [INFO] [stderr] 126 | | Some(x) => x, [INFO] [stderr] 127 | | None => 0, [INFO] [stderr] 128 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(unused_imports)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused_imports)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / match file.read_to_string(&mut s) { [INFO] [stderr] 56 | | Err(why) => panic!("couldn't read {}: {}", display, why.description()), [INFO] [stderr] 57 | | Ok(_) => {} [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cubicle`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8f7136adb37a29874046820b279545237551609a6bfa22e9a6ed84ac52182936"` [INFO] running `"docker" "rm" "-f" "8f7136adb37a29874046820b279545237551609a6bfa22e9a6ed84ac52182936"` [INFO] [stdout] 8f7136adb37a29874046820b279545237551609a6bfa22e9a6ed84ac52182936