[INFO] updating cached repository XOSplicer/rust_crypto_challenge
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/XOSplicer/rust_crypto_challenge
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/XOSplicer/rust_crypto_challenge" "work/ex/clippy-test-run/sources/stable/gh/XOSplicer/rust_crypto_challenge"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/XOSplicer/rust_crypto_challenge'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/XOSplicer/rust_crypto_challenge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/XOSplicer/rust_crypto_challenge"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/XOSplicer/rust_crypto_challenge'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7c1ad87a68853b71829a38ada2fa1a06b4331a5d
[INFO] sha for GitHub repo XOSplicer/rust_crypto_challenge: 7c1ad87a68853b71829a38ada2fa1a06b4331a5d
[INFO] validating manifest of XOSplicer/rust_crypto_challenge on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of XOSplicer/rust_crypto_challenge on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing XOSplicer/rust_crypto_challenge
[INFO] finished frobbing XOSplicer/rust_crypto_challenge
[INFO] frobbed toml for XOSplicer/rust_crypto_challenge written to work/ex/clippy-test-run/sources/stable/gh/XOSplicer/rust_crypto_challenge/Cargo.toml
[INFO] started frobbing XOSplicer/rust_crypto_challenge
[INFO] finished frobbing XOSplicer/rust_crypto_challenge
[INFO] frobbed toml for XOSplicer/rust_crypto_challenge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/XOSplicer/rust_crypto_challenge/Cargo.toml
[INFO] crate XOSplicer/rust_crypto_challenge has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting XOSplicer/rust_crypto_challenge against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/XOSplicer/rust_crypto_challenge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bc129e97e5d5432743f222de70d8a409c7cbc2026738767145dec4aa56d63f59
[INFO] running `"docker" "start" "-a" "bc129e97e5d5432743f222de70d8a409c7cbc2026738767145dec4aa56d63f59"`
[INFO] [stderr]     Checking crypto_challenge v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/core.rs:49:7
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let mut vec6bit = Vec::new();
[INFO] [stderr]    |             ----^^^^^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/core.rs:21:2
[INFO] [stderr]    |
[INFO] [stderr] 21 |     pub fn new() -> Hex {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/core.rs:91:2
[INFO] [stderr]    |
[INFO] [stderr] 91 |     pub fn new() -> Base64 {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/core.rs:25:26
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn from_data(data : &Vec<u8>) -> Hex {
[INFO] [stderr]    |                             ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn from_data(data : &[u8]) -> Hex {
[INFO] [stderr]    |                             ^^^^^
[INFO] [stderr] help: change `data.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 26 |         Hex { data: data.to_owned() }
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/core.rs:42:3
[INFO] [stderr]    |
[INFO] [stderr] 42 |           self.data.iter().cloned().map(|c| HEXCHARS.chars()
[INFO] [stderr]    |  _________^
[INFO] [stderr] 43 | |             .nth(c as usize).expect("Invalid Hex value!")).into_iter().collect()
[INFO] [stderr]    | |______________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]    |
[INFO] [stderr] 42 |         self.data.iter().cloned().map(|c| HEXCHARS.chars()
[INFO] [stderr] 43 |             .nth(c as usize).expect("Invalid Hex value!")).collect()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `byte4bit`.
[INFO] [stderr]   --> src/core.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |             for i in 0..6 {
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 64 |             for <item> in &mut byte4bit {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `byte4bit`
[INFO] [stderr]   --> src/core.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |             for i in 0..6 {
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 75 |             for (i, <item>) in byte4bit.iter().enumerate() {
[INFO] [stderr]    |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/core.rs:76:17
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 int24bit += (byte4bit[i] as u32) << (4*i);
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte4bit[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/core.rs:95:26
[INFO] [stderr]    |
[INFO] [stderr] 95 |     pub fn from_data(data : &Vec<u8>) -> Base64 {
[INFO] [stderr]    |                             ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 95 |     pub fn from_data(data : &[u8]) -> Base64 {
[INFO] [stderr]    |                             ^^^^^
[INFO] [stderr] help: change `data.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 96 |         Base64 { data: data.to_owned() }
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/core.rs:112:3
[INFO] [stderr]     |
[INFO] [stderr] 112 |           self.data.iter().cloned().map(|c| BASE64CHARS.chars()
[INFO] [stderr]     |  _________^
[INFO] [stderr] 113 | |             .nth(c as usize).expect("Invalid Base64 value!")).into_iter().collect()
[INFO] [stderr]     | |_________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]     |
[INFO] [stderr] 112 |         self.data.iter().cloned().map(|c| BASE64CHARS.chars()
[INFO] [stderr] 113 |             .nth(c as usize).expect("Invalid Base64 value!")).collect()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/core.rs:49:7
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let mut vec6bit = Vec::new();
[INFO] [stderr]    |             ----^^^^^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/core.rs:21:2
[INFO] [stderr]    |
[INFO] [stderr] 21 |     pub fn new() -> Hex {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/core.rs:91:2
[INFO] [stderr]    |
[INFO] [stderr] 91 |     pub fn new() -> Base64 {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/core.rs:25:26
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn from_data(data : &Vec<u8>) -> Hex {
[INFO] [stderr]    |                             ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn from_data(data : &[u8]) -> Hex {
[INFO] [stderr]    |                             ^^^^^
[INFO] [stderr] help: change `data.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 26 |         Hex { data: data.to_owned() }
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/core.rs:42:3
[INFO] [stderr]    |
[INFO] [stderr] 42 |           self.data.iter().cloned().map(|c| HEXCHARS.chars()
[INFO] [stderr]    |  _________^
[INFO] [stderr] 43 | |             .nth(c as usize).expect("Invalid Hex value!")).into_iter().collect()
[INFO] [stderr]    | |______________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]    |
[INFO] [stderr] 42 |         self.data.iter().cloned().map(|c| HEXCHARS.chars()
[INFO] [stderr] 43 |             .nth(c as usize).expect("Invalid Hex value!")).collect()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `byte4bit`.
[INFO] [stderr]   --> src/core.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |             for i in 0..6 {
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 64 |             for <item> in &mut byte4bit {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `byte4bit`
[INFO] [stderr]   --> src/core.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |             for i in 0..6 {
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 75 |             for (i, <item>) in byte4bit.iter().enumerate() {
[INFO] [stderr]    |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/core.rs:76:17
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 int24bit += (byte4bit[i] as u32) << (4*i);
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(byte4bit[i])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/core.rs:95:26
[INFO] [stderr]    |
[INFO] [stderr] 95 |     pub fn from_data(data : &Vec<u8>) -> Base64 {
[INFO] [stderr]    |                             ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 95 |     pub fn from_data(data : &[u8]) -> Base64 {
[INFO] [stderr]    |                             ^^^^^
[INFO] [stderr] help: change `data.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 96 |         Base64 { data: data.to_owned() }
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/core.rs:112:3
[INFO] [stderr]     |
[INFO] [stderr] 112 |           self.data.iter().cloned().map(|c| BASE64CHARS.chars()
[INFO] [stderr]     |  _________^
[INFO] [stderr] 113 | |             .nth(c as usize).expect("Invalid Base64 value!")).into_iter().collect()
[INFO] [stderr]     | |_________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]     |
[INFO] [stderr] 112 |         self.data.iter().cloned().map(|c| BASE64CHARS.chars()
[INFO] [stderr] 113 |             .nth(c as usize).expect("Invalid Base64 value!")).collect()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.73s
[INFO] running `"docker" "inspect" "bc129e97e5d5432743f222de70d8a409c7cbc2026738767145dec4aa56d63f59"`
[INFO] running `"docker" "rm" "-f" "bc129e97e5d5432743f222de70d8a409c7cbc2026738767145dec4aa56d63f59"`
[INFO] [stdout] bc129e97e5d5432743f222de70d8a409c7cbc2026738767145dec4aa56d63f59