[INFO] updating cached repository XOSplicer/joystick
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/XOSplicer/joystick
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/XOSplicer/joystick" "work/ex/clippy-test-run/sources/stable/gh/XOSplicer/joystick"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/XOSplicer/joystick'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/XOSplicer/joystick" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/XOSplicer/joystick"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/XOSplicer/joystick'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a040f6fd214e089a3ed5fb282f9d4a5ccd67a15d
[INFO] sha for GitHub repo XOSplicer/joystick: a040f6fd214e089a3ed5fb282f9d4a5ccd67a15d
[INFO] validating manifest of XOSplicer/joystick on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of XOSplicer/joystick on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing XOSplicer/joystick
[INFO] finished frobbing XOSplicer/joystick
[INFO] frobbed toml for XOSplicer/joystick written to work/ex/clippy-test-run/sources/stable/gh/XOSplicer/joystick/Cargo.toml
[INFO] started frobbing XOSplicer/joystick
[INFO] finished frobbing XOSplicer/joystick
[INFO] frobbed toml for XOSplicer/joystick written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/XOSplicer/joystick/Cargo.toml
[INFO] crate XOSplicer/joystick has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting XOSplicer/joystick against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/XOSplicer/joystick:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 224fd410793ad90aa76dc01a183680cd619586ef91cdc76a481d617859c54037
[INFO] running `"docker" "start" "-a" "224fd410793ad90aa76dc01a183680cd619586ef91cdc76a481d617859c54037"`
[INFO] [stderr]     Checking term_size v0.2.1
[INFO] [stderr]    Compiling cmake v0.1.20
[INFO] [stderr]     Checking num v0.1.36
[INFO] [stderr]     Checking clap v2.19.3
[INFO] [stderr]    Compiling glfw-sys v3.2.1
[INFO] [stderr]     Checking glfw v0.12.0
[INFO] [stderr]     Checking gamepad_test v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused imports: `Arg`, `SubCommand`
[INFO] [stderr]  --> src/main.rs:5:12
[INFO] [stderr]   |
[INFO] [stderr] 5 | use clap::{Arg, App, SubCommand};
[INFO] [stderr]   |            ^^^       ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/joystick.rs:128:13
[INFO] [stderr]     |
[INFO] [stderr] 128 |             ()
[INFO] [stderr]     |             ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Arg`, `SubCommand`
[INFO] [stderr]  --> src/main.rs:5:12
[INFO] [stderr]   |
[INFO] [stderr] 5 | use clap::{Arg, App, SubCommand};
[INFO] [stderr]   |            ^^^       ^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `on_hold`
[INFO] [stderr]   --> src/joystick.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     on_hold: HashMap<usize, Callback<()>>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `on_hold`
[INFO] [stderr]   --> src/joystick.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     pub fn on_hold(&mut self, button: usize, callback: Callback<()>) -> &mut Self {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/joystick.rs:79:32
[INFO] [stderr]    |
[INFO] [stderr] 79 |         let running = Arc::new(Mutex::new(true));
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/joystick.rs:128:13
[INFO] [stderr]     |
[INFO] [stderr] 128 |             ()
[INFO] [stderr]     |             ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/joystick.rs:97:29
[INFO] [stderr]     |
[INFO] [stderr] 97  | /                             match builder.on_press.get(&diff.1).unwrap_or(&None) {
[INFO] [stderr] 98  | |                                 &Some(ref f) => f(()),
[INFO] [stderr] 99  | |                                 &None => (),
[INFO] [stderr] 100 | |                             };
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 97  |                             match *builder.on_press.get(&diff.1).unwrap_or(&None) {
[INFO] [stderr] 98  |                                 Some(ref f) => f(()),
[INFO] [stderr] 99  |                                 None => (),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/joystick.rs:105:29
[INFO] [stderr]     |
[INFO] [stderr] 105 | /                             match builder.on_release.get(&diff.1).unwrap_or(&None) {
[INFO] [stderr] 106 | |                                 &Some(ref f) => f(()),
[INFO] [stderr] 107 | |                                 &None => (),
[INFO] [stderr] 108 | |                             };
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 105 |                             match *builder.on_release.get(&diff.1).unwrap_or(&None) {
[INFO] [stderr] 106 |                                 Some(ref f) => f(()),
[INFO] [stderr] 107 |                                 None => (),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/joystick.rs:116:28
[INFO] [stderr]     |
[INFO] [stderr] 116 |                         if (diff.0).0 != (diff.0).1 {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `((diff.0).0 - (diff.0).1).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/joystick.rs:116:28
[INFO] [stderr]     |
[INFO] [stderr] 116 |                         if (diff.0).0 != (diff.0).1 {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/joystick.rs:117:29
[INFO] [stderr]     |
[INFO] [stderr] 117 | /                             match builder.on_move.get(&diff.1).unwrap_or(&None) {
[INFO] [stderr] 118 | |                                 &Some(ref f) => f((diff.0).1.clone()),
[INFO] [stderr] 119 | |                                 &None => (),
[INFO] [stderr] 120 | |                             }
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 117 |                             match *builder.on_move.get(&diff.1).unwrap_or(&None) {
[INFO] [stderr] 118 |                                 Some(ref f) => f((diff.0).1.clone()),
[INFO] [stderr] 119 |                                 None => (),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/joystick.rs:118:51
[INFO] [stderr]     |
[INFO] [stderr] 118 |                                 &Some(ref f) => f((diff.0).1.clone()),
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(diff.0).1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/joystick.rs:149:9
[INFO] [stderr]     |
[INFO] [stderr] 149 | /         match self.0.is_present() {
[INFO] [stderr] 150 | |             true => Ok(JoystickData {
[INFO] [stderr] 151 | |                     name: self.0.get_name(),
[INFO] [stderr] 152 | |                     axes: self.0.get_axes(),
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |             false => Err(JoystickError::NotPresent)
[INFO] [stderr] 162 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 149 |         if self.0.is_present() { Ok(JoystickData {
[INFO] [stderr] 150 |         name: self.0.get_name(),
[INFO] [stderr] 151 |         axes: self.0.get_axes(),
[INFO] [stderr] 152 |         buttons: self.0.get_buttons()
[INFO] [stderr] 153 |                         .iter().map(|&x| match x {
[INFO] [stderr] 154 |                             0 => Action::Release,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `gamepad_test`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: field is never used: `on_hold`
[INFO] [stderr]   --> src/joystick.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     on_hold: HashMap<usize, Callback<()>>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `on_hold`
[INFO] [stderr]   --> src/joystick.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     pub fn on_hold(&mut self, button: usize, callback: Callback<()>) -> &mut Self {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/joystick.rs:79:32
[INFO] [stderr]    |
[INFO] [stderr] 79 |         let running = Arc::new(Mutex::new(true));
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/joystick.rs:97:29
[INFO] [stderr]     |
[INFO] [stderr] 97  | /                             match builder.on_press.get(&diff.1).unwrap_or(&None) {
[INFO] [stderr] 98  | |                                 &Some(ref f) => f(()),
[INFO] [stderr] 99  | |                                 &None => (),
[INFO] [stderr] 100 | |                             };
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 97  |                             match *builder.on_press.get(&diff.1).unwrap_or(&None) {
[INFO] [stderr] 98  |                                 Some(ref f) => f(()),
[INFO] [stderr] 99  |                                 None => (),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/joystick.rs:105:29
[INFO] [stderr]     |
[INFO] [stderr] 105 | /                             match builder.on_release.get(&diff.1).unwrap_or(&None) {
[INFO] [stderr] 106 | |                                 &Some(ref f) => f(()),
[INFO] [stderr] 107 | |                                 &None => (),
[INFO] [stderr] 108 | |                             };
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 105 |                             match *builder.on_release.get(&diff.1).unwrap_or(&None) {
[INFO] [stderr] 106 |                                 Some(ref f) => f(()),
[INFO] [stderr] 107 |                                 None => (),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/joystick.rs:116:28
[INFO] [stderr]     |
[INFO] [stderr] 116 |                         if (diff.0).0 != (diff.0).1 {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `((diff.0).0 - (diff.0).1).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/joystick.rs:116:28
[INFO] [stderr]     |
[INFO] [stderr] 116 |                         if (diff.0).0 != (diff.0).1 {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/joystick.rs:117:29
[INFO] [stderr]     |
[INFO] [stderr] 117 | /                             match builder.on_move.get(&diff.1).unwrap_or(&None) {
[INFO] [stderr] 118 | |                                 &Some(ref f) => f((diff.0).1.clone()),
[INFO] [stderr] 119 | |                                 &None => (),
[INFO] [stderr] 120 | |                             }
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 117 |                             match *builder.on_move.get(&diff.1).unwrap_or(&None) {
[INFO] [stderr] 118 |                                 Some(ref f) => f((diff.0).1.clone()),
[INFO] [stderr] 119 |                                 None => (),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/joystick.rs:118:51
[INFO] [stderr]     |
[INFO] [stderr] 118 |                                 &Some(ref f) => f((diff.0).1.clone()),
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(diff.0).1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/joystick.rs:149:9
[INFO] [stderr]     |
[INFO] [stderr] 149 | /         match self.0.is_present() {
[INFO] [stderr] 150 | |             true => Ok(JoystickData {
[INFO] [stderr] 151 | |                     name: self.0.get_name(),
[INFO] [stderr] 152 | |                     axes: self.0.get_axes(),
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |             false => Err(JoystickError::NotPresent)
[INFO] [stderr] 162 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 149 |         if self.0.is_present() { Ok(JoystickData {
[INFO] [stderr] 150 |         name: self.0.get_name(),
[INFO] [stderr] 151 |         axes: self.0.get_axes(),
[INFO] [stderr] 152 |         buttons: self.0.get_buttons()
[INFO] [stderr] 153 |                         .iter().map(|&x| match x {
[INFO] [stderr] 154 |                             0 => Action::Release,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `gamepad_test`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "224fd410793ad90aa76dc01a183680cd619586ef91cdc76a481d617859c54037"`
[INFO] running `"docker" "rm" "-f" "224fd410793ad90aa76dc01a183680cd619586ef91cdc76a481d617859c54037"`
[INFO] [stdout] 224fd410793ad90aa76dc01a183680cd619586ef91cdc76a481d617859c54037