[INFO] updating cached repository Woyten/cg-util [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Woyten/cg-util [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Woyten/cg-util" "work/ex/clippy-test-run/sources/stable/gh/Woyten/cg-util"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Woyten/cg-util'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Woyten/cg-util" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Woyten/cg-util"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Woyten/cg-util'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e3674f29dbf5c14355703e2c23304b2dc0b163c1 [INFO] sha for GitHub repo Woyten/cg-util: e3674f29dbf5c14355703e2c23304b2dc0b163c1 [INFO] validating manifest of Woyten/cg-util on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Woyten/cg-util on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Woyten/cg-util [INFO] finished frobbing Woyten/cg-util [INFO] frobbed toml for Woyten/cg-util written to work/ex/clippy-test-run/sources/stable/gh/Woyten/cg-util/Cargo.toml [INFO] started frobbing Woyten/cg-util [INFO] finished frobbing Woyten/cg-util [INFO] frobbed toml for Woyten/cg-util written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Woyten/cg-util/Cargo.toml [INFO] crate Woyten/cg-util has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Woyten/cg-util against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Woyten/cg-util:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d249961dc99cf7b066a9b28642a48f4cb80f8087860dd520c50fde7a9acd6030 [INFO] running `"docker" "start" "-a" "d249961dc99cf7b066a9b28642a48f4cb80f8087860dd520c50fde7a9acd6030"` [INFO] [stderr] Checking memmap v0.6.1 [INFO] [stderr] Compiling wayland-scanner v0.12.3 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking alga v0.5.2 [INFO] [stderr] Compiling glutin v0.11.0 [INFO] [stderr] Compiling glium v0.19.0 [INFO] [stderr] Checking x11-dl v2.17.1 [INFO] [stderr] Checking wayland-sys v0.12.3 [INFO] [stderr] Compiling wayland-client v0.12.3 [INFO] [stderr] Compiling wayland-protocols v0.12.3 [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Checking wayland-kbd v0.13.0 [INFO] [stderr] Checking wayland-window v0.13.2 [INFO] [stderr] Checking winit v0.9.0 [INFO] [stderr] Checking cg-util v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | primitive_type: primitive_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `primitive_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifold.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifold.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geometry.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | primitive_type: primitive_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `primitive_type` [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/manifold.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | let z = cos_theta; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/manifold.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | let z = cos_theta * thickness; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifold.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manifold.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/manifold.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | let z = cos_theta; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/manifold.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | let z = cos_theta * thickness; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/navigator.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | window_id: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `WindowEvent { event, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/navigator.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | device_id: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CursorMoved { position, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/navigator.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | device_id: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MouseInput { state: ElementState::Pressed, button: MouseButton::Left, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/navigator.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | device_id: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MouseInput { state: ElementState::Released, button: MouseButton::Left, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/navigator.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | device_id: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MouseInput { state: ElementState::Pressed, button: MouseButton::Right, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/navigator.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | device_id: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MouseInput { state: ElementState::Released, button: MouseButton::Right, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/geometry.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn from_manifold<'a, M: Manifold2d>(coordinates: M) -> Geometry { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/navigator.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | window_id: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `WindowEvent { event, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/navigator.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | device_id: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CursorMoved { position, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/navigator.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | device_id: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MouseInput { state: ElementState::Pressed, button: MouseButton::Left, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/navigator.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | device_id: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MouseInput { state: ElementState::Released, button: MouseButton::Left, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/navigator.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | device_id: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MouseInput { state: ElementState::Pressed, button: MouseButton::Right, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/navigator.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | device_id: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MouseInput { state: ElementState::Released, button: MouseButton::Right, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/navigator.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / match event { [INFO] [stderr] 47 | | Event::WindowEvent { [INFO] [stderr] 48 | | window_id: _, [INFO] [stderr] 49 | | event, [INFO] [stderr] ... | [INFO] [stderr] 77 | | _ => {} [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | if let Event::WindowEvent { [INFO] [stderr] 47 | window_id: _, [INFO] [stderr] 48 | event, [INFO] [stderr] 49 | } = event { match event { [INFO] [stderr] 50 | WindowEvent::CursorMoved { [INFO] [stderr] 51 | device_id: _, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shaders.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | -> Cons<'a, Cons<'a, Cons<'a, Cons<'a, Nil, [[f32; 4]; 4]>, [[f32; 3]; 3]>, [f32; 3]>, [f32; 3]> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shaders.rs:26:35 [INFO] [stderr] | [INFO] [stderr] 26 | -> Cons<'a, Cons<'a, Cons<'a, Cons<'a, Nil, [[f32; 4]; 4]>, [[f32; 3]; 3]>, [f32; 3]>, &Texture2d> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/geometry.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn from_manifold<'a, M: Manifold2d>(coordinates: M) -> Geometry { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/navigator.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / match event { [INFO] [stderr] 47 | | Event::WindowEvent { [INFO] [stderr] 48 | | window_id: _, [INFO] [stderr] 49 | | event, [INFO] [stderr] ... | [INFO] [stderr] 77 | | _ => {} [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | if let Event::WindowEvent { [INFO] [stderr] 47 | window_id: _, [INFO] [stderr] 48 | event, [INFO] [stderr] 49 | } = event { match event { [INFO] [stderr] 50 | WindowEvent::CursorMoved { [INFO] [stderr] 51 | device_id: _, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shaders.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | -> Cons<'a, Cons<'a, Cons<'a, Cons<'a, Nil, [[f32; 4]; 4]>, [[f32; 3]; 3]>, [f32; 3]>, [f32; 3]> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shaders.rs:26:35 [INFO] [stderr] | [INFO] [stderr] 26 | -> Cons<'a, Cons<'a, Cons<'a, Cons<'a, Nil, [[f32; 4]; 4]>, [[f32; 3]; 3]>, [f32; 3]>, &Texture2d> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 21s [INFO] running `"docker" "inspect" "d249961dc99cf7b066a9b28642a48f4cb80f8087860dd520c50fde7a9acd6030"` [INFO] running `"docker" "rm" "-f" "d249961dc99cf7b066a9b28642a48f4cb80f8087860dd520c50fde7a9acd6030"` [INFO] [stdout] d249961dc99cf7b066a9b28642a48f4cb80f8087860dd520c50fde7a9acd6030