[INFO] updating cached repository Wowo10/rust_piston_tetris [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Wowo10/rust_piston_tetris [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Wowo10/rust_piston_tetris" "work/ex/clippy-test-run/sources/stable/gh/Wowo10/rust_piston_tetris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Wowo10/rust_piston_tetris'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Wowo10/rust_piston_tetris" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Wowo10/rust_piston_tetris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Wowo10/rust_piston_tetris'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7af1805c281ae3487149f8ec3df2978281b2b6e7 [INFO] sha for GitHub repo Wowo10/rust_piston_tetris: 7af1805c281ae3487149f8ec3df2978281b2b6e7 [INFO] validating manifest of Wowo10/rust_piston_tetris on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Wowo10/rust_piston_tetris on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Wowo10/rust_piston_tetris [INFO] finished frobbing Wowo10/rust_piston_tetris [INFO] frobbed toml for Wowo10/rust_piston_tetris written to work/ex/clippy-test-run/sources/stable/gh/Wowo10/rust_piston_tetris/Cargo.toml [INFO] started frobbing Wowo10/rust_piston_tetris [INFO] finished frobbing Wowo10/rust_piston_tetris [INFO] frobbed toml for Wowo10/rust_piston_tetris written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Wowo10/rust_piston_tetris/Cargo.toml [INFO] crate Wowo10/rust_piston_tetris has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Wowo10/rust_piston_tetris against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Wowo10/rust_piston_tetris:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d2030b3267e83887332fef053ba50baab7a4be9727dd9bcb4db8bdcf520854d3 [INFO] running `"docker" "start" "-a" "d2030b3267e83887332fef053ba50baab7a4be9727dd9bcb4db8bdcf520854d3"` [INFO] [stderr] Compiling phf v0.7.22 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Checking pistoncore-input v0.17.1 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking gfx_core v0.6.1 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Checking pistoncore-window v0.26.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking pistoncore-event_loop v0.31.4 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling glutin v0.7.4 [INFO] [stderr] Checking piston v0.31.4 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking gfx v0.14.1 [INFO] [stderr] Checking gfx_device_gl v0.13.1 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.1 [INFO] [stderr] Checking piston-gfx_texture v0.22.1 [INFO] [stderr] Checking piston2d-gfx_graphics v0.38.0 [INFO] [stderr] Checking piston_window v0.64.0 [INFO] [stderr] Checking wowo_tetris v0.0.9 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | color_background: color_background, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_background` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | color_border: color_border, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_border` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | color_active: color_active, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_active` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | color_taken: color_taken, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_taken` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | color_background: color_background, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_background` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | color_border: color_border, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_border` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | color_active: color_active, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_active` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | color_taken: color_taken, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_taken` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/app/timers.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | (duration.as_secs() * 1000) + duration.subsec_millis() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/app/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn create( [INFO] [stderr] 36 | | size: u32, [INFO] [stderr] 37 | | width: u8, [INFO] [stderr] 38 | | height: u8, [INFO] [stderr] ... | [INFO] [stderr] 65 | | temp [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | &self.scene.push(v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.scene.push(v);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:94:50 [INFO] [stderr] | [INFO] [stderr] 94 | let square = rectangle::square(0.0, 0.0, self.size as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | (self.settings.offset / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.offset / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | (self.settings.offset / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.offset / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | (self.size - self.settings.offset as u32) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.size - self.settings.offset as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:98:26 [INFO] [stderr] | [INFO] [stderr] 98 | (self.size - self.settings.offset as u32) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.settings.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | let size = (self.size as f64) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `scene` [INFO] [stderr] --> src/app/mod.rs:111:22 [INFO] [stderr] | [INFO] [stderr] 111 | for i in 0..width { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 111 | for (i, ) in scene.iter().enumerate().take(width) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | &self.move_left(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `self.move_left();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | &self.move_right(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.move_right();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | &self.move_down(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `self.move_down();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | &self.drop(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `self.drop();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/app/mod.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | / match &self.scene[(x_pos - 1) as usize][block[1] as usize] { [INFO] [stderr] 189 | | State::Taken => { [INFO] [stderr] 190 | | return false; [INFO] [stderr] 191 | | }, [INFO] [stderr] 192 | | _ => {} [INFO] [stderr] 193 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 188 | if let State::Taken = &self.scene[(x_pos - 1) as usize][block[1] as usize] { [INFO] [stderr] 189 | return false; [INFO] [stderr] 190 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/app/mod.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | / match &self.scene[(x_pos + 1) as usize][block[1] as usize] { [INFO] [stderr] 214 | | State::Taken => { [INFO] [stderr] 215 | | return false; [INFO] [stderr] 216 | | }, [INFO] [stderr] 217 | | _ => {} [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 213 | if let State::Taken = &self.scene[(x_pos + 1) as usize][block[1] as usize] { [INFO] [stderr] 214 | return false; [INFO] [stderr] 215 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/app/mod.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | / match &self.scene[block[0] as usize][(block[1] + 1) as usize] { [INFO] [stderr] 239 | | State::Taken => { [INFO] [stderr] 240 | | return false; [INFO] [stderr] 241 | | }, [INFO] [stderr] 242 | | _ => {} [INFO] [stderr] 243 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 238 | if let State::Taken = &self.scene[block[0] as usize][(block[1] + 1) as usize] { [INFO] [stderr] 239 | return false; [INFO] [stderr] 240 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/app/mod.rs:323:10 [INFO] [stderr] | [INFO] [stderr] 323 | [vector[1] * -1, vector[0]] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/app/mod.rs:355:26 [INFO] [stderr] | [INFO] [stderr] 355 | for k in (1..i + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^ help: use: `(1..=i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/app/mod.rs:365:15 [INFO] [stderr] | [INFO] [stderr] 365 | while self.activeblock.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.activeblock.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/config/mod.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | if data_key == key.to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/config/mod.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | if str_array == "".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:25:44 [INFO] [stderr] | [INFO] [stderr] 25 | WindowSettings::new("WowoTetris", [width as u32 * size, heigth as u32 * size]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:25:65 [INFO] [stderr] | [INFO] [stderr] 25 | WindowSettings::new("WowoTetris", [width as u32 * size, heigth as u32 * size]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(heigth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/app/timers.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | (duration.as_secs() * 1000) + duration.subsec_millis() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/app/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn create( [INFO] [stderr] 36 | | size: u32, [INFO] [stderr] 37 | | width: u8, [INFO] [stderr] 38 | | height: u8, [INFO] [stderr] ... | [INFO] [stderr] 65 | | temp [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | &self.scene.push(v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.scene.push(v);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:94:50 [INFO] [stderr] | [INFO] [stderr] 94 | let square = rectangle::square(0.0, 0.0, self.size as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | (self.settings.offset / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.offset / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | (self.settings.offset / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.offset / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | (self.size - self.settings.offset as u32) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.size - self.settings.offset as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:98:26 [INFO] [stderr] | [INFO] [stderr] 98 | (self.size - self.settings.offset as u32) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.settings.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | let size = (self.size as f64) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `scene` [INFO] [stderr] --> src/app/mod.rs:111:22 [INFO] [stderr] | [INFO] [stderr] 111 | for i in 0..width { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 111 | for (i, ) in scene.iter().enumerate().take(width) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | &self.move_left(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `self.move_left();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | &self.move_right(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.move_right();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | &self.move_down(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `self.move_down();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | &self.drop(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `self.drop();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/app/mod.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | / match &self.scene[(x_pos - 1) as usize][block[1] as usize] { [INFO] [stderr] 189 | | State::Taken => { [INFO] [stderr] 190 | | return false; [INFO] [stderr] 191 | | }, [INFO] [stderr] 192 | | _ => {} [INFO] [stderr] 193 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 188 | if let State::Taken = &self.scene[(x_pos - 1) as usize][block[1] as usize] { [INFO] [stderr] 189 | return false; [INFO] [stderr] 190 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/app/mod.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | / match &self.scene[(x_pos + 1) as usize][block[1] as usize] { [INFO] [stderr] 214 | | State::Taken => { [INFO] [stderr] 215 | | return false; [INFO] [stderr] 216 | | }, [INFO] [stderr] 217 | | _ => {} [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 213 | if let State::Taken = &self.scene[(x_pos + 1) as usize][block[1] as usize] { [INFO] [stderr] 214 | return false; [INFO] [stderr] 215 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/app/mod.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | / match &self.scene[block[0] as usize][(block[1] + 1) as usize] { [INFO] [stderr] 239 | | State::Taken => { [INFO] [stderr] 240 | | return false; [INFO] [stderr] 241 | | }, [INFO] [stderr] 242 | | _ => {} [INFO] [stderr] 243 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 238 | if let State::Taken = &self.scene[block[0] as usize][(block[1] + 1) as usize] { [INFO] [stderr] 239 | return false; [INFO] [stderr] 240 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/app/mod.rs:323:10 [INFO] [stderr] | [INFO] [stderr] 323 | [vector[1] * -1, vector[0]] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/app/mod.rs:355:26 [INFO] [stderr] | [INFO] [stderr] 355 | for k in (1..i + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^ help: use: `(1..=i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/app/mod.rs:365:15 [INFO] [stderr] | [INFO] [stderr] 365 | while self.activeblock.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.activeblock.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/config/mod.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | if data_key == key.to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/config/mod.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | if str_array == "".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:25:44 [INFO] [stderr] | [INFO] [stderr] 25 | WindowSettings::new("WowoTetris", [width as u32 * size, heigth as u32 * size]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:25:65 [INFO] [stderr] | [INFO] [stderr] 25 | WindowSettings::new("WowoTetris", [width as u32 * size, heigth as u32 * size]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(heigth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 31s [INFO] running `"docker" "inspect" "d2030b3267e83887332fef053ba50baab7a4be9727dd9bcb4db8bdcf520854d3"` [INFO] running `"docker" "rm" "-f" "d2030b3267e83887332fef053ba50baab7a4be9727dd9bcb4db8bdcf520854d3"` [INFO] [stdout] d2030b3267e83887332fef053ba50baab7a4be9727dd9bcb4db8bdcf520854d3