[INFO] updating cached repository Wowo10/rust_piston_bomberman [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Wowo10/rust_piston_bomberman [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Wowo10/rust_piston_bomberman" "work/ex/clippy-test-run/sources/stable/gh/Wowo10/rust_piston_bomberman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Wowo10/rust_piston_bomberman'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Wowo10/rust_piston_bomberman" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Wowo10/rust_piston_bomberman"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Wowo10/rust_piston_bomberman'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5c924c79178e64574989413469b469ef307746ff [INFO] sha for GitHub repo Wowo10/rust_piston_bomberman: 5c924c79178e64574989413469b469ef307746ff [INFO] validating manifest of Wowo10/rust_piston_bomberman on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Wowo10/rust_piston_bomberman on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Wowo10/rust_piston_bomberman [INFO] finished frobbing Wowo10/rust_piston_bomberman [INFO] frobbed toml for Wowo10/rust_piston_bomberman written to work/ex/clippy-test-run/sources/stable/gh/Wowo10/rust_piston_bomberman/Cargo.toml [INFO] started frobbing Wowo10/rust_piston_bomberman [INFO] finished frobbing Wowo10/rust_piston_bomberman [INFO] frobbed toml for Wowo10/rust_piston_bomberman written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Wowo10/rust_piston_bomberman/Cargo.toml [INFO] crate Wowo10/rust_piston_bomberman has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Wowo10/rust_piston_bomberman against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Wowo10/rust_piston_bomberman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 454a126b9391eff539ba393fa6c937e81f6d814ba218db216b7e0eb7b921b2e2 [INFO] running `"docker" "start" "-a" "454a126b9391eff539ba393fa6c937e81f6d814ba218db216b7e0eb7b921b2e2"` [INFO] [stderr] Compiling phf_shared v0.7.22 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Checking gfx_core v0.6.1 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Compiling phf v0.7.22 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling glutin v0.7.4 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking gfx v0.14.1 [INFO] [stderr] Checking gfx_device_gl v0.13.1 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.1 [INFO] [stderr] Checking piston-gfx_texture v0.22.1 [INFO] [stderr] Checking piston2d-gfx_graphics v0.38.0 [INFO] [stderr] Checking piston_window v0.64.0 [INFO] [stderr] Checking wowo_bomberman v0.0.9 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/bomb.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/bomb.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | time_limit: time_limit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/bomb.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | player_number: player_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/fire.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/fire.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | time_limit: time_limit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/monster/mod.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/powerup.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/powerup.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | powerup_type: powerup_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `powerup_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | color_background: color_background, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_background` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | color_border: color_border, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_border` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | color_block: color_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | color_obstacle: color_obstacle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_obstacle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | color_player1: color_player1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_player1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | color_player2: color_player2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_player2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | color_bomb: color_bomb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_bomb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | color_fire: color_fire, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_fire` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | color_powerup_bomb: color_powerup_bomb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_powerup_bomb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | color_powerup_fire: color_powerup_fire, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_powerup_fire` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/bomb.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/bomb.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | time_limit: time_limit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/bomb.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | player_number: player_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/fire.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/fire.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | time_limit: time_limit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/monster/mod.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/powerup.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/powerup.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | powerup_type: powerup_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `powerup_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | color_background: color_background, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_background` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | color_border: color_border, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_border` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | color_block: color_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | color_obstacle: color_obstacle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_obstacle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | color_player1: color_player1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_player1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | color_player2: color_player2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_player2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | color_bomb: color_bomb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_bomb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | color_fire: color_fire, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_fire` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | color_powerup_bomb: color_powerup_bomb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_powerup_bomb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | color_powerup_fire: color_powerup_fire, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color_powerup_fire` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app/mod.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/app/mod.rs:454:24 [INFO] [stderr] | [INFO] [stderr] 454 | } else if key == self.players[i].controls.bomb_button { [INFO] [stderr] | ________________________^ [INFO] [stderr] 455 | | if self.players[i].lay_bomb() { [INFO] [stderr] 456 | | if !self.is_bomb_in_position(self.players[i].get_position()) { [INFO] [stderr] 457 | | self.bombs.push(Bomb::create( [INFO] [stderr] ... | [INFO] [stderr] 463 | | }; [INFO] [stderr] 464 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 454 | } else if key == self.players[i].controls.bomb_button && self.players[i].lay_bomb() { [INFO] [stderr] 455 | if !self.is_bomb_in_position(self.players[i].get_position()) { [INFO] [stderr] 456 | self.bombs.push(Bomb::create( [INFO] [stderr] 457 | self.players[i].get_position(), [INFO] [stderr] 458 | i as u8, [INFO] [stderr] 459 | 2.0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/app/mod.rs:455:21 [INFO] [stderr] | [INFO] [stderr] 455 | / if self.players[i].lay_bomb() { [INFO] [stderr] 456 | | if !self.is_bomb_in_position(self.players[i].get_position()) { [INFO] [stderr] 457 | | self.bombs.push(Bomb::create( [INFO] [stderr] 458 | | self.players[i].get_position(), [INFO] [stderr] ... | [INFO] [stderr] 462 | | } [INFO] [stderr] 463 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 455 | if self.players[i].lay_bomb() && !self.is_bomb_in_position(self.players[i].get_position()) { [INFO] [stderr] 456 | self.bombs.push(Bomb::create( [INFO] [stderr] 457 | self.players[i].get_position(), [INFO] [stderr] 458 | i as u8, [INFO] [stderr] 459 | 2.0, [INFO] [stderr] 460 | )); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/app/mod.rs:454:24 [INFO] [stderr] | [INFO] [stderr] 454 | } else if key == self.players[i].controls.bomb_button { [INFO] [stderr] | ________________________^ [INFO] [stderr] 455 | | if self.players[i].lay_bomb() { [INFO] [stderr] 456 | | if !self.is_bomb_in_position(self.players[i].get_position()) { [INFO] [stderr] 457 | | self.bombs.push(Bomb::create( [INFO] [stderr] ... | [INFO] [stderr] 463 | | }; [INFO] [stderr] 464 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 454 | } else if key == self.players[i].controls.bomb_button && self.players[i].lay_bomb() { [INFO] [stderr] 455 | if !self.is_bomb_in_position(self.players[i].get_position()) { [INFO] [stderr] 456 | self.bombs.push(Bomb::create( [INFO] [stderr] 457 | self.players[i].get_position(), [INFO] [stderr] 458 | i as u8, [INFO] [stderr] 459 | 2.0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/app/mod.rs:455:21 [INFO] [stderr] | [INFO] [stderr] 455 | / if self.players[i].lay_bomb() { [INFO] [stderr] 456 | | if !self.is_bomb_in_position(self.players[i].get_position()) { [INFO] [stderr] 457 | | self.bombs.push(Bomb::create( [INFO] [stderr] 458 | | self.players[i].get_position(), [INFO] [stderr] ... | [INFO] [stderr] 462 | | } [INFO] [stderr] 463 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 455 | if self.players[i].lay_bomb() && !self.is_bomb_in_position(self.players[i].get_position()) { [INFO] [stderr] 456 | self.bombs.push(Bomb::create( [INFO] [stderr] 457 | self.players[i].get_position(), [INFO] [stderr] 458 | i as u8, [INFO] [stderr] 459 | 2.0, [INFO] [stderr] 460 | )); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/app/timers.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_fire_range` [INFO] [stderr] --> src/app/player/mod.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn get_fire_range(self) -> u8{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create` [INFO] [stderr] --> src/app/monster/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn create(position: [u8; 2]) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_monster` [INFO] [stderr] --> src/app/mod.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | fn add_monster(&mut self, monster_position: [u8; 2]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/app/config/mod.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | if data_key == key.to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/app/config/mod.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | if str_array == "".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/app/timers.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | (duration.as_secs() * 1000) + duration.subsec_millis() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/app/vector_operations.rs:19:6 [INFO] [stderr] | [INFO] [stderr] 19 | [vector[1] * -1, vector[0]] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/app/mod.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn create( [INFO] [stderr] 53 | | max_width: u32, [INFO] [stderr] 54 | | max_height: u32, [INFO] [stderr] 55 | | color_background: [f32; 4], [INFO] [stderr] ... | [INFO] [stderr] 100 | | temp [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `temp` [INFO] [stderr] --> src/app/mod.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | for j in 0..temp.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 118 | for (j, ) in temp.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | &self.add_player([i as u8, j as u8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.add_player([i as u8, j as u8]);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | &self.scene.push(v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.scene.push(v);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | (self.settings.offset / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.offset / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | (self.settings.offset / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.offset / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | (self.settings.size_x - self.settings.offset as u32) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.size_x - self.settings.offset as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:176:37 [INFO] [stderr] | [INFO] [stderr] 176 | (self.settings.size_x - self.settings.offset as u32) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.settings.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | (self.settings.size_y - self.settings.offset as u32) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.size_y - self.settings.offset as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:177:37 [INFO] [stderr] | [INFO] [stderr] 177 | (self.settings.size_y - self.settings.offset as u32) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.settings.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:180:22 [INFO] [stderr] | [INFO] [stderr] 180 | let size_x = self.settings.size_x as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.size_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:181:22 [INFO] [stderr] | [INFO] [stderr] 181 | let size_y = self.settings.size_y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.size_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `scene` [INFO] [stderr] --> src/app/mod.rs:196:22 [INFO] [stderr] | [INFO] [stderr] 196 | for i in 0..width { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 196 | for (i, ) in scene.iter().enumerate().take(width) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/app/mod.rs:291:18 [INFO] [stderr] | [INFO] [stderr] 291 | for i in 1..(range + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/app/mod.rs:312:18 [INFO] [stderr] | [INFO] [stderr] 312 | for i in 1..(range + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/app/mod.rs:333:18 [INFO] [stderr] | [INFO] [stderr] 333 | for i in 1..(range + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/app/mod.rs:354:18 [INFO] [stderr] | [INFO] [stderr] 354 | for i in 1..(range + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/app/mod.rs:518:12 [INFO] [stderr] | [INFO] [stderr] 518 | if player_pos_x <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using player_pos_x == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/app/mod.rs:544:12 [INFO] [stderr] | [INFO] [stderr] 544 | if player_pos_y <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using player_pos_y == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: static variable `amount` should have an upper case name such as `AMOUNT` [INFO] [stderr] --> src/configuration/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | static mut amount: u8 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wowo_bomberman`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/app/timers.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_fire_range` [INFO] [stderr] --> src/app/player/mod.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn get_fire_range(self) -> u8{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create` [INFO] [stderr] --> src/app/monster/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn create(position: [u8; 2]) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_monster` [INFO] [stderr] --> src/app/mod.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | fn add_monster(&mut self, monster_position: [u8; 2]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/app/config/mod.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | if data_key == key.to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/app/config/mod.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | if str_array == "".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/app/timers.rs:21:39 [INFO] [stderr] | [INFO] [stderr] 21 | (duration.as_secs() * 1000) + duration.subsec_millis() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/app/vector_operations.rs:19:6 [INFO] [stderr] | [INFO] [stderr] 19 | [vector[1] * -1, vector[0]] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/app/mod.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn create( [INFO] [stderr] 53 | | max_width: u32, [INFO] [stderr] 54 | | max_height: u32, [INFO] [stderr] 55 | | color_background: [f32; 4], [INFO] [stderr] ... | [INFO] [stderr] 100 | | temp [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `temp` [INFO] [stderr] --> src/app/mod.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | for j in 0..temp.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 118 | for (j, ) in temp.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | &self.add_player([i as u8, j as u8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.add_player([i as u8, j as u8]);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/app/mod.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | &self.scene.push(v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.scene.push(v);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | (self.settings.offset / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.offset / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | (self.settings.offset / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.offset / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | (self.settings.size_x - self.settings.offset as u32) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.size_x - self.settings.offset as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:176:37 [INFO] [stderr] | [INFO] [stderr] 176 | (self.settings.size_x - self.settings.offset as u32) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.settings.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | (self.settings.size_y - self.settings.offset as u32) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.size_y - self.settings.offset as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:177:37 [INFO] [stderr] | [INFO] [stderr] 177 | (self.settings.size_y - self.settings.offset as u32) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.settings.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:180:22 [INFO] [stderr] | [INFO] [stderr] 180 | let size_x = self.settings.size_x as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.size_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app/mod.rs:181:22 [INFO] [stderr] | [INFO] [stderr] 181 | let size_y = self.settings.size_y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.settings.size_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `scene` [INFO] [stderr] --> src/app/mod.rs:196:22 [INFO] [stderr] | [INFO] [stderr] 196 | for i in 0..width { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 196 | for (i, ) in scene.iter().enumerate().take(width) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/app/mod.rs:291:18 [INFO] [stderr] | [INFO] [stderr] 291 | for i in 1..(range + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/app/mod.rs:312:18 [INFO] [stderr] | [INFO] [stderr] 312 | for i in 1..(range + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/app/mod.rs:333:18 [INFO] [stderr] | [INFO] [stderr] 333 | for i in 1..(range + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/app/mod.rs:354:18 [INFO] [stderr] | [INFO] [stderr] 354 | for i in 1..(range + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/app/mod.rs:518:12 [INFO] [stderr] | [INFO] [stderr] 518 | if player_pos_x <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using player_pos_x == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/app/mod.rs:544:12 [INFO] [stderr] | [INFO] [stderr] 544 | if player_pos_y <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using player_pos_y == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: static variable `amount` should have an upper case name such as `AMOUNT` [INFO] [stderr] --> src/configuration/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | static mut amount: u8 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `wowo_bomberman`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "454a126b9391eff539ba393fa6c937e81f6d814ba218db216b7e0eb7b921b2e2"` [INFO] running `"docker" "rm" "-f" "454a126b9391eff539ba393fa6c937e81f6d814ba218db216b7e0eb7b921b2e2"` [INFO] [stdout] 454a126b9391eff539ba393fa6c937e81f6d814ba218db216b7e0eb7b921b2e2