[INFO] updating cached repository Woutifier/pinger [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Woutifier/pinger [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Woutifier/pinger" "work/ex/clippy-test-run/sources/stable/gh/Woutifier/pinger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Woutifier/pinger'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Woutifier/pinger" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Woutifier/pinger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Woutifier/pinger'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4195023a4a934c3f288f4ec36836ecd8c548285f [INFO] sha for GitHub repo Woutifier/pinger: 4195023a4a934c3f288f4ec36836ecd8c548285f [INFO] validating manifest of Woutifier/pinger on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Woutifier/pinger on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Woutifier/pinger [INFO] finished frobbing Woutifier/pinger [INFO] frobbed toml for Woutifier/pinger written to work/ex/clippy-test-run/sources/stable/gh/Woutifier/pinger/Cargo.toml [INFO] started frobbing Woutifier/pinger [INFO] finished frobbing Woutifier/pinger [INFO] frobbed toml for Woutifier/pinger written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Woutifier/pinger/Cargo.toml [INFO] crate Woutifier/pinger has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Woutifier/pinger against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Woutifier/pinger:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2800057f6dfe809c30600b0b5aaa883e5d61857ea7298ccfaa5473757d279aac [INFO] running `"docker" "start" "-a" "2800057f6dfe809c30600b0b5aaa883e5d61857ea7298ccfaa5473757d279aac"` [INFO] [stderr] Checking winapi v0.2.7 [INFO] [stderr] Checking kernel32-sys v0.2.2 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking pinger v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/mod.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/mod.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tbf/mod.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | rate: rate, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tbf/mod.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | ns_per_packet: ns_per_packet, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ns_per_packet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/mod.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/mod.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tbf/mod.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | rate: rate, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tbf/mod.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | ns_per_packet: ns_per_packet, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ns_per_packet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/net/mod.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | return in6addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `in6addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tbf/mod.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | tbf [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tbf/mod.rs:42:19 [INFO] [stderr] | [INFO] [stderr] 42 | let tbf = TokenBucketFilter { [INFO] [stderr] | ___________________^ [INFO] [stderr] 43 | | enabled: rate > 0, [INFO] [stderr] 44 | | rate: rate, [INFO] [stderr] 45 | | bucket: 0, [INFO] [stderr] 46 | | last_time: precise_time_ns(), [INFO] [stderr] 47 | | ns_per_packet: ns_per_packet, [INFO] [stderr] 48 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tbf/mod.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | ns_per_packet = (1000000000 as u64) / rate; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/net/mod.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | return in6addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `in6addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net/mod.rs:278:26 [INFO] [stderr] | [INFO] [stderr] 278 | let test1 = vec![0b00001000u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0000_1000u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net/mod.rs:279:26 [INFO] [stderr] | [INFO] [stderr] 279 | 0b00000000u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0000_0000u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net/mod.rs:280:26 [INFO] [stderr] | [INFO] [stderr] 280 | 0b00000000u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0000_0000u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net/mod.rs:281:26 [INFO] [stderr] | [INFO] [stderr] 281 | 0b00000000u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0000_0000u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net/mod.rs:282:26 [INFO] [stderr] | [INFO] [stderr] 282 | 0b00000000u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0000_0000u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net/mod.rs:283:26 [INFO] [stderr] | [INFO] [stderr] 283 | 0b00000001u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0000_0001u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net/mod.rs:284:26 [INFO] [stderr] | [INFO] [stderr] 284 | 0b00000000u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0000_0000u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net/mod.rs:285:26 [INFO] [stderr] | [INFO] [stderr] 285 | 0b00001001u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0000_1001u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net/mod.rs:286:26 [INFO] [stderr] | [INFO] [stderr] 286 | 0b01010100u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0101_0100u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net/mod.rs:287:26 [INFO] [stderr] | [INFO] [stderr] 287 | 0b01000101u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0100_0101u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net/mod.rs:288:26 [INFO] [stderr] | [INFO] [stderr] 288 | 0b01010011u8, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0101_0011u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/net/mod.rs:289:26 [INFO] [stderr] | [INFO] [stderr] 289 | 0b01010100u8]; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b0101_0100u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tbf/mod.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | tbf [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tbf/mod.rs:42:19 [INFO] [stderr] | [INFO] [stderr] 42 | let tbf = TokenBucketFilter { [INFO] [stderr] | ___________________^ [INFO] [stderr] 43 | | enabled: rate > 0, [INFO] [stderr] 44 | | rate: rate, [INFO] [stderr] 45 | | bucket: 0, [INFO] [stderr] 46 | | last_time: precise_time_ns(), [INFO] [stderr] 47 | | ns_per_packet: ns_per_packet, [INFO] [stderr] 48 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tbf/mod.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | ns_per_packet = (1000000000 as u64) / rate; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | let header = ((identifier as u32) << 16) | (sequence_number as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(identifier)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:56:52 [INFO] [stderr] | [INFO] [stderr] 56 | let header = ((identifier as u32) << 16) | (sequence_number as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(sequence_number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:85:24 [INFO] [stderr] | [INFO] [stderr] 85 | let word = (buffer[buffer.len() - size] as u16) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buffer[buffer.len() - size])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | (buffer[buffer.len() - size + 1]) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((buffer[buffer.len() - size + 1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:87:25 [INFO] [stderr] | [INFO] [stderr] 87 | checksum += word as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | let header = ((identifier as u32) << 16) | (sequence_number as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(identifier)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:108:52 [INFO] [stderr] | [INFO] [stderr] 108 | let header = ((identifier as u32) << 16) | (sequence_number as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(sequence_number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | let word = (buffer[buffer.len() - size] as u16) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buffer[buffer.len() - size])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:138:24 [INFO] [stderr] | [INFO] [stderr] 138 | (buffer[buffer.len() - size + 1]) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((buffer[buffer.len() - size + 1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:139:25 [INFO] [stderr] | [INFO] [stderr] 139 | checksum += word as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/tbf/mod.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / let mut ns_per_packet = 0; [INFO] [stderr] 39 | | if rate > 0 { [INFO] [stderr] 40 | | ns_per_packet = (1000000000 as u64) / rate; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let ns_per_packet = if rate > 0 { (1000000000 as u64) / rate } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | let header = ((identifier as u32) << 16) | (sequence_number as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(identifier)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:56:52 [INFO] [stderr] | [INFO] [stderr] 56 | let header = ((identifier as u32) << 16) | (sequence_number as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(sequence_number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:85:24 [INFO] [stderr] | [INFO] [stderr] 85 | let word = (buffer[buffer.len() - size] as u16) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buffer[buffer.len() - size])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | (buffer[buffer.len() - size + 1]) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((buffer[buffer.len() - size + 1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:87:25 [INFO] [stderr] | [INFO] [stderr] 87 | checksum += word as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | let header = ((identifier as u32) << 16) | (sequence_number as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(identifier)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:108:52 [INFO] [stderr] | [INFO] [stderr] 108 | let header = ((identifier as u32) << 16) | (sequence_number as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(sequence_number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | let word = (buffer[buffer.len() - size] as u16) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buffer[buffer.len() - size])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:138:24 [INFO] [stderr] | [INFO] [stderr] 138 | (buffer[buffer.len() - size + 1]) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((buffer[buffer.len() - size + 1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/net/mod.rs:139:25 [INFO] [stderr] | [INFO] [stderr] 139 | checksum += word as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/tbf/mod.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / let mut ns_per_packet = 0; [INFO] [stderr] 39 | | if rate > 0 { [INFO] [stderr] 40 | | ns_per_packet = (1000000000 as u64) / rate; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let ns_per_packet = if rate > 0 { (1000000000 as u64) / rate } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.65s [INFO] running `"docker" "inspect" "2800057f6dfe809c30600b0b5aaa883e5d61857ea7298ccfaa5473757d279aac"` [INFO] running `"docker" "rm" "-f" "2800057f6dfe809c30600b0b5aaa883e5d61857ea7298ccfaa5473757d279aac"` [INFO] [stdout] 2800057f6dfe809c30600b0b5aaa883e5d61857ea7298ccfaa5473757d279aac