[INFO] updating cached repository WouterVanmulken/raytracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/WouterVanmulken/raytracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/WouterVanmulken/raytracer" "work/ex/clippy-test-run/sources/stable/gh/WouterVanmulken/raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/WouterVanmulken/raytracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/WouterVanmulken/raytracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WouterVanmulken/raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WouterVanmulken/raytracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cc4e395d3ee70f26ce7cf8a3b92e40f87753d1fa [INFO] sha for GitHub repo WouterVanmulken/raytracer: cc4e395d3ee70f26ce7cf8a3b92e40f87753d1fa [INFO] validating manifest of WouterVanmulken/raytracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of WouterVanmulken/raytracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing WouterVanmulken/raytracer [INFO] finished frobbing WouterVanmulken/raytracer [INFO] frobbed toml for WouterVanmulken/raytracer written to work/ex/clippy-test-run/sources/stable/gh/WouterVanmulken/raytracer/Cargo.toml [INFO] started frobbing WouterVanmulken/raytracer [INFO] finished frobbing WouterVanmulken/raytracer [INFO] frobbed toml for WouterVanmulken/raytracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WouterVanmulken/raytracer/Cargo.toml [INFO] crate WouterVanmulken/raytracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting WouterVanmulken/raytracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/WouterVanmulken/raytracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 185a9fda444476800b4da9388c52f393772a5e2d69f98e3232b87952340c396c [INFO] running `"docker" "start" "-a" "185a9fda444476800b4da9388c52f393772a5e2d69f98e3232b87952340c396c"` [INFO] [stderr] Checking rayon-core v1.3.0 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking untitled v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/data.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod data { [INFO] [stderr] 2 | | pub struct Point { [INFO] [stderr] 3 | | pub x: f64, [INFO] [stderr] 4 | | pub y: f64, [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / return image::Rgba::from_channels((color.red * 255.0) as u8, [INFO] [stderr] 17 | | (color.green * 255.0) as u8, [INFO] [stderr] 18 | | (color.blue * 255.0) as u8, 255); [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | image::Rgba::from_channels((color.red * 255.0) as u8, [INFO] [stderr] 17 | (color.green * 255.0) as u8, [INFO] [stderr] 18 | (color.blue * 255.0) as u8, 255) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:241:37 [INFO] [stderr] | [INFO] [stderr] 241 | let mut shortest: f64 = 300000.0; [INFO] [stderr] | ^^^^^^^^ help: consider: `300_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | let ref mut fout = File::create("test.png").unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------- help: try: `let fout = &mut File::create("test.png").unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:28 [INFO] [stderr] | [INFO] [stderr] 181 | let aspect_ratio = (scene.width as f64) / (scene.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:51 [INFO] [stderr] | [INFO] [stderr] 181 | let aspect_ratio = (scene.width as f64) / (scene.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:183:28 [INFO] [stderr] | [INFO] [stderr] 183 | let sensor_x = ((((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:183:46 [INFO] [stderr] | [INFO] [stderr] 183 | let sensor_x = ((((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:184:33 [INFO] [stderr] | [INFO] [stderr] 184 | let sensor_y = (1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:184:51 [INFO] [stderr] | [INFO] [stderr] 184 | let sensor_y = (1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/data.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod data { [INFO] [stderr] 2 | | pub struct Point { [INFO] [stderr] 3 | | pub x: f64, [INFO] [stderr] 4 | | pub y: f64, [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / return image::Rgba::from_channels((color.red * 255.0) as u8, [INFO] [stderr] 17 | | (color.green * 255.0) as u8, [INFO] [stderr] 18 | | (color.blue * 255.0) as u8, 255); [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | image::Rgba::from_channels((color.red * 255.0) as u8, [INFO] [stderr] 17 | (color.green * 255.0) as u8, [INFO] [stderr] 18 | (color.blue * 255.0) as u8, 255) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:241:37 [INFO] [stderr] | [INFO] [stderr] 241 | let mut shortest: f64 = 300000.0; [INFO] [stderr] | ^^^^^^^^ help: consider: `300_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | let ref mut fout = File::create("test.png").unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------- help: try: `let fout = &mut File::create("test.png").unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:28 [INFO] [stderr] | [INFO] [stderr] 181 | let aspect_ratio = (scene.width as f64) / (scene.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:181:51 [INFO] [stderr] | [INFO] [stderr] 181 | let aspect_ratio = (scene.width as f64) / (scene.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:183:28 [INFO] [stderr] | [INFO] [stderr] 183 | let sensor_x = ((((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:183:46 [INFO] [stderr] | [INFO] [stderr] 183 | let sensor_x = ((((x as f64 + 0.5) / scene.width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:184:33 [INFO] [stderr] | [INFO] [stderr] 184 | let sensor_y = (1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:184:51 [INFO] [stderr] | [INFO] [stderr] 184 | let sensor_y = (1.0 - ((y as f64 + 0.5) / scene.height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scene.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.29s [INFO] running `"docker" "inspect" "185a9fda444476800b4da9388c52f393772a5e2d69f98e3232b87952340c396c"` [INFO] running `"docker" "rm" "-f" "185a9fda444476800b4da9388c52f393772a5e2d69f98e3232b87952340c396c"` [INFO] [stdout] 185a9fda444476800b4da9388c52f393772a5e2d69f98e3232b87952340c396c