[INFO] updating cached repository Wilfred/gameboy_emulator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Wilfred/gameboy_emulator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Wilfred/gameboy_emulator" "work/ex/clippy-test-run/sources/stable/gh/Wilfred/gameboy_emulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Wilfred/gameboy_emulator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Wilfred/gameboy_emulator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Wilfred/gameboy_emulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Wilfred/gameboy_emulator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eb31f039427370ca7a2c6547acab8a4d8cd3c732 [INFO] sha for GitHub repo Wilfred/gameboy_emulator: eb31f039427370ca7a2c6547acab8a4d8cd3c732 [INFO] validating manifest of Wilfred/gameboy_emulator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Wilfred/gameboy_emulator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Wilfred/gameboy_emulator [INFO] finished frobbing Wilfred/gameboy_emulator [INFO] frobbed toml for Wilfred/gameboy_emulator written to work/ex/clippy-test-run/sources/stable/gh/Wilfred/gameboy_emulator/Cargo.toml [INFO] started frobbing Wilfred/gameboy_emulator [INFO] finished frobbing Wilfred/gameboy_emulator [INFO] frobbed toml for Wilfred/gameboy_emulator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Wilfred/gameboy_emulator/Cargo.toml [INFO] crate Wilfred/gameboy_emulator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Wilfred/gameboy_emulator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Wilfred/gameboy_emulator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd03eb12ad843c28de54a0ebc2b750cda8c6ddd7ee108b375b9de1f2fcea2f3f [INFO] running `"docker" "start" "-a" "dd03eb12ad843c28de54a0ebc2b750cda8c6ddd7ee108b375b9de1f2fcea2f3f"` [INFO] [stderr] Checking gameboy_emulator v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: field is never used: `memory` [INFO] [stderr] --> src/instructions.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | memory: [u8; 65536], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:345:20 [INFO] [stderr] | [INFO] [stderr] 345 | let low_byte = bytes[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:346:21 [INFO] [stderr] | [INFO] [stderr] 346 | let high_byte = bytes[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:353:20 [INFO] [stderr] | [INFO] [stderr] 353 | let low_byte = bytes[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:354:21 [INFO] [stderr] | [INFO] [stderr] 354 | let high_byte = bytes[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/instructions.rs:368:5 [INFO] [stderr] | [INFO] [stderr] 368 | cpu.pc = cpu.pc + Wrapping(1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.pc += Wrapping(1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/instructions.rs:376:13 [INFO] [stderr] | [INFO] [stderr] 376 | cpu.a = cpu.a ^ register_value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.a ^= register_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/instructions.rs:381:13 [INFO] [stderr] | [INFO] [stderr] 381 | *reg = *reg + Wrapping(1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*reg += Wrapping(1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:42 [INFO] [stderr] | [INFO] [stderr] 69 | implemented, total, 100.0 * implemented as f64 / total as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(implemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:63 [INFO] [stderr] | [INFO] [stderr] 69 | implemented, total, 100.0 * implemented as f64 / total as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(total)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: field is never used: `memory` [INFO] [stderr] --> src/instructions.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | memory: [u8; 65536], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:345:20 [INFO] [stderr] | [INFO] [stderr] 345 | let low_byte = bytes[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:346:21 [INFO] [stderr] | [INFO] [stderr] 346 | let high_byte = bytes[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:353:20 [INFO] [stderr] | [INFO] [stderr] 353 | let low_byte = bytes[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:354:21 [INFO] [stderr] | [INFO] [stderr] 354 | let high_byte = bytes[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/instructions.rs:368:5 [INFO] [stderr] | [INFO] [stderr] 368 | cpu.pc = cpu.pc + Wrapping(1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.pc += Wrapping(1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/instructions.rs:376:13 [INFO] [stderr] | [INFO] [stderr] 376 | cpu.a = cpu.a ^ register_value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.a ^= register_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/instructions.rs:381:13 [INFO] [stderr] | [INFO] [stderr] 381 | *reg = *reg + Wrapping(1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*reg += Wrapping(1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/instructions.rs:450:5 [INFO] [stderr] | [INFO] [stderr] 450 | step(&mut cpu, Nop); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/instructions.rs:460:5 [INFO] [stderr] | [INFO] [stderr] 460 | step(&mut cpu, Increment(Operand8::Register(A))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/instructions.rs:473:5 [INFO] [stderr] | [INFO] [stderr] 473 | step(&mut cpu, Increment(Operand8::Register(A))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/instructions.rs:530:5 [INFO] [stderr] | [INFO] [stderr] 530 | step(&mut cpu, decode(&bytes, 0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:42 [INFO] [stderr] | [INFO] [stderr] 69 | implemented, total, 100.0 * implemented as f64 / total as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(implemented)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:63 [INFO] [stderr] | [INFO] [stderr] 69 | implemented, total, 100.0 * implemented as f64 / total as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(total)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.76s [INFO] running `"docker" "inspect" "dd03eb12ad843c28de54a0ebc2b750cda8c6ddd7ee108b375b9de1f2fcea2f3f"` [INFO] running `"docker" "rm" "-f" "dd03eb12ad843c28de54a0ebc2b750cda8c6ddd7ee108b375b9de1f2fcea2f3f"` [INFO] [stdout] dd03eb12ad843c28de54a0ebc2b750cda8c6ddd7ee108b375b9de1f2fcea2f3f