[INFO] updating cached repository WanzenBug/rustsync [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/WanzenBug/rustsync [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/WanzenBug/rustsync" "work/ex/clippy-test-run/sources/stable/gh/WanzenBug/rustsync"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/WanzenBug/rustsync'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/WanzenBug/rustsync" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WanzenBug/rustsync"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WanzenBug/rustsync'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 69517f8bf7d96fa21252cec6dc674a4a6765bd0d [INFO] sha for GitHub repo WanzenBug/rustsync: 69517f8bf7d96fa21252cec6dc674a4a6765bd0d [INFO] validating manifest of WanzenBug/rustsync on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of WanzenBug/rustsync on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing WanzenBug/rustsync [INFO] finished frobbing WanzenBug/rustsync [INFO] frobbed toml for WanzenBug/rustsync written to work/ex/clippy-test-run/sources/stable/gh/WanzenBug/rustsync/Cargo.toml [INFO] started frobbing WanzenBug/rustsync [INFO] finished frobbing WanzenBug/rustsync [INFO] frobbed toml for WanzenBug/rustsync written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WanzenBug/rustsync/Cargo.toml [INFO] crate WanzenBug/rustsync has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting WanzenBug/rustsync against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/WanzenBug/rustsync:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eac0a8bf71e3129285ad4cb6cc12eaf4ef53db0ad20a6a5edebb43b4529d0541 [INFO] running `"docker" "start" "-a" "eac0a8bf71e3129285ad4cb6cc12eaf4ef53db0ad20a6a5edebb43b4529d0541"` [INFO] [stderr] Compiling case v0.1.0 [INFO] [stderr] Checking pbr v1.0.0 [INFO] [stderr] Compiling derive-error v0.0.3 [INFO] [stderr] Checking rustsync v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/local/source.rs:20:72 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(SyncableInfo::File { components: rel_path.components(), size: size }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/local/drain.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | full_path: full_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `full_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/local/source.rs:20:72 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(SyncableInfo::File { components: rel_path.components(), size: size }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/local/drain.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | full_path: full_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `full_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/lib.rs:33:59 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn sync_with_config(mut source: S, drain: D, config: &SyncConfig, mut updates: P) -> Result<()> where S: Source, D: Drain, P: SyncProgress { [INFO] [stderr] | ^^^^^^ help: consider using `_config` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/local/source.rs:79:47 [INFO] [stderr] | [INFO] [stderr] 79 | Err(e) => return Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/lib.rs:33:59 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn sync_with_config(mut source: S, drain: D, config: &SyncConfig, mut updates: P) -> Result<()> where S: Source, D: Drain, P: SyncProgress { [INFO] [stderr] | ^^^^^^ help: consider using `_config` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/local/source.rs:79:47 [INFO] [stderr] | [INFO] [stderr] 79 | Err(e) => return Some(Err(e.into())) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.16s [INFO] running `"docker" "inspect" "eac0a8bf71e3129285ad4cb6cc12eaf4ef53db0ad20a6a5edebb43b4529d0541"` [INFO] running `"docker" "rm" "-f" "eac0a8bf71e3129285ad4cb6cc12eaf4ef53db0ad20a6a5edebb43b4529d0541"` [INFO] [stdout] eac0a8bf71e3129285ad4cb6cc12eaf4ef53db0ad20a6a5edebb43b4529d0541