[INFO] updating cached repository WRuman/conway
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/WRuman/conway
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/WRuman/conway" "work/ex/clippy-test-run/sources/stable/gh/WRuman/conway"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/WRuman/conway'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/WRuman/conway" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WRuman/conway"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WRuman/conway'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1330fad0da3cdcea70178efbcbefd9ef9e497753
[INFO] sha for GitHub repo WRuman/conway: 1330fad0da3cdcea70178efbcbefd9ef9e497753
[INFO] validating manifest of WRuman/conway on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of WRuman/conway on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing WRuman/conway
[INFO] finished frobbing WRuman/conway
[INFO] frobbed toml for WRuman/conway written to work/ex/clippy-test-run/sources/stable/gh/WRuman/conway/Cargo.toml
[INFO] started frobbing WRuman/conway
[INFO] finished frobbing WRuman/conway
[INFO] frobbed toml for WRuman/conway written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WRuman/conway/Cargo.toml
[INFO] crate WRuman/conway has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting WRuman/conway against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/WRuman/conway:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 11adc09a78a67ae10a3c588063aee2094bcea1d38157582c8675a009a9a24601
[INFO] running `"docker" "start" "-a" "11adc09a78a67ae10a3c588063aee2094bcea1d38157582c8675a009a9a24601"`
[INFO] [stderr]     Checking conway v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/grid.rs:61:15
[INFO] [stderr]    |
[INFO] [stderr] 61 |         Grid {dim: dim, cells: cells}
[INFO] [stderr]    |               ^^^^^^^^ help: replace it with: `dim`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/grid.rs:61:25
[INFO] [stderr]    |
[INFO] [stderr] 61 |         Grid {dim: dim, cells: cells}
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: replace it with: `cells`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/grid.rs:61:15
[INFO] [stderr]    |
[INFO] [stderr] 61 |         Grid {dim: dim, cells: cells}
[INFO] [stderr]    |               ^^^^^^^^ help: replace it with: `dim`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/grid.rs:61:25
[INFO] [stderr]    |
[INFO] [stderr] 61 |         Grid {dim: dim, cells: cells}
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: replace it with: `cells`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add_acorn`
[INFO] [stderr]   --> src/game.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn add_acorn(&mut self) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/game.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 | /         match self.yin_yang {
[INFO] [stderr] 40 | |             false => print!("{}", self.board_b),
[INFO] [stderr] 41 | |             true => print!("{}", self.board_a)
[INFO] [stderr] 42 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if self.yin_yang { print!("{}", self.board_a) } else { print!("{}", self.board_b) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/game.rs:47:44
[INFO] [stderr]    |
[INFO] [stderr] 47 |           let (source_board, target_board) = match self.yin_yang {
[INFO] [stderr]    |  ____________________________________________^
[INFO] [stderr] 48 | |             true => (&self.board_a, &mut self.board_b),
[INFO] [stderr] 49 | |             false => (&self.board_b, &mut self.board_a)
[INFO] [stderr] 50 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if self.yin_yang { (&self.board_a, &mut self.board_b) } else { (&self.board_b, &mut self.board_a) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/game.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 | /         loop {
[INFO] [stderr] 53 | |             let (current_row, current_col, current_cell) = match griderator.next() {
[INFO] [stderr] 54 | |                 Some(c) => c,
[INFO] [stderr] 55 | |                 None => break
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |             target_board.set_cell((current_row, current_col), c_next);
[INFO] [stderr] 71 | |         }
[INFO] [stderr]    | |_________^ help: try: `while let Some(c) = griderator.next() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/grid.rs:18:17
[INFO] [stderr]    |
[INFO] [stderr] 18 |     fn is_alive(&self) -> bool {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/grid.rs:133:21
[INFO] [stderr]     |
[INFO] [stderr] 133 |               *cell = match rng.gen::<bool>() {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 134 | |                 true => Cell::Alive,
[INFO] [stderr] 135 | |                 false => Cell::Dead
[INFO] [stderr] 136 | |             };
[INFO] [stderr]     | |_____________^ help: consider using an if/else expression: `if rng.gen::<bool>() { Cell::Alive } else { Cell::Dead }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add_acorn`
[INFO] [stderr]   --> src/game.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn add_acorn(&mut self) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/game.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 | /         match self.yin_yang {
[INFO] [stderr] 40 | |             false => print!("{}", self.board_b),
[INFO] [stderr] 41 | |             true => print!("{}", self.board_a)
[INFO] [stderr] 42 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if self.yin_yang { print!("{}", self.board_a) } else { print!("{}", self.board_b) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/game.rs:47:44
[INFO] [stderr]    |
[INFO] [stderr] 47 |           let (source_board, target_board) = match self.yin_yang {
[INFO] [stderr]    |  ____________________________________________^
[INFO] [stderr] 48 | |             true => (&self.board_a, &mut self.board_b),
[INFO] [stderr] 49 | |             false => (&self.board_b, &mut self.board_a)
[INFO] [stderr] 50 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if self.yin_yang { (&self.board_a, &mut self.board_b) } else { (&self.board_b, &mut self.board_a) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/game.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 | /         loop {
[INFO] [stderr] 53 | |             let (current_row, current_col, current_cell) = match griderator.next() {
[INFO] [stderr] 54 | |                 Some(c) => c,
[INFO] [stderr] 55 | |                 None => break
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |             target_board.set_cell((current_row, current_col), c_next);
[INFO] [stderr] 71 | |         }
[INFO] [stderr]    | |_________^ help: try: `while let Some(c) = griderator.next() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/grid.rs:18:17
[INFO] [stderr]    |
[INFO] [stderr] 18 |     fn is_alive(&self) -> bool {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/grid.rs:133:21
[INFO] [stderr]     |
[INFO] [stderr] 133 |               *cell = match rng.gen::<bool>() {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 134 | |                 true => Cell::Alive,
[INFO] [stderr] 135 | |                 false => Cell::Dead
[INFO] [stderr] 136 | |             };
[INFO] [stderr]     | |_____________^ help: consider using an if/else expression: `if rng.gen::<bool>() { Cell::Alive } else { Cell::Dead }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.09s
[INFO] running `"docker" "inspect" "11adc09a78a67ae10a3c588063aee2094bcea1d38157582c8675a009a9a24601"`
[INFO] running `"docker" "rm" "-f" "11adc09a78a67ae10a3c588063aee2094bcea1d38157582c8675a009a9a24601"`
[INFO] [stdout] 11adc09a78a67ae10a3c588063aee2094bcea1d38157582c8675a009a9a24601