[INFO] updating cached repository WAFFO/karma-dice-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/WAFFO/karma-dice-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/WAFFO/karma-dice-rust" "work/ex/clippy-test-run/sources/stable/gh/WAFFO/karma-dice-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/WAFFO/karma-dice-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/WAFFO/karma-dice-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WAFFO/karma-dice-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WAFFO/karma-dice-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c5345743c35b10da9abc5a46d20fad38d937f1a2 [INFO] sha for GitHub repo WAFFO/karma-dice-rust: c5345743c35b10da9abc5a46d20fad38d937f1a2 [INFO] validating manifest of WAFFO/karma-dice-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of WAFFO/karma-dice-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing WAFFO/karma-dice-rust [INFO] finished frobbing WAFFO/karma-dice-rust [INFO] frobbed toml for WAFFO/karma-dice-rust written to work/ex/clippy-test-run/sources/stable/gh/WAFFO/karma-dice-rust/Cargo.toml [INFO] started frobbing WAFFO/karma-dice-rust [INFO] finished frobbing WAFFO/karma-dice-rust [INFO] frobbed toml for WAFFO/karma-dice-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/WAFFO/karma-dice-rust/Cargo.toml [INFO] crate WAFFO/karma-dice-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting WAFFO/karma-dice-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/WAFFO/karma-dice-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7edb622af1871a905702983b7b3d2202c27487f64422f631e5d4b9ffc01cd09e [INFO] running `"docker" "start" "-a" "7edb622af1871a905702983b7b3d2202c27487f64422f631e5d4b9ffc01cd09e"` [INFO] [stderr] Checking karma_dice_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/karma_dice.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return (rolls, sum, karma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(rolls, sum, karma)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/karma_dice.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return (rolls, sum, karma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(rolls, sum, karma)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/karma_dice.rs:14:53 [INFO] [stderr] | [INFO] [stderr] 14 | let temp: u32 = (fast_karma_rng(&mut karma)*(faces as f64)).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(faces)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/karma_dice.rs:14:53 [INFO] [stderr] | [INFO] [stderr] 14 | let temp: u32 = (fast_karma_rng(&mut karma)*(faces as f64)).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(faces)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:29:8 [INFO] [stderr] | [INFO] [stderr] 29 | if faces <= 0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using faces == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `karma_dice_rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:29:8 [INFO] [stderr] | [INFO] [stderr] 29 | if faces <= 0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using faces == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `karma_dice_rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7edb622af1871a905702983b7b3d2202c27487f64422f631e5d4b9ffc01cd09e"` [INFO] running `"docker" "rm" "-f" "7edb622af1871a905702983b7b3d2202c27487f64422f631e5d4b9ffc01cd09e"` [INFO] [stdout] 7edb622af1871a905702983b7b3d2202c27487f64422f631e5d4b9ffc01cd09e