[INFO] updating cached repository Vurich/rustc-demangle [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Vurich/rustc-demangle [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Vurich/rustc-demangle" "work/ex/clippy-test-run/sources/stable/gh/Vurich/rustc-demangle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Vurich/rustc-demangle'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Vurich/rustc-demangle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vurich/rustc-demangle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vurich/rustc-demangle'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4265ca8f1eef9110fa86607f49a258f1caa62538 [INFO] sha for GitHub repo Vurich/rustc-demangle: 4265ca8f1eef9110fa86607f49a258f1caa62538 [INFO] validating manifest of Vurich/rustc-demangle on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Vurich/rustc-demangle on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Vurich/rustc-demangle [INFO] finished frobbing Vurich/rustc-demangle [INFO] frobbed toml for Vurich/rustc-demangle written to work/ex/clippy-test-run/sources/stable/gh/Vurich/rustc-demangle/Cargo.toml [INFO] started frobbing Vurich/rustc-demangle [INFO] finished frobbing Vurich/rustc-demangle [INFO] frobbed toml for Vurich/rustc-demangle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vurich/rustc-demangle/Cargo.toml [INFO] crate Vurich/rustc-demangle has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Vurich/rustc-demangle against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Vurich/rustc-demangle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a959776b3c1cc21f557e765e6851c8c5d5ae29d11ec0df26c627e74d2c98731 [INFO] running `"docker" "start" "-a" "3a959776b3c1cc21f557e765e6851c8c5d5ae29d11ec0df26c627e74d2c98731"` [INFO] [stderr] Checking rust-asm-demangle v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | / write!( [INFO] [stderr] 15 | | output, [INFO] [stderr] 16 | | "{}{}{}\n", [INFO] [stderr] 17 | | &line[..index], [INFO] [stderr] 18 | | demangle(&s[..sym_end]), [INFO] [stderr] 19 | | &s[sym_end..] [INFO] [stderr] 20 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | write!(output, "{}\n", line)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | / write!( [INFO] [stderr] 15 | | output, [INFO] [stderr] 16 | | "{}{}{}\n", [INFO] [stderr] 17 | | &line[..index], [INFO] [stderr] 18 | | demangle(&s[..sym_end]), [INFO] [stderr] 19 | | &s[sym_end..] [INFO] [stderr] 20 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | write!(output, "{}\n", line)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:12:87 [INFO] [stderr] | [INFO] [stderr] 12 | let sym_end = s.find(|c: char| c == ':' || c == '@' || c.is_whitespace()).unwrap_or(s.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:12:87 [INFO] [stderr] | [INFO] [stderr] 12 | let sym_end = s.find(|c: char| c == ':' || c == '@' || c.is_whitespace()).unwrap_or(s.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.43s [INFO] running `"docker" "inspect" "3a959776b3c1cc21f557e765e6851c8c5d5ae29d11ec0df26c627e74d2c98731"` [INFO] running `"docker" "rm" "-f" "3a959776b3c1cc21f557e765e6851c8c5d5ae29d11ec0df26c627e74d2c98731"` [INFO] [stdout] 3a959776b3c1cc21f557e765e6851c8c5d5ae29d11ec0df26c627e74d2c98731