[INFO] updating cached repository VoxWave/Mato [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/VoxWave/Mato [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/VoxWave/Mato" "work/ex/clippy-test-run/sources/stable/gh/VoxWave/Mato"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/VoxWave/Mato'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/VoxWave/Mato" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VoxWave/Mato"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VoxWave/Mato'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9535e811ecbe3c0c5a7d1ea3648bfaa3627385e5 [INFO] sha for GitHub repo VoxWave/Mato: 9535e811ecbe3c0c5a7d1ea3648bfaa3627385e5 [INFO] validating manifest of VoxWave/Mato on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of VoxWave/Mato on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing VoxWave/Mato [INFO] finished frobbing VoxWave/Mato [INFO] frobbed toml for VoxWave/Mato written to work/ex/clippy-test-run/sources/stable/gh/VoxWave/Mato/Cargo.toml [INFO] started frobbing VoxWave/Mato [INFO] finished frobbing VoxWave/Mato [INFO] frobbed toml for VoxWave/Mato written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VoxWave/Mato/Cargo.toml [INFO] crate VoxWave/Mato has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting VoxWave/Mato against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/VoxWave/Mato:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 781db39fd59d5cef8d033f391114db14cfd649c64604a4466021ad2deadfaabb [INFO] running `"docker" "start" "-a" "781db39fd59d5cef8d033f391114db14cfd649c64604a4466021ad2deadfaabb"` [INFO] [stderr] Checking arrayvec v0.4.5 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking glutin v0.10.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Checking pistoncore-glutin_window v0.42.0 [INFO] [stderr] Checking piston2d-graphics v0.23.0 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking piston-gfx_texture v0.29.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.46.0 [INFO] [stderr] Checking piston_window v0.73.0 [INFO] [stderr] Checking mato v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | snake_body: snake_body, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snake_body` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | snake_body: snake_body, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `snake_body` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:100:36 [INFO] [stderr] | [INFO] [stderr] 100 | self.snake_body.push_front(self.snake_head.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.snake_head` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / if let &Input(Button(ButtonArgs { button: Keyboard(ref k), state: Press, ..})) = &e { [INFO] [stderr] 160 | | game.wanted_direction = match *k { [INFO] [stderr] 161 | | Key::W => Up, [INFO] [stderr] 162 | | Key::A => Left, [INFO] [stderr] ... | [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | if let Input(Button(ButtonArgs { button: Keyboard(ref k), state: Press, ..})) = e { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:182:24 [INFO] [stderr] | [INFO] [stderr] 182 | [head_x as f64 * 20., 500. - (head_y as f64 + 1.) * 20., 20.0, 20.0], [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(head_x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:182:53 [INFO] [stderr] | [INFO] [stderr] 182 | [head_x as f64 * 20., 500. - (head_y as f64 + 1.) * 20., 20.0, 20.0], [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(head_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:187:24 [INFO] [stderr] | [INFO] [stderr] 187 | [x as f64 * 20., 500. - (y as f64 + 1.) * 20., 20.0, 20.0], [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:187:48 [INFO] [stderr] | [INFO] [stderr] 187 | [x as f64 * 20., 500. - (y as f64 + 1.) * 20., 20.0, 20.0], [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:193:24 [INFO] [stderr] | [INFO] [stderr] 193 | [apple_x as f64 * 20., 500. - (apple_y as f64 + 1.) * 20., 20.0, 20.0], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(apple_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:193:54 [INFO] [stderr] | [INFO] [stderr] 193 | [apple_x as f64 * 20., 500. - (apple_y as f64 + 1.) * 20., 20.0, 20.0], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(apple_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:100:36 [INFO] [stderr] | [INFO] [stderr] 100 | self.snake_body.push_front(self.snake_head.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.snake_head` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / if let &Input(Button(ButtonArgs { button: Keyboard(ref k), state: Press, ..})) = &e { [INFO] [stderr] 160 | | game.wanted_direction = match *k { [INFO] [stderr] 161 | | Key::W => Up, [INFO] [stderr] 162 | | Key::A => Left, [INFO] [stderr] ... | [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | if let Input(Button(ButtonArgs { button: Keyboard(ref k), state: Press, ..})) = e { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:182:24 [INFO] [stderr] | [INFO] [stderr] 182 | [head_x as f64 * 20., 500. - (head_y as f64 + 1.) * 20., 20.0, 20.0], [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(head_x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:182:53 [INFO] [stderr] | [INFO] [stderr] 182 | [head_x as f64 * 20., 500. - (head_y as f64 + 1.) * 20., 20.0, 20.0], [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(head_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:187:24 [INFO] [stderr] | [INFO] [stderr] 187 | [x as f64 * 20., 500. - (y as f64 + 1.) * 20., 20.0, 20.0], [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:187:48 [INFO] [stderr] | [INFO] [stderr] 187 | [x as f64 * 20., 500. - (y as f64 + 1.) * 20., 20.0, 20.0], [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:193:24 [INFO] [stderr] | [INFO] [stderr] 193 | [apple_x as f64 * 20., 500. - (apple_y as f64 + 1.) * 20., 20.0, 20.0], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(apple_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:193:54 [INFO] [stderr] | [INFO] [stderr] 193 | [apple_x as f64 * 20., 500. - (apple_y as f64 + 1.) * 20., 20.0, 20.0], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(apple_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.08s [INFO] running `"docker" "inspect" "781db39fd59d5cef8d033f391114db14cfd649c64604a4466021ad2deadfaabb"` [INFO] running `"docker" "rm" "-f" "781db39fd59d5cef8d033f391114db14cfd649c64604a4466021ad2deadfaabb"` [INFO] [stdout] 781db39fd59d5cef8d033f391114db14cfd649c64604a4466021ad2deadfaabb