[INFO] updating cached repository VioletasTheThird/learning-opengl-i-guess [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/VioletasTheThird/learning-opengl-i-guess [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/VioletasTheThird/learning-opengl-i-guess" "work/ex/clippy-test-run/sources/stable/gh/VioletasTheThird/learning-opengl-i-guess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/VioletasTheThird/learning-opengl-i-guess'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/VioletasTheThird/learning-opengl-i-guess" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VioletasTheThird/learning-opengl-i-guess"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VioletasTheThird/learning-opengl-i-guess'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 588600ecc4c38d5451249ea0b1b48bd05d6cadf9 [INFO] sha for GitHub repo VioletasTheThird/learning-opengl-i-guess: 588600ecc4c38d5451249ea0b1b48bd05d6cadf9 [INFO] validating manifest of VioletasTheThird/learning-opengl-i-guess on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of VioletasTheThird/learning-opengl-i-guess on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing VioletasTheThird/learning-opengl-i-guess [INFO] finished frobbing VioletasTheThird/learning-opengl-i-guess [INFO] frobbed toml for VioletasTheThird/learning-opengl-i-guess written to work/ex/clippy-test-run/sources/stable/gh/VioletasTheThird/learning-opengl-i-guess/Cargo.toml [INFO] started frobbing VioletasTheThird/learning-opengl-i-guess [INFO] finished frobbing VioletasTheThird/learning-opengl-i-guess [INFO] frobbed toml for VioletasTheThird/learning-opengl-i-guess written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VioletasTheThird/learning-opengl-i-guess/Cargo.toml [INFO] crate VioletasTheThird/learning-opengl-i-guess has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting VioletasTheThird/learning-opengl-i-guess against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/VioletasTheThird/learning-opengl-i-guess:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a10c667fe481aee9c84dea89c0b821c067a80f1dae6fbffa5061a0b0a976f775 [INFO] running `"docker" "start" "-a" "a10c667fe481aee9c84dea89c0b821c067a80f1dae6fbffa5061a0b0a976f775"` [INFO] [stderr] Compiling log v0.4.2 [INFO] [stderr] Checking smithay-client-toolkit v0.2.3 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Checking winit v0.15.1 [INFO] [stderr] Compiling glutin v0.16.0 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Checking learn_opengl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::mem::size_of` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::mem::size_of; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ffi::CString` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::ffi::CString; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::mem::size_of` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::mem::size_of; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ffi::CString` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::ffi::CString; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `vs` is never read [INFO] [stderr] --> src/shader_program.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | let mut vs = 0; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `fs` is never read [INFO] [stderr] --> src/shader_program.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | let mut fs = 0; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `p` is never read [INFO] [stderr] --> src/shader_program.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | let mut p = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `vs` is never read [INFO] [stderr] --> src/shader_program.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | let mut vs = 0; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `fs` is never read [INFO] [stderr] --> src/shader_program.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | let mut fs = 0; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `p` is never read [INFO] [stderr] --> src/shader_program.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | let mut p = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | let mut program = ShaderProgram::new( [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | let mut program = ShaderProgram::new( [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader_program.rs:74:31 [INFO] [stderr] | [INFO] [stderr] 74 | if comp_status != gl::TRUE as types::GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/shader_program.rs:86:84 [INFO] [stderr] | [INFO] [stderr] 86 | gl::VertexAttribPointer(pos_attrib as u32, 2, gl::FLOAT, gl::FALSE, 0, 0 as *const c_void); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | / match event { [INFO] [stderr] 66 | | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] 67 | | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 68 | | glutin::WindowEvent::Resized(w, h) => win.resize(w, h), [INFO] [stderr] ... | [INFO] [stderr] 71 | | _ => () [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let glutin::Event::WindowEvent{ event, .. } = event { match event { [INFO] [stderr] 66 | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 67 | glutin::WindowEvent::Resized(w, h) => win.resize(w, h), [INFO] [stderr] 68 | _ => () [INFO] [stderr] 69 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader_program.rs:74:31 [INFO] [stderr] | [INFO] [stderr] 74 | if comp_status != gl::TRUE as types::GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/shader_program.rs:86:84 [INFO] [stderr] | [INFO] [stderr] 86 | gl::VertexAttribPointer(pos_attrib as u32, 2, gl::FLOAT, gl::FALSE, 0, 0 as *const c_void); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | / match event { [INFO] [stderr] 66 | | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] 67 | | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 68 | | glutin::WindowEvent::Resized(w, h) => win.resize(w, h), [INFO] [stderr] ... | [INFO] [stderr] 71 | | _ => () [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let glutin::Event::WindowEvent{ event, .. } = event { match event { [INFO] [stderr] 66 | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 67 | glutin::WindowEvent::Resized(w, h) => win.resize(w, h), [INFO] [stderr] 68 | _ => () [INFO] [stderr] 69 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.00s [INFO] running `"docker" "inspect" "a10c667fe481aee9c84dea89c0b821c067a80f1dae6fbffa5061a0b0a976f775"` [INFO] running `"docker" "rm" "-f" "a10c667fe481aee9c84dea89c0b821c067a80f1dae6fbffa5061a0b0a976f775"` [INFO] [stdout] a10c667fe481aee9c84dea89c0b821c067a80f1dae6fbffa5061a0b0a976f775