[INFO] updating cached repository VioletasTheThird/YAVM [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/VioletasTheThird/YAVM [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/VioletasTheThird/YAVM" "work/ex/clippy-test-run/sources/stable/gh/VioletasTheThird/YAVM"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/VioletasTheThird/YAVM'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/VioletasTheThird/YAVM" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VioletasTheThird/YAVM"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VioletasTheThird/YAVM'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c5cf54a18b57aae62fc8f99758714ae735b22073 [INFO] sha for GitHub repo VioletasTheThird/YAVM: c5cf54a18b57aae62fc8f99758714ae735b22073 [INFO] validating manifest of VioletasTheThird/YAVM on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of VioletasTheThird/YAVM on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing VioletasTheThird/YAVM [INFO] finished frobbing VioletasTheThird/YAVM [INFO] frobbed toml for VioletasTheThird/YAVM written to work/ex/clippy-test-run/sources/stable/gh/VioletasTheThird/YAVM/Cargo.toml [INFO] started frobbing VioletasTheThird/YAVM [INFO] finished frobbing VioletasTheThird/YAVM [INFO] frobbed toml for VioletasTheThird/YAVM written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/VioletasTheThird/YAVM/Cargo.toml [INFO] crate VioletasTheThird/YAVM has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting VioletasTheThird/YAVM against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/VioletasTheThird/YAVM:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c9d95eafb388d9ab23eebad2a76668eeebbe99b55bda9d9976250a00bc3804f [INFO] running `"docker" "start" "-a" "9c9d95eafb388d9ab23eebad2a76668eeebbe99b55bda9d9976250a00bc3804f"` [INFO] [stderr] Checking yavm v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::stdout` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::stdout; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::stdout` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::stdout; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `disk` [INFO] [stderr] --> src/vhdd.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | disk : [[[u8; 512]; 16]; 8], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ptr` [INFO] [stderr] --> src/vhdd.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | ptr : [usize; 3], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `vcpu::VCpu` [INFO] [stderr] --> src/vcpu.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new () -> VCpu { [INFO] [stderr] 23 | | VCpu { [INFO] [stderr] 24 | | mem : [0x0; 1024], [INFO] [stderr] 25 | | ptr : 0x0 as usize, [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for vcpu::VCpu { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `program` [INFO] [stderr] --> src/vcpu.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | for i in 0..program.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for (i, ) in program.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/vcpu.rs:47:15 [INFO] [stderr] | [INFO] [stderr] 47 | while !(i > self.mem.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i <= self.mem.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: field is never used: `disk` [INFO] [stderr] --> src/vhdd.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | disk : [[[u8; 512]; 16]; 8], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ptr` [INFO] [stderr] --> src/vhdd.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | ptr : [usize; 3], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j as usize` [INFO] [stderr] --> src/vcpu.rs:89:76 [INFO] [stderr] | [INFO] [stderr] 89 | self.mem[self.ptr + j as usize] = input.as_bytes()[0 + j as usize] as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `vhdd::VDisk` [INFO] [stderr] --> src/vhdd.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> VDisk { [INFO] [stderr] 13 | | VDisk { [INFO] [stderr] 14 | | disk : [[[0; 512]; 16]; 8], [INFO] [stderr] 15 | | ptr : [0; 3], [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for vhdd::VDisk { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `vcpu::VCpu` [INFO] [stderr] --> src/vcpu.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new () -> VCpu { [INFO] [stderr] 23 | | VCpu { [INFO] [stderr] 24 | | mem : [0x0; 1024], [INFO] [stderr] 25 | | ptr : 0x0 as usize, [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | impl Default for vcpu::VCpu { [INFO] [stderr] 21 | fn default() -> Self { [INFO] [stderr] 22 | Self::new() [INFO] [stderr] 23 | } [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `program` [INFO] [stderr] --> src/vcpu.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | for i in 0..program.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for (i, ) in program.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/vcpu.rs:47:15 [INFO] [stderr] | [INFO] [stderr] 47 | while !(i > self.mem.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i <= self.mem.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j as usize` [INFO] [stderr] --> src/vcpu.rs:89:76 [INFO] [stderr] | [INFO] [stderr] 89 | self.mem[self.ptr + j as usize] = input.as_bytes()[0 + j as usize] as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `vhdd::VDisk` [INFO] [stderr] --> src/vhdd.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> VDisk { [INFO] [stderr] 13 | | VDisk { [INFO] [stderr] 14 | | disk : [[[0; 512]; 16]; 8], [INFO] [stderr] 15 | | ptr : [0; 3], [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for vhdd::VDisk { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.20s [INFO] running `"docker" "inspect" "9c9d95eafb388d9ab23eebad2a76668eeebbe99b55bda9d9976250a00bc3804f"` [INFO] running `"docker" "rm" "-f" "9c9d95eafb388d9ab23eebad2a76668eeebbe99b55bda9d9976250a00bc3804f"` [INFO] [stdout] 9c9d95eafb388d9ab23eebad2a76668eeebbe99b55bda9d9976250a00bc3804f