[INFO] updating cached repository Vinatorul/RustyChecker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Vinatorul/RustyChecker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Vinatorul/RustyChecker" "work/ex/clippy-test-run/sources/stable/gh/Vinatorul/RustyChecker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Vinatorul/RustyChecker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Vinatorul/RustyChecker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vinatorul/RustyChecker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vinatorul/RustyChecker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6c466e7a1e8b2bd9c5565c1953970ec5249d55fc [INFO] sha for GitHub repo Vinatorul/RustyChecker: 6c466e7a1e8b2bd9c5565c1953970ec5249d55fc [INFO] validating manifest of Vinatorul/RustyChecker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Vinatorul/RustyChecker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Vinatorul/RustyChecker [INFO] finished frobbing Vinatorul/RustyChecker [INFO] frobbed toml for Vinatorul/RustyChecker written to work/ex/clippy-test-run/sources/stable/gh/Vinatorul/RustyChecker/Cargo.toml [INFO] started frobbing Vinatorul/RustyChecker [INFO] finished frobbing Vinatorul/RustyChecker [INFO] frobbed toml for Vinatorul/RustyChecker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vinatorul/RustyChecker/Cargo.toml [INFO] crate Vinatorul/RustyChecker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Vinatorul/RustyChecker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Vinatorul/RustyChecker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0212db0954ac4d400d92e6699e789f01642b2500730580e95c1e330a4e2ba3b1 [INFO] running `"docker" "start" "-a" "0212db0954ac4d400d92e6699e789f01642b2500730580e95c1e330a4e2ba3b1"` [INFO] [stderr] Checking rusty_checker v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:97:4 [INFO] [stderr] | [INFO] [stderr] 97 | str_id: str_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `str_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:98:4 [INFO] [stderr] | [INFO] [stderr] 98 | statement: statement, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `statement` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:99:4 [INFO] [stderr] | [INFO] [stderr] 99 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:100:4 [INFO] [stderr] | [INFO] [stderr] 100 | authors: authors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `authors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:171:4 [INFO] [stderr] | [INFO] [stderr] 171 | reason:reason, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `reason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:172:4 [INFO] [stderr] | [INFO] [stderr] 172 | sys_part: sys_part, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sys_part` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:174:4 [INFO] [stderr] | [INFO] [stderr] 174 | test_no: test_no [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `test_no` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:97:4 [INFO] [stderr] | [INFO] [stderr] 97 | str_id: str_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `str_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:98:4 [INFO] [stderr] | [INFO] [stderr] 98 | statement: statement, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `statement` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:99:4 [INFO] [stderr] | [INFO] [stderr] 99 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:100:4 [INFO] [stderr] | [INFO] [stderr] 100 | authors: authors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `authors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:171:4 [INFO] [stderr] | [INFO] [stderr] 171 | reason:reason, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `reason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:172:4 [INFO] [stderr] | [INFO] [stderr] 172 | sys_part: sys_part, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sys_part` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/problem.rs:174:4 [INFO] [stderr] | [INFO] [stderr] 174 | test_no: test_no [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `test_no` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/problem.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | const PROBLEMS_DIR: &'static str = "problems"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/problem.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | const INPUT_DIR: &'static str = "input"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/problem.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | const OUTPUT_DIR: &'static str = "output"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/problem.rs:117:3 [INFO] [stderr] | [INFO] [stderr] 117 | return self.run_test(1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.run_test(1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: private type `problem::ProblemError` in public interface (error E0446) [INFO] [stderr] --> src/problem.rs:103:2 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn run(&self) -> Result<(), ProblemError> { [INFO] [stderr] | _____^ [INFO] [stderr] 104 | | let builder = match Command::new("rustc") [INFO] [stderr] 105 | | .arg(format!("{}/{}/{}.rs", PROBLEMS_DIR, self.str_id, self.str_id)) [INFO] [stderr] 106 | | .arg("--out-dir") [INFO] [stderr] ... | [INFO] [stderr] 117 | | return self.run_test(1); [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PROBLEMS_DIR` [INFO] [stderr] --> src/problem.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | const PROBLEMS_DIR: &'static str = "problems"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INPUT_DIR` [INFO] [stderr] --> src/problem.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | const INPUT_DIR: &'static str = "input"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `OUTPUT_DIR` [INFO] [stderr] --> src/problem.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | const OUTPUT_DIR: &'static str = "output"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Problem` [INFO] [stderr] --> src/problem.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub struct Problem { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `State` [INFO] [stderr] --> src/problem.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | enum State { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ProblemError` [INFO] [stderr] --> src/problem.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | struct ProblemError { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/problem.rs:68:2 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn new(str_id: String) -> Problem { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `run` [INFO] [stderr] --> src/problem.rs:103:2 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn run(&self) -> Result<(), ProblemError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `run_test` [INFO] [stderr] --> src/problem.rs:120:2 [INFO] [stderr] | [INFO] [stderr] 120 | fn run_test(&self, test_no: i32) -> Result<(), ProblemError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `make_error` [INFO] [stderr] --> src/problem.rs:169:2 [INFO] [stderr] | [INFO] [stderr] 169 | fn make_error(&self, reason: &'static str, sys_part: String, test_no: i32) -> Result<(), ProblemError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/problem.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | const PROBLEMS_DIR: &'static str = "problems"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/problem.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | const INPUT_DIR: &'static str = "input"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/problem.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | const OUTPUT_DIR: &'static str = "output"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/problem.rs:117:3 [INFO] [stderr] | [INFO] [stderr] 117 | return self.run_test(1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.run_test(1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: private type `problem::ProblemError` in public interface (error E0446) [INFO] [stderr] --> src/problem.rs:103:2 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn run(&self) -> Result<(), ProblemError> { [INFO] [stderr] | _____^ [INFO] [stderr] 104 | | let builder = match Command::new("rustc") [INFO] [stderr] 105 | | .arg(format!("{}/{}/{}.rs", PROBLEMS_DIR, self.str_id, self.str_id)) [INFO] [stderr] 106 | | .arg("--out-dir") [INFO] [stderr] ... | [INFO] [stderr] 117 | | return self.run_test(1); [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "0212db0954ac4d400d92e6699e789f01642b2500730580e95c1e330a4e2ba3b1"` [INFO] running `"docker" "rm" "-f" "0212db0954ac4d400d92e6699e789f01642b2500730580e95c1e330a4e2ba3b1"` [INFO] [stdout] 0212db0954ac4d400d92e6699e789f01642b2500730580e95c1e330a4e2ba3b1