[INFO] updating cached repository Venats/advent_of_code_2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Venats/advent_of_code_2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Venats/advent_of_code_2018" "work/ex/clippy-test-run/sources/stable/gh/Venats/advent_of_code_2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Venats/advent_of_code_2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Venats/advent_of_code_2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Venats/advent_of_code_2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Venats/advent_of_code_2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 719594a2ca24588f935f95703d4988fd6cbcb071
[INFO] sha for GitHub repo Venats/advent_of_code_2018: 719594a2ca24588f935f95703d4988fd6cbcb071
[INFO] validating manifest of Venats/advent_of_code_2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Venats/advent_of_code_2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Venats/advent_of_code_2018
[INFO] finished frobbing Venats/advent_of_code_2018
[INFO] frobbed toml for Venats/advent_of_code_2018 written to work/ex/clippy-test-run/sources/stable/gh/Venats/advent_of_code_2018/Cargo.toml
[INFO] started frobbing Venats/advent_of_code_2018
[INFO] finished frobbing Venats/advent_of_code_2018
[INFO] frobbed toml for Venats/advent_of_code_2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Venats/advent_of_code_2018/Cargo.toml
[INFO] crate Venats/advent_of_code_2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Venats/advent_of_code_2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Venats/advent_of_code_2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] aea34401b30fd346924270b378900517f1c3a8eb94c8990538054e86f132ed77
[INFO] running `"docker" "start" "-a" "aea34401b30fd346924270b378900517f1c3a8eb94c8990538054e86f132ed77"`
[INFO] [stderr]     Checking scan_fmt v0.1.3
[INFO] [stderr]     Checking advent_of_code_2018 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused imports: `BufReader`, `stdin`
[INFO] [stderr]  --> src/lib.rs:4:15
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::io::{stdin,BufRead,BufReader};
[INFO] [stderr]   |               ^^^^^         ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `BufReader`, `stdin`
[INFO] [stderr]  --> src/lib.rs:4:15
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::io::{stdin,BufRead,BufReader};
[INFO] [stderr]   |               ^^^^^         ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bin/day4.rs:29:15
[INFO] [stderr]    |
[INFO] [stderr] 29 |         Guard{id:id, sleeping:[0;60]}
[INFO] [stderr]    |               ^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bin/day4.rs:29:15
[INFO] [stderr]    |
[INFO] [stderr] 29 |         Guard{id:id, sleeping:[0;60]}
[INFO] [stderr]    |               ^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/bin/day2.rs:7:25
[INFO] [stderr]   |
[INFO] [stderr] 7 | fn find_checksum(input: &Vec<String>) -> u32 {
[INFO] [stderr]   |                         ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/bin/day2.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 | /             match one_difference {
[INFO] [stderr] 33 | |                 false => one_difference = true,
[INFO] [stderr] 34 | |                 true => return false,
[INFO] [stderr] 35 | |             };
[INFO] [stderr]    | |_____________^ help: consider using an if/else expression: `if one_difference { return false } else { one_difference = true }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day1.rs:15:34
[INFO] [stderr]    |
[INFO] [stderr] 15 | fn find_repeat_freq(frequencies: &Vec<i32>) -> Result<i32, Errors> {
[INFO] [stderr]    |                                  ^^^^^^^^^ help: change this to: `&[i32]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/bin/day1.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         match hash.insert(sum) {
[INFO] [stderr] 22 | |             true    => (),
[INFO] [stderr] 23 | |             false   => return Ok(sum),
[INFO] [stderr] 24 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if !hash.insert(sum) { return Ok(sum) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/bin/day2.rs:7:25
[INFO] [stderr]   |
[INFO] [stderr] 7 | fn find_checksum(input: &Vec<String>) -> u32 {
[INFO] [stderr]   |                         ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/bin/day2.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 | /             match one_difference {
[INFO] [stderr] 33 | |                 false => one_difference = true,
[INFO] [stderr] 34 | |                 true => return false,
[INFO] [stderr] 35 | |             };
[INFO] [stderr]    | |_____________^ help: consider using an if/else expression: `if one_difference { return false } else { one_difference = true }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day1.rs:15:34
[INFO] [stderr]    |
[INFO] [stderr] 15 | fn find_repeat_freq(frequencies: &Vec<i32>) -> Result<i32, Errors> {
[INFO] [stderr]    |                                  ^^^^^^^^^ help: change this to: `&[i32]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/bin/day1.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         match hash.insert(sum) {
[INFO] [stderr] 22 | |             true    => (),
[INFO] [stderr] 23 | |             false   => return Ok(sum),
[INFO] [stderr] 24 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if !hash.insert(sum) { return Ok(sum) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/bin/day3.rs:34:32
[INFO] [stderr]    |
[INFO] [stderr] 34 |     pub fn from_string(string: &String) -> Fabric {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day3.rs:48:29
[INFO] [stderr]    |
[INFO] [stderr] 48 | fn make_fabric_map(fabrics: &Vec<Fabric>) -> ClaimMap {
[INFO] [stderr]    |                             ^^^^^^^^^^^^ help: change this to: `&[Fabric]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/bin/day3.rs:54:51
[INFO] [stderr]    |
[INFO] [stderr] 54 |                 claim_map.fabric_map.entry((x,y)).or_insert(Vec::new()).push(fabric.id);
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day4.rs:31:35
[INFO] [stderr]    |
[INFO] [stderr] 31 |     pub fn parse_to_guards(input: &Vec<String>) -> HashMap<usize,Guard> {
[INFO] [stderr]    |                                   ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/bin/day4.rs:36:32
[INFO] [stderr]    |
[INFO] [stderr] 36 |         while let Some(line) = line_iter.next() {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^ help: try: `for line in line_iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/bin/day4.rs:39:59
[INFO] [stderr]    |
[INFO] [stderr] 39 |                     cur_guard = guard_map.entry(guard_id).or_insert(Guard::new(guard_id)).id;
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Guard::new(guard_id))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/bin/day4.rs:49:60
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 let mut guard = guard_map.entry(cur_guard).or_insert(Guard::new(cur_guard));
[INFO] [stderr]    |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Guard::new(cur_guard))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/bin/day4.rs:60:29
[INFO] [stderr]    |
[INFO] [stderr] 60 |         self.sleeping.iter().fold(0, |total, min| total+min)
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day4.rs:31:35
[INFO] [stderr]    |
[INFO] [stderr] 31 |     pub fn parse_to_guards(input: &Vec<String>) -> HashMap<usize,Guard> {
[INFO] [stderr]    |                                   ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/bin/day4.rs:36:32
[INFO] [stderr]    |
[INFO] [stderr] 36 |         while let Some(line) = line_iter.next() {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^ help: try: `for line in line_iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/bin/day4.rs:39:59
[INFO] [stderr]    |
[INFO] [stderr] 39 |                     cur_guard = guard_map.entry(guard_id).or_insert(Guard::new(guard_id)).id;
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Guard::new(guard_id))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/bin/day4.rs:49:60
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 let mut guard = guard_map.entry(cur_guard).or_insert(Guard::new(cur_guard));
[INFO] [stderr]    |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Guard::new(cur_guard))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/bin/day4.rs:60:29
[INFO] [stderr]    |
[INFO] [stderr] 60 |         self.sleeping.iter().fold(0, |total, min| total+min)
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/bin/day3.rs:34:32
[INFO] [stderr]    |
[INFO] [stderr] 34 |     pub fn from_string(string: &String) -> Fabric {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day3.rs:48:29
[INFO] [stderr]    |
[INFO] [stderr] 48 | fn make_fabric_map(fabrics: &Vec<Fabric>) -> ClaimMap {
[INFO] [stderr]    |                             ^^^^^^^^^^^^ help: change this to: `&[Fabric]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/bin/day3.rs:54:51
[INFO] [stderr]    |
[INFO] [stderr] 54 |                 claim_map.fabric_map.entry((x,y)).or_insert(Vec::new()).push(fabric.id);
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.88s
[INFO] running `"docker" "inspect" "aea34401b30fd346924270b378900517f1c3a8eb94c8990538054e86f132ed77"`
[INFO] running `"docker" "rm" "-f" "aea34401b30fd346924270b378900517f1c3a8eb94c8990538054e86f132ed77"`
[INFO] [stdout] aea34401b30fd346924270b378900517f1c3a8eb94c8990538054e86f132ed77